Add a FeatureParam for disabling StorageAccessAPI grant refreshes [chromium/src : main]
Chris Fredrickson (Gerrit)
Attention is currently required from: Shuran Huang.
Chris Fredrickson would like Shuran Huang to review this change.
Add a FeatureParam for disabling StorageAccessAPI grant refreshes
When the param is disabled, we still create the SAA service, but all calls into it will be a no-op, and it will not start its periodic
cache-clearing timer.
Bug: 1450356
Change-Id: I694cd3c40a497db477a70f60e5e89d51ab69a75c
---
M chrome/browser/storage_access_api/storage_access_api_service_impl.cc
M chrome/browser/storage_access_api/storage_access_api_service_impl.h
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
4 files changed, 25 insertions(+), 1 deletion(-)
To view, visit change 4598574. To unsubscribe, or for help writing mail filters, visit settings.
Chris Fredrickson (Gerrit)
Attention is currently required from: Shuran Huang.
Patch set 3:Commit-Queue +1
Shuran Huang (Gerrit)
Attention is currently required from: Chris Fredrickson.
2 comments:
File chrome/browser/storage_access_api/storage_access_api_service_impl.cc:
Patch Set #4, Line 22:
grant_refreshes_enabled_This needs some test coverage.
Patch Set #4, Line 50:
grant_refreshes_enabled_This needs some test coverage.
To view, visit change 4598574. To unsubscribe, or for help writing mail filters, visit settings.
Chris Fredrickson (Gerrit)
Attention is currently required from: Shuran Huang.
2 comments:
File chrome/browser/storage_access_api/storage_access_api_service_impl.cc:
Patch Set #4, Line 22:
grant_refreshes_enabled_This needs some test coverage.
Done
Patch Set #4, Line 50:
grant_refreshes_enabled_This needs some test coverage.
Done
To view, visit change 4598574. To unsubscribe, or for help writing mail filters, visit settings.
Shuran Huang (Gerrit)
Attention is currently required from: Chris Fredrickson.
Patch set 5:Code-Review +1
1 comment:
Patchset:
Thanks!
To view, visit change 4598574. To unsubscribe, or for help writing mail filters, visit settings.
Chris Fredrickson (Gerrit)
Attention is currently required from: Joey Arhar.
Chris Fredrickson would like Joey Arhar to review this change.
Add a FeatureParam for disabling StorageAccessAPI grant refreshes
When the param is disabled, we still create the SAA service, but all calls into it will be a no-op, and it will not start its periodic
cache-clearing timer.
Bug: 1450356
Change-Id: I694cd3c40a497db477a70f60e5e89d51ab69a75c
---
M chrome/browser/storage_access_api/storage_access_api_service_impl.cc
M chrome/browser/storage_access_api/storage_access_api_service_impl.h
M chrome/browser/storage_access_api/storage_access_api_service_impl_unittest.cc
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
5 files changed, 82 insertions(+), 2 deletions(-)
Chris Fredrickson (Gerrit)
Attention is currently required from: Joey Arhar.
To view, visit change 4598574. To unsubscribe, or for help writing mail filters, visit settings.
Joey Arhar (Gerrit)
Attention is currently required from: Chris Fredrickson.
Patch set 5:Code-Review +1Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
Add a FeatureParam for disabling StorageAccessAPI grant refreshes
When the param is disabled, we still create the SAA service, but all calls into it will be a no-op, and it will not start its periodic
cache-clearing timer.
Bug: 1450356
Change-Id: I694cd3c40a497db477a70f60e5e89d51ab69a75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4598574
Reviewed-by: Joey Arhar <jar...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Reviewed-by: Shuran Huang <shu...@chromium.org>
Auto-Submit: Chris Fredrickson <cfre...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1155551}
---
M chrome/browser/storage_access_api/storage_access_api_service_impl.cc
M chrome/browser/storage_access_api/storage_access_api_service_impl.h
M chrome/browser/storage_access_api/storage_access_api_service_impl_unittest.cc
M third_party/blink/common/features.cc
M third_party/blink/public/common/features.h
5 files changed, 82 insertions(+), 2 deletions(-)