IDB WPTs: Extend three IDB WPTs to run on workers. [chromium/src : main]

0 views
Skip to first unread message

Sneha Agarwal (Gerrit)

unread,
Feb 11, 2025, 12:33:47 AMFeb 11
to Steve Becker, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Garima Chadha, Rahul Singh and Steve Becker

Sneha Agarwal added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sneha Agarwal . resolved

Hello,

This CL is ready for review.

Thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Garima Chadha
  • Rahul Singh
  • Steve Becker
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
Gerrit-Change-Number: 6251264
Gerrit-PatchSet: 1
Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
Gerrit-Attention: Steve Becker <ste...@microsoft.com>
Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
Gerrit-Comment-Date: Tue, 11 Feb 2025 00:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Garima Chadha (Gerrit)

unread,
Feb 11, 2025, 6:14:07 AMFeb 11
to Sneha Agarwal, Steve Becker, Rahul Singh, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Rahul Singh, Sneha Agarwal and Steve Becker

Garima Chadha added 3 comments

Patchset-level comments
Garima Chadha . resolved

Thanks Sneha for this change. I have left few comments mostly nit, otherwise LGTM. Thanks!

File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.any.js
Line 14, Patchset 1 (Latest): 'getAll',
Garima Chadha . unresolved

nit: Ensure consistent indentation and spacing throughout the code for improved readability.

File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.any.js
Line 10, Patchset 1 (Latest): index => index.openCursor(), index => index.openKeyCursor()]
Garima Chadha . unresolved

nit: Can we keep the formatting as is for better readability?

Open in Gerrit

Related details

Attention is currently required from:
  • Rahul Singh
  • Sneha Agarwal
  • Steve Becker
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
    Gerrit-Change-Number: 6251264
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
    Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
    Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
    Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
    Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
    Gerrit-Attention: Steve Becker <ste...@microsoft.com>
    Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
    Gerrit-Comment-Date: Tue, 11 Feb 2025 06:13:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sneha Agarwal (Gerrit)

    unread,
    Feb 11, 2025, 6:36:55 PMFeb 11
    to Steve Becker, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Garima Chadha, Rahul Singh and Steve Becker

    Sneha Agarwal added 3 comments

    Patchset-level comments
    File-level comment, Patchset 1:
    Sneha Agarwal . resolved

    Hello,

    I have addressed the comments. Please +1 if this looks good. Thanks

    File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.any.js
    Line 14, Patchset 1: 'getAll',
    Garima Chadha . resolved

    nit: Ensure consistent indentation and spacing throughout the code for improved readability.

    Sneha Agarwal

    Done

    File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.any.js
    Line 10, Patchset 1: index => index.openCursor(), index => index.openKeyCursor()]
    Garima Chadha . resolved

    nit: Can we keep the formatting as is for better readability?

    Sneha Agarwal

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Garima Chadha
    • Rahul Singh
    • Steve Becker
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
    Gerrit-Change-Number: 6251264
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
    Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
    Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
    Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
    Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
    Gerrit-Attention: Steve Becker <ste...@microsoft.com>
    Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
    Gerrit-Comment-Date: Tue, 11 Feb 2025 18:36:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Garima Chadha <garima...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rahul Singh (Gerrit)

    unread,
    Feb 11, 2025, 9:41:43 PMFeb 11
    to Sneha Agarwal, Steve Becker, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
    Attention needed from Garima Chadha, Sneha Agarwal and Steve Becker

    Rahul Singh voted and added 4 comments

    Votes added by Rahul Singh

    Code-Review+1

    4 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Rahul Singh . resolved

    LGTM %ing a few comments. Thanks!

    File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.any.js
    Line 4, Patchset 2 (Latest):// Spec: "https://w3c.github.io/IndexedDB/#dom-idbindex-get"
    Rahul Singh . unresolved

    nit: Should we leave an empty line between the META block and the Spec links?

    Applies to other files with spec links too.

    File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.any.js
    Line 4, Patchset 2 (Latest):// Spec: "https://w3c.github.io/IndexedDB/#dom-idbrequest-source"
    Rahul Singh . unresolved

    nit: We don't need quotes around the spec link as part of updating this to an any.js file.

    Applies here and elsewhere in this change.

    File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
    Line 2, Patchset 2 (Latest):// META: title=IDBIndex.getKey() - returns the record's primary key
    Rahul Singh . unresolved

    Not from your chnage but I don't think we test getKey() here.
    So maybe we can just title this "IDBObjectStore Index Names"

    Then in line 27 maybe we could do "IDBObjectStore.indexNames - verifies index creation and retrieval"?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Garima Chadha
    • Sneha Agarwal
    • Steve Becker
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Attention: Steve Becker <ste...@microsoft.com>
      Gerrit-Comment-Date: Tue, 11 Feb 2025 21:41:29 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Steve Becker (Gerrit)

      unread,
      Feb 12, 2025, 12:18:53 AMFeb 12
      to Sneha Agarwal, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha and Sneha Agarwal

      Steve Becker voted and added 1 comment

      Votes added by Steve Becker

      Code-Review+1

      1 comment

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
      Line 2, Patchset 2 (Latest):// META: title=IDBIndex.getKey() - returns the record's primary key
      Rahul Singh . unresolved

      Not from your chnage but I don't think we test getKey() here.
      So maybe we can just title this "IDBObjectStore Index Names"

      Then in line 27 maybe we could do "IDBObjectStore.indexNames - verifies index creation and retrieval"?

      Steve Becker

      +1. Nice catch Rahul!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Sneha Agarwal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Comment-Date: Wed, 12 Feb 2025 00:18:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Rahul Singh <rah...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sneha Agarwal (Gerrit)

      unread,
      Feb 15, 2025, 12:05:38 AMFeb 15
      to Chromium LUCI CQ, Steve Becker, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha, Rahul Singh and Steve Becker

      Sneha Agarwal added 4 comments

      Patchset-level comments
      File-level comment, Patchset 2:
      Sneha Agarwal . resolved

      Hi Rahul,

      I have addressed your comments. Thanks

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.any.js

      nit: Should we leave an empty line between the META block and the Spec links?

      Applies to other files with spec links too.

      Sneha Agarwal

      Done

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.any.js

      nit: We don't need quotes around the spec link as part of updating this to an any.js file.

      Applies here and elsewhere in this change.

      Sneha Agarwal

      Done

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
      Line 2, Patchset 2:// META: title=IDBIndex.getKey() - returns the record's primary key
      Rahul Singh . resolved

      Not from your chnage but I don't think we test getKey() here.
      So maybe we can just title this "IDBObjectStore Index Names"

      Then in line 27 maybe we could do "IDBObjectStore.indexNames - verifies index creation and retrieval"?

      Steve Becker

      +1. Nice catch Rahul!

      Sneha Agarwal

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Rahul Singh
      • Steve Becker
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
      Gerrit-Comment-Date: Sat, 15 Feb 2025 00:05:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Steve Becker <ste...@microsoft.com>
      Comment-In-Reply-To: Rahul Singh <rah...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Steve Becker (Gerrit)

      unread,
      Feb 18, 2025, 8:07:59 PMFeb 18
      to Sneha Agarwal, Chromium LUCI CQ, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha, Rahul Singh and Sneha Agarwal

      Steve Becker voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Rahul Singh
      • Sneha Agarwal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 3
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
      Gerrit-Comment-Date: Tue, 18 Feb 2025 20:07:45 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rahul Singh (Gerrit)

      unread,
      Feb 18, 2025, 8:11:02 PMFeb 18
      to Sneha Agarwal, Steve Becker, Chromium LUCI CQ, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha and Sneha Agarwal

      Rahul Singh voted and added 2 comments

      Votes added by Rahul Singh

      Code-Review+1

      2 comments

      Patchset-level comments
      File-level comment, Patchset 3 (Latest):
      Rahul Singh . resolved

      Just one more updated needed. LGTM otherwise.

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
      Line 2, Patchset 2:// META: title=IDBIndex.getKey() - returns the record's primary key
      Rahul Singh . unresolved

      Not from your chnage but I don't think we test getKey() here.
      So maybe we can just title this "IDBObjectStore Index Names"

      Then in line 27 maybe we could do "IDBObjectStore.indexNames - verifies index creation and retrieval"?

      Steve Becker

      +1. Nice catch Rahul!

      Sneha Agarwal

      Done

      Rahul Singh

      Updated title looks good. Reminder to also update line 27 below.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Sneha Agarwal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 3
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Comment-Date: Tue, 18 Feb 2025 20:10:49 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Sneha Agarwal <sneha...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Sneha Agarwal (Gerrit)

      unread,
      Feb 19, 2025, 12:19:49 AMFeb 19
      to Rahul Singh, Steve Becker, Chromium LUCI CQ, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha, Rahul Singh and Steve Becker

      Sneha Agarwal added 2 comments

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Sneha Agarwal . resolved

      Thanks Rahul, I have addressed your comments.

      File third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
      Line 2, Patchset 2:// META: title=IDBIndex.getKey() - returns the record's primary key
      Rahul Singh . resolved

      Not from your chnage but I don't think we test getKey() here.
      So maybe we can just title this "IDBObjectStore Index Names"

      Then in line 27 maybe we could do "IDBObjectStore.indexNames - verifies index creation and retrieval"?

      Steve Becker

      +1. Nice catch Rahul!

      Sneha Agarwal

      Done

      Rahul Singh

      Updated title looks good. Reminder to also update line 27 below.

      Sneha Agarwal

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Rahul Singh
      • Steve Becker
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Rahul Singh <rah...@microsoft.com>
      Gerrit-Comment-Date: Wed, 19 Feb 2025 00:19:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rahul Singh (Gerrit)

      unread,
      Feb 19, 2025, 12:38:08 AMFeb 19
      to Sneha Agarwal, Steve Becker, Chromium LUCI CQ, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha, Sneha Agarwal and Steve Becker

      Rahul Singh voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Sneha Agarwal
      • Steve Becker
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Attention: Steve Becker <ste...@microsoft.com>
      Gerrit-Comment-Date: Wed, 19 Feb 2025 00:37:57 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Steve Becker (Gerrit)

      unread,
      Feb 19, 2025, 12:56:05 AMFeb 19
      to Sneha Agarwal, Rahul Singh, Chromium LUCI CQ, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha and Sneha Agarwal

      Steve Becker voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      • Sneha Agarwal
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Attention: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Comment-Date: Wed, 19 Feb 2025 00:55:52 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Sneha Agarwal (Gerrit)

      unread,
      Feb 19, 2025, 6:50:36 PMFeb 19
      to Steve Becker, Rahul Singh, Chromium LUCI CQ, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org
      Attention needed from Garima Chadha

      Sneha Agarwal voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Garima Chadha
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-Attention: Garima Chadha <garima...@microsoft.com>
      Gerrit-Comment-Date: Wed, 19 Feb 2025 18:50:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 19, 2025, 7:22:24 PMFeb 19
      to Sneha Agarwal, Steve Becker, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      IDB WPTs: Extend three IDB WPTs to run on workers.

      This set of IndexedDB WPTs currently only run in a window environment.
      This change extends them to also run in dedicated, shared, and service
      worker environments.
      Bug: 41455766
      Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Reviewed-by: Steve Becker <ste...@microsoft.com>
      Reviewed-by: Rahul Singh <rah...@microsoft.com>
      Commit-Queue: Sneha Agarwal <sneha...@microsoft.com>
      Cr-Commit-Position: refs/heads/main@{#1422100}
      Files:
      • A third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.any.js
      • D third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-query-exception-order.html
      • A third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.any.js
      • D third_party/blink/web_tests/external/wpt/IndexedDB/idbindex-request-source.html
      • A third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.any.js
      • D third_party/blink/web_tests/external/wpt/IndexedDB/idbindex_indexNames.htm
      Change size: L
      Delta: 6 files changed, 121 insertions(+), 135 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Steve Becker, +1 by Rahul Singh
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 5
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Feb 19, 2025, 8:29:31 PMFeb 19
      to Sneha Agarwal, Chromium LUCI CQ, Steve Becker, Rahul Singh, Garima Chadha, chromium...@chromium.org, edgecapab...@microsoft.com, blink-revie...@chromium.org, blink-...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/50809

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I57a1781edc007b0134489725d713e6ebabddd60f
      Gerrit-Change-Number: 6251264
      Gerrit-PatchSet: 5
      Gerrit-Owner: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Garima Chadha <garima...@microsoft.com>
      Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>
      Gerrit-Reviewer: Sneha Agarwal <sneha...@microsoft.com>
      Gerrit-Reviewer: Steve Becker <ste...@microsoft.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-Comment-Date: Wed, 19 Feb 2025 20:29:19 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages