Freeze the enum value of kWebTextInputTypePassword/TEXT_INPUT_TYPE_PASSWORD [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
11:58 AM (9 hours ago) 11:58 AM
to Avi Drissman, Keren Zhu, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, James Su, blink-re...@chromium.org, blink-...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Daniel Cheng and Keren Zhu

Avi Drissman added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Avi Drissman . resolved

keren overall, dcheng for blink

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Keren Zhu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5020a740ccb008e266916349533992f5ea57d825
Gerrit-Change-Number: 7042401
Gerrit-PatchSet: 1
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-Attention: Keren Zhu <kere...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Wed, 15 Oct 2025 15:58:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Keren Zhu (Gerrit)

unread,
12:28 PM (9 hours ago) 12:28 PM
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, James Su, blink-re...@chromium.org, blink-...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Avi Drissman and Daniel Cheng

Keren Zhu added 1 comment

File third_party/blink/public/platform/web_text_input_type.h
Line 51, Patchset 1 (Latest): kWebTextInputTypePassword = 2,
Keren Zhu . unresolved

I think Blink does not this. The `blink::WebTextInputType` enum will be translated to the `ui::TextInputType` enum in https://source.chromium.org/chromium/chromium/src/+/main:content/child/assert_matching_enums.cc;l=39-40?q=kWebTextInputTypePassword&ss=chromium.

Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5020a740ccb008e266916349533992f5ea57d825
    Gerrit-Change-Number: 7042401
    Gerrit-PatchSet: 1
    Gerrit-Owner: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 16:27:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Keren Zhu (Gerrit)

    unread,
    12:30 PM (9 hours ago) 12:30 PM
    to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, James Su, blink-re...@chromium.org, blink-...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Avi Drissman and Daniel Cheng

    Keren Zhu added 1 comment

    File third_party/blink/public/platform/web_text_input_type.h
    Line 51, Patchset 1 (Latest): kWebTextInputTypePassword = 2,
    Keren Zhu . unresolved

    I think Blink does not this. The `blink::WebTextInputType` enum will be translated to the `ui::TextInputType` enum in https://source.chromium.org/chromium/chromium/src/+/main:content/child/assert_matching_enums.cc;l=39-40?q=kWebTextInputTypePassword&ss=chromium.

    Keren Zhu

    I think Blink does not this.

    typo - I think Blink does not need this.

    Gerrit-Comment-Date: Wed, 15 Oct 2025 16:30:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Keren Zhu <kere...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Avi Drissman (Gerrit)

    unread,
    1:03 PM (8 hours ago) 1:03 PM
    to Avi Drissman, Keren Zhu, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, James Su, blink-re...@chromium.org, blink-...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
    Attention needed from Daniel Cheng and Keren Zhu

    Avi Drissman added 1 comment

    File third_party/blink/public/platform/web_text_input_type.h
    Line 51, Patchset 1: kWebTextInputTypePassword = 2,
    Keren Zhu . resolved

    I think Blink does not this. The `blink::WebTextInputType` enum will be translated to the `ui::TextInputType` enum in https://source.chromium.org/chromium/chromium/src/+/main:content/child/assert_matching_enums.cc;l=39-40?q=kWebTextInputTypePassword&ss=chromium.

    Keren Zhu

    I think Blink does not this.

    typo - I think Blink does not need this.

    Avi Drissman

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    • Keren Zhu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I5020a740ccb008e266916349533992f5ea57d825
      Gerrit-Change-Number: 7042401
      Gerrit-PatchSet: 2
      Gerrit-Owner: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
      Gerrit-CC: James Su <su...@chromium.org>
      Gerrit-Attention: Keren Zhu <kere...@chromium.org>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Wed, 15 Oct 2025 17:03:34 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Keren Zhu (Gerrit)

      unread,
      1:44 PM (7 hours ago) 1:44 PM
      to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, James Su, blink-re...@chromium.org, blink-...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
      Attention needed from Avi Drissman and Daniel Cheng

      Keren Zhu voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Avi Drissman
      • Daniel Cheng
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I5020a740ccb008e266916349533992f5ea57d825
        Gerrit-Change-Number: 7042401
        Gerrit-PatchSet: 2
        Gerrit-Owner: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Keren Zhu <kere...@chromium.org>
        Gerrit-CC: James Su <su...@chromium.org>
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Wed, 15 Oct 2025 17:44:11 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages