Use generated IDL enums when setting fields [rtc,*media*,webcodecs] [chromium/src : main]

0 views
Skip to first unread message

Fredrik Söderquist (Gerrit)

unread,
Sep 22, 2025, 8:28:12 AM (3 days ago) Sep 22
to Kent Tamura, chromium...@chromium.org, srirama chandra sekhar, Chromium LUCI CQ, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Kent Tamura

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I21a123445e6669c4ec0a3562854c5797079ca8e2
Gerrit-Change-Number: 6973358
Gerrit-PatchSet: 1
Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Sep 2025 12:27:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Sep 23, 2025, 6:16:40 PM (2 days ago) Sep 23
to Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, srirama chandra sekhar, Chromium LUCI CQ, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com
Attention needed from Fredrik Söderquist

Kent Tamura voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I21a123445e6669c4ec0a3562854c5797079ca8e2
    Gerrit-Change-Number: 6973358
    Gerrit-PatchSet: 1
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
    Gerrit-Comment-Date: Tue, 23 Sep 2025 22:16:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 23, 2025, 8:32:59 PM (2 days ago) Sep 23
    to Fredrik Söderquist, Kent Tamura, chromium...@chromium.org, srirama chandra sekhar, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, tommyw+w...@chromium.org, video-networking...@google.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Use generated IDL enums when setting fields [rtc,*media*,webcodecs]
    Bug: 430171134
    Change-Id: I21a123445e6669c4ec0a3562854c5797079ca8e2
    Auto-Submit: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Reviewed-by: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1519696}
    Files:
    • M third_party/blink/renderer/modules/encryptedmedia/media_key_session.cc
    • M third_party/blink/renderer/modules/mediastream/media_devices.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
    • M third_party/blink/renderer/modules/peerconnection/rtc_rtp_sender.cc
    • M third_party/blink/renderer/modules/webcodecs/audio_data_test.cc
    • M third_party/blink/renderer/modules/webcodecs/encoded_audio_chunk_test.cc
    • M third_party/blink/renderer/modules/webcodecs/encoded_video_chunk_test.cc
    • M third_party/blink/renderer/modules/webcodecs/video_frame_test.cc
    Change size: M
    Delta: 8 files changed, 56 insertions(+), 44 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kent Tamura
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I21a123445e6669c4ec0a3562854c5797079ca8e2
    Gerrit-Change-Number: 6973358
    Gerrit-PatchSet: 2
    Gerrit-Owner: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages