ScrollPredictor: Refine HasPrediction timeout logic behind flag. [chromium/src : main]
0 views
Skip to first unread message
Aman Verma (Gerrit)
Feb 24, 2026, 12:08:41 PM (4 days ago) Feb 24
to Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Jonathan Ross
Aman Verma voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jonathan Ross (Gerrit)
Feb 25, 2026, 4:13:07 PM (3 days ago) Feb 25
to Aman Verma, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Aman Verma
Jonathan Ross voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jonathan Ross
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jonathan Ross . resolved
Like the concise testing as well. LGTM
Related details
Attention is currently required from:
- Aman Verma
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aman Verma (Gerrit)
Feb 26, 2026, 5:59:02 AM (3 days ago) Feb 26
to Daniel Cheng, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng and Jonathan Ross
Aman Verma voted Commit-Queue+1![]( "Open in Gerrit")
Attention is currently required from:
- Daniel Cheng
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aman Verma (Gerrit)
Feb 26, 2026, 5:59:30 AM (3 days ago) Feb 26
to Daniel Cheng, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng and Jonathan Ross
Aman Verma added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Aman Verma . resolved
+dcheng@ for
third_party/blink/common/ features.cc
third_party/blink/public/common/ features.h
Thanks!
Daniel Cheng (Gerrit)
Feb 26, 2026, 2:48:48 PM (2 days ago) Feb 26
to Aman Verma, Daniel Cheng, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Aman Verma and Jonathan Ross
Daniel Cheng voted![]( "Open in Gerrit")
Attention is currently required from:
- Aman Verma
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aman Verma (Gerrit)
Feb 26, 2026, 3:02:21 PM (2 days ago) Feb 26
to Daniel Cheng, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng and Jonathan Ross
Aman Verma voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Daniel Cheng
- Jonathan Ross
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Aman Verma (Gerrit)
Feb 26, 2026, 3:09:32 PM (2 days ago) Feb 26
to Daniel Cheng, Jonathan Ross, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Aman Verma voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:05 PM (7 hours ago) 2:05 PM
to Aman Verma, Daniel Cheng, Jonathan Ross, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ScrollPredictor: Refine HasPrediction timeout logic behind flag.
This CL introduces a feature flag kScrollPredictorRefinedHasPrediction
that adjusts the timeout logic in ScrollPredictor::HasPrediction.
Original logic:
frame_time - last_prediction_update_timestamp_ > MaxResampleTime()
Refined logic:
prediction_time = frame_time + ResampleLatency(frame_interval);
prediction_time - last_prediction_update_timestamp_ > MaxResampleTime()
This accounts for the resample latency (which can be negative or positive)
when deciding whether to drop a synthetic prediction event.
Test: blink_platform_unittests --gtest_filter=ScrollPredictorTest.RefinedHasPredictionTimeout
Bug: b:487250797
Change-Id: I1735ed9efdcd01059fc559f67bdcc6e31d2b2f5c
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Auto-Submit: Aman Verma <ama...@google.com>
Commit-Queue: Aman Verma <ama...@google.com>
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1592056}
Files:
- M third_party/blink/common/features.cc
- M third_party/blink/public/common/features.h
- M third_party/blink/renderer/platform/widget/input/input_handler_proxy.cc
- M third_party/blink/renderer/platform/widget/input/scroll_predictor.cc
- M third_party/blink/renderer/platform/widget/input/scroll_predictor.h
- M third_party/blink/renderer/platform/widget/input/scroll_predictor_unittest.cc
Change size: M
Delta: 6 files changed, 75 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jonathan Ross, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages