[WebAudio] Add basic context tests for renderSizeHint feature [chromium/src : main]

0 views

Skip to first unread message

Hongchan Choi (Gerrit)

unread,

12:28 PM (2 hours ago) 12:28 PM

to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Michael Wilson

Hongchan Choi added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Hongchan Choi . resolved

PTAL

This is the first piece of the test suite.

Open in Gerrit

Related details

Attention is currently required from:

Michael Wilson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Wilson (Gerrit)

unread,

1:59 PM (17 minutes ago) 1:59 PM

to Hongchan Choi, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Hongchan Choi

Michael Wilson added 1 comment

File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-rendersizehint.html

Line 77, Patchset 4 (Latest): `renderQuantumSize (${actualSize}) must match one of the allowed spec ` +

Michael Wilson . unresolved

These strategies are not in the spec. Please refer to https://webaudio.github.io/web-audio-api/#render-quantum-sizes