[webaudio] Migrate DynamicsCompressor reduction test to testharness.js [chromium/src : main]

0 views
Skip to first unread message

Michael Wilson (Gerrit)

unread,
Jun 17, 2025, 7:46:23 PMJun 17
to Punith Nayak, Alvin Ji, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Alvin Ji and Punith Nayak

Michael Wilson added 4 comments

File third_party/blink/web_tests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
Line 15, Patchset 2 (Latest): * Idea:
Michael Wilson . unresolved

We probably don't need the `Idea:` line here. I like the overview description of the test!

Line 16, Patchset 2 (Latest): * - Feed a DC signal (1 × 0.5 s) through a DynamicsCompressor.
Michael Wilson . unresolved

I think this should be 5 seconds.

Line 33, Patchset 2 (Latest): /* 0.5 s buffer full-scale DC (value = 1) */
Michael Wilson . unresolved

Isn't this 5 seconds, not 0.5 seconds?
Also nit: let's use // for single-line comments.

Line 52, Patchset 2 (Parent): // Error threshold experimentally determined.
Michael Wilson . unresolved

Let's keep this comment.

Open in Gerrit

Related details

Attention is currently required from:
  • Alvin Ji
  • Punith Nayak
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
Gerrit-Change-Number: 6651987
Gerrit-PatchSet: 2
Gerrit-Owner: Punith Nayak <punith...@chromium.org>
Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
Gerrit-Attention: Alvin Ji <alv...@chromium.org>
Gerrit-Attention: Punith Nayak <punith...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 23:46:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Punith Nayak (Gerrit)

unread,
Jun 19, 2025, 4:03:09 PMJun 19
to Alvin Ji, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Alvin Ji and Michael Wilson

Punith Nayak added 4 comments

File third_party/blink/web_tests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
Line 15, Patchset 2: * Idea:
Michael Wilson . resolved

We probably don't need the `Idea:` line here. I like the overview description of the test!

Punith Nayak

Done

Line 16, Patchset 2: * - Feed a DC signal (1 × 0.5 s) through a DynamicsCompressor.
Michael Wilson . resolved

I think this should be 5 seconds.

Punith Nayak

Done

Line 33, Patchset 2: /* 0.5 s buffer full-scale DC (value = 1) */
Michael Wilson . resolved

Isn't this 5 seconds, not 0.5 seconds?
Also nit: let's use // for single-line comments.

Punith Nayak

Done

Line 52, Patchset 2 (Parent): // Error threshold experimentally determined.
Michael Wilson . resolved

Let's keep this comment.

Punith Nayak

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Alvin Ji
  • Michael Wilson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
Gerrit-Change-Number: 6651987
Gerrit-PatchSet: 4
Gerrit-Owner: Punith Nayak <punith...@chromium.org>
Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
Gerrit-Attention: Alvin Ji <alv...@chromium.org>
Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Jun 2025 20:02:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Wilson <mjwi...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Wilson (Gerrit)

unread,
Jun 20, 2025, 1:08:53 PMJun 20
to Punith Nayak, Alvin Ji, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Alvin Ji and Punith Nayak

Michael Wilson voted and added 2 comments

Votes added by Michael Wilson

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Michael Wilson . resolved

LGTM % formatting / trailing whitespace on the overview comment (may need to reformat the lines)

File third_party/blink/web_tests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
Line 15, Patchset 4 (Latest): * - Feed a DC signal (value = 1, duration = 5 s)
Michael Wilson . unresolved

Please fix this WARNING reported by Check Contents: Please remove the trailing whitespace.

Analyzer Description: Validates that changes do not have discouraged expressions in them.
Owner: ayeay...@google.com

Please remove the trailing whitespace.

To rerun the analyzer locally, run: `alint -- -c CheckContents`

For more information, see go/alint.

Open in Gerrit

Related details

Attention is currently required from:
  • Alvin Ji
  • Punith Nayak
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 4
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-Attention: Alvin Ji <alv...@chromium.org>
    Gerrit-Attention: Punith Nayak <punith...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 17:08:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Punith Nayak (Gerrit)

    unread,
    Jun 20, 2025, 4:30:36 PMJun 20
    to Alvin Ji, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
    Attention needed from Alvin Ji and Michael Wilson

    Punith Nayak added 1 comment

    File third_party/blink/web_tests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
    Line 15, Patchset 4: * - Feed a DC signal (value = 1, duration = 5 s)
    Michael Wilson . resolved

    Please fix this WARNING reported by Check Contents: Please remove the trailing whitespace.

    Analyzer Description: Validates that changes do not have discouraged expressions in them.
    Owner: ayeay...@google.com

    Please remove the trailing whitespace.

    To rerun the analyzer locally, run: `alint -- -c CheckContents`

    For more information, see go/alint.

    Punith Nayak

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alvin Ji
    • Michael Wilson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 5
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-Attention: Alvin Ji <alv...@chromium.org>
    Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 20:30:08 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michael Wilson (Gerrit)

    unread,
    Jun 20, 2025, 4:49:13 PMJun 20
    to Punith Nayak, Alvin Ji, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
    Attention needed from Alvin Ji and Punith Nayak

    Michael Wilson voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alvin Ji
    • Punith Nayak
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 5
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-Attention: Alvin Ji <alv...@chromium.org>
    Gerrit-Attention: Punith Nayak <punith...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Jun 2025 20:49:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alvin Ji (Gerrit)

    unread,
    Jun 20, 2025, 11:46:51 PMJun 20
    to Punith Nayak, Adam Raine, Hongchan Choi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
    Attention needed from Punith Nayak

    Alvin Ji voted and added 1 comment

    Votes added by Alvin Ji

    Code-Review+1

    1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Punith Nayak
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 5
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-CC: Adam Raine <asr...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-Attention: Punith Nayak <punith...@chromium.org>
    Gerrit-Comment-Date: Sat, 21 Jun 2025 03:46:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Punith Nayak (Gerrit)

    unread,
    Jun 24, 2025, 3:46:55 PMJun 24
    to Alvin Ji, Adam Raine, Hongchan Choi, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org

    Punith Nayak voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 5
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-CC: Adam Raine <asr...@chromium.org>
    Gerrit-CC: Hongchan Choi <hong...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Jun 2025 19:46:24 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 24, 2025, 4:10:42 PMJun 24
    to Punith Nayak, Alvin Ji, Adam Raine, Hongchan Choi, AyeAye, chromium...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [webaudio] Migrate DynamicsCompressor reduction test to testharness.js

    Replaces audit.js usage with testharness.js in the
    dynamics-compressor-reduction test. Preserves original graph setup,
    timing, and verification logic. Uses modern AudioNode constructors and
    drops Audit.createTaskRunner for a native promise_test.
    Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Commit-Queue: Punith Nayak <punith...@chromium.org>
    Reviewed-by: Alvin Ji <alv...@chromium.org>
    Reviewed-by: Michael Wilson <mjwi...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1478151}
    Files:
    • M third_party/blink/web_tests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html
    Change size: M
    Delta: 1 file changed, 39 insertions(+), 43 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Alvin Ji, +1 by Michael Wilson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iccba3ae3b7db993f62df0dffc091024479ad8fc6
    Gerrit-Change-Number: 6651987
    Gerrit-PatchSet: 6
    Gerrit-Owner: Punith Nayak <punith...@chromium.org>
    Gerrit-Reviewer: Alvin Ji <alv...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Punith Nayak <punith...@chromium.org>
    Gerrit-CC: Adam Raine <asr...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages