* Idea:
We probably don't need the `Idea:` line here. I like the overview description of the test!
* - Feed a DC signal (1 × 0.5 s) through a DynamicsCompressor.
I think this should be 5 seconds.
/* 0.5 s buffer full-scale DC (value = 1) */
Isn't this 5 seconds, not 0.5 seconds?
Also nit: let's use // for single-line comments.
// Error threshold experimentally determined.
Let's keep this comment.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
We probably don't need the `Idea:` line here. I like the overview description of the test!
Done
* - Feed a DC signal (1 × 0.5 s) through a DynamicsCompressor.
I think this should be 5 seconds.
Done
Isn't this 5 seconds, not 0.5 seconds?
Also nit: let's use // for single-line comments.
Done
// Error threshold experimentally determined.
Let's keep this comment.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
LGTM % formatting / trailing whitespace on the overview comment (may need to reformat the lines)
* - Feed a DC signal (value = 1, duration = 5 s)
Please fix this WARNING reported by Check Contents: Please remove the trailing whitespace.
Analyzer Description: Validates that changes do not have discouraged expressions in them.
Owner: ayeay...@google.com
Please remove the trailing whitespace.
To rerun the analyzer locally, run: `alint -- -c CheckContents`
For more information, see go/alint.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Please fix this WARNING reported by Check Contents: Please remove the trailing whitespace.
Analyzer Description: Validates that changes do not have discouraged expressions in them.
Owner: ayeay...@google.comPlease remove the trailing whitespace.
To rerun the analyzer locally, run: `alint -- -c CheckContents`
For more information, see go/alint.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Commit-Queue | +2 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[webaudio] Migrate DynamicsCompressor reduction test to testharness.js
Replaces audit.js usage with testharness.js in the
dynamics-compressor-reduction test. Preserves original graph setup,
timing, and verification logic. Uses modern AudioNode constructors and
drops Audit.createTaskRunner for a native promise_test.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |