Use the single-compound fast path in closest(). [chromium/src : main]

0 views
Skip to first unread message

Zhou, Shuangshuang (Gerrit)

unread,
Jul 24, 2026, 3:35:57 AM (3 days ago) Jul 24
to Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Morten Stenshorne and Rune Lillesveen

Zhou, Shuangshuang added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Zhou, Shuangshuang . resolved

Hi Rune&Morten, PTAL!
Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I407862f795f9ee8426579b35730eaa6bdc857f71
Gerrit-Change-Number: 8138925
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou, Shuangshuang <shuangsh...@intel.com>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Zhou, Shuangshuang <shuangsh...@intel.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Jul 2026 07:35:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Jul 24, 2026, 5:27:00 AM (3 days ago) Jul 24
to Zhou, Shuangshuang, Rune Lillesveen, Morten Stenshorne, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Morten Stenshorne and Zhou, Shuangshuang

Rune Lillesveen voted and added 1 comment

Votes added by Rune Lillesveen

Code-Review+1

1 comment

Patchset-level comments
Rune Lillesveen . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Morten Stenshorne
  • Zhou, Shuangshuang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I407862f795f9ee8426579b35730eaa6bdc857f71
Gerrit-Change-Number: 8138925
Gerrit-PatchSet: 1
Gerrit-Owner: Zhou, Shuangshuang <shuangsh...@intel.com>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Reviewer: Zhou, Shuangshuang <shuangsh...@intel.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Zhou, Shuangshuang <shuangsh...@intel.com>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Fri, 24 Jul 2026 09:26:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Morten Stenshorne (Gerrit)

unread,
Jul 24, 2026, 5:37:22 AM (3 days ago) Jul 24
to Zhou, Shuangshuang, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
Attention needed from Zhou, Shuangshuang

Morten Stenshorne voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Zhou, Shuangshuang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I407862f795f9ee8426579b35730eaa6bdc857f71
    Gerrit-Change-Number: 8138925
    Gerrit-PatchSet: 1
    Gerrit-Owner: Zhou, Shuangshuang <shuangsh...@intel.com>
    Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Reviewer: Zhou, Shuangshuang <shuangsh...@intel.com>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Zhou, Shuangshuang <shuangsh...@intel.com>
    Gerrit-Comment-Date: Fri, 24 Jul 2026 09:35:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Morten Stenshorne (Gerrit)

    unread,
    Jul 24, 2026, 6:14:49 AM (3 days ago) Jul 24
    to Zhou, Shuangshuang, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
    Attention needed from Zhou, Shuangshuang

    Morten Stenshorne removed a vote from this change

    Removed Code-Review+1 by Morten Stenshorne <mste...@chromium.org>
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Zhou, Shuangshuang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: deleteVote
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Morten Stenshorne (Gerrit)

      unread,
      Jul 24, 2026, 6:15:14 AM (3 days ago) Jul 24
      to Zhou, Shuangshuang, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
      Attention needed from Zhou, Shuangshuang

      Morten Stenshorne voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Zhou, Shuangshuang
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I407862f795f9ee8426579b35730eaa6bdc857f71
        Gerrit-Change-Number: 8138925
        Gerrit-PatchSet: 1
        Gerrit-Owner: Zhou, Shuangshuang <shuangsh...@intel.com>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Reviewer: Zhou, Shuangshuang <shuangsh...@intel.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-Attention: Zhou, Shuangshuang <shuangsh...@intel.com>
        Gerrit-Comment-Date: Fri, 24 Jul 2026 10:14:55 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Zhou, Shuangshuang (Gerrit)

        unread,
        Jul 26, 2026, 7:40:21 PM (9 hours ago) Jul 26
        to Morten Stenshorne, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org

        Zhou, Shuangshuang voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I407862f795f9ee8426579b35730eaa6bdc857f71
        Gerrit-Change-Number: 8138925
        Gerrit-PatchSet: 1
        Gerrit-Owner: Zhou, Shuangshuang <shuangsh...@intel.com>
        Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
        Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
        Gerrit-Reviewer: Zhou, Shuangshuang <shuangsh...@intel.com>
        Gerrit-CC: Menard, Alexis <alexis...@intel.com>
        Gerrit-Comment-Date: Sun, 26 Jul 2026 23:40:03 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Zhou, Shuangshuang (Gerrit)

        unread,
        1:22 AM (3 hours ago) 1:22 AM
        to Morten Stenshorne, Rune Lillesveen, Chromium LUCI CQ, Menard, Alexis, android-bu...@system.gserviceaccount.com, blink-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org
        Gerrit-Comment-Date: Mon, 27 Jul 2026 05:22:32 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages