Unship KeyboardFocusableScrollers, temporarily [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Aug 20, 2024, 8:17:36 PM8/20/24
to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Di Zhang

Mason Freed voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Di Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5801654
Gerrit-PatchSet: 2
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 00:17:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Di Zhang (Gerrit)

unread,
Aug 20, 2024, 9:08:31 PM8/20/24
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Di Zhang voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5801654
Gerrit-PatchSet: 2
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Kyra Seevers <kyras...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 01:08:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 20, 2024, 9:27:14 PM8/20/24
to Mason Freed, Di Zhang, chromium...@chromium.org, Kyra Seevers, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Unship KeyboardFocusableScrollers, temporarily

See [1] for details, but due to compat issues, we are going to
disable the feature while we make some adjustments to the
behavior.

This was enabled by default in [2], which landed in M129, so this
CL will need to be merged back to 129.

[1] https://issues.chromium.org/issues/361072782#comment7
[2] https://chromium-review.googlesource.com/c/chromium/src/+/5775613
Fixed: 361072782
Bug: 337158524
Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Auto-Submit: Mason Freed <mas...@chromium.org>
Reviewed-by: Di Zhang <dizh...@chromium.org>
Commit-Queue: Di Zhang <dizh...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344534}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: S
Delta: 1 file changed, 5 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Di Zhang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I23b451f3ec7db2f8669c62b0cb69c1df6d84edeb
Gerrit-Change-Number: 5801654
Gerrit-PatchSet: 3
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages