Fix WPT html/semantics/rellist-feature-detection.html for a, area, form [chromium/src : main]

0 views
Skip to first unread message

Di Zhang (Gerrit)

unread,
Jun 27, 2022, 7:14:40 PM6/27/22
to Joey Arhar, blink-rev...@chromium.org, blink-...@chromium.org

Attention is currently required from: Joey Arhar.

Di Zhang would like Joey Arhar to review this change.

View Change

Fix WPT html/semantics/rellist-feature-detection.html for a, area, form

Tests <a> and <area> were failing because in `html/rel_list.cc`, we need
to add the "opener" relation to the set `SupportedTokensAnchorAndArea`.
Opener was introduced as part of release 88 [1].

Test <form> was failing because it was not supporting rel attributes.
It is now fixed thanks to CL [2].
This CL adds it to the list of tagNames that supports desired tokens.

[1] https://chromestatus.com/feature/6140064063029248
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3587952/

Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
Fixed: 1195514
---
M third_party/blink/renderer/core/html/rel_list.cc
D third_party/blink/web_tests/platform/generic/external/wpt/html/semantics/rellist-feature-detection-expected.txt
2 files changed, 28 insertions(+), 11 deletions(-)


To view, visit change 3727530. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
Gerrit-Change-Number: 3727530
Gerrit-PatchSet: 1
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-MessageType: newchange

Di Zhang (Gerrit)

unread,
Jun 27, 2022, 7:14:47 PM6/27/22
to blink-rev...@chromium.org, blink-...@chromium.org, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Joey Arhar.

Patch set 1:Commit-Queue +1

View Change

    To view, visit change 3727530. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
    Gerrit-Change-Number: 3727530
    Gerrit-PatchSet: 1
    Gerrit-Owner: Di Zhang <dizh...@chromium.org>
    Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Mon, 27 Jun 2022 23:14:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Joey Arhar (Gerrit)

    unread,
    Jun 28, 2022, 12:36:45 PM6/28/22
    to Di Zhang, blink-rev...@chromium.org, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Di Zhang.

    Patch set 1:Code-Review +1Commit-Queue +2

    View Change

      To view, visit change 3727530. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
      Gerrit-Change-Number: 3727530
      Gerrit-PatchSet: 1
      Gerrit-Owner: Di Zhang <dizh...@chromium.org>
      Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: Di Zhang <dizh...@chromium.org>
      Gerrit-Comment-Date: Tue, 28 Jun 2022 16:36:38 +0000

      Chromium LUCI CQ (Gerrit)

      unread,
      Jun 28, 2022, 12:40:14 PM6/28/22
      to Di Zhang, blink-rev...@chromium.org, blink-...@chromium.org, Joey Arhar, chromium...@chromium.org

      Chromium LUCI CQ submitted this change.

      View Change


      Approvals: Joey Arhar: Looks good to me; Commit
      Fix WPT html/semantics/rellist-feature-detection.html for a, area, form

      Tests <a> and <area> were failing because in `html/rel_list.cc`, we need
      to add the "opener" relation to the set `SupportedTokensAnchorAndArea`.
      Opener was introduced as part of release 88 [1].

      Test <form> was failing because it was not supporting rel attributes.
      It is now fixed thanks to CL [2].
      This CL adds it to the list of tagNames that supports desired tokens.

      [1] https://chromestatus.com/feature/6140064063029248
      [2] https://chromium-review.googlesource.com/c/chromium/src/+/3587952/

      Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
      Fixed: 1195514
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727530
      Reviewed-by: Joey Arhar <jar...@chromium.org>
      Commit-Queue: Joey Arhar <jar...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1018727}

      ---
      M third_party/blink/renderer/core/html/rel_list.cc
      D third_party/blink/web_tests/platform/generic/external/wpt/html/semantics/rellist-feature-detection-expected.txt
      2 files changed, 32 insertions(+), 11 deletions(-)


      To view, visit change 3727530. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4b925ebe469ed9f2a5367032069ab72ac35c2dca
      Gerrit-Change-Number: 3727530
      Gerrit-PatchSet: 2
      Gerrit-Owner: Di Zhang <dizh...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-MessageType: merged
      Reply all
      Reply to author
      Forward
      0 new messages