Do not use * in variant names [chromium/src : main]
0 views
Skip to first unread message
Weizhong Xia (Gerrit)
Nov 12, 2024, 1:38:29 PMNov 12
to Mason Freed, Tricium, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Weizhong Xia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Weizhong Xia . resolved
Hi Mason, will you be able to review this for me? I see you once made a change to this file.
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Nov 13, 2024, 11:53:05 AMNov 13
to Weizhong Xia, Tricium, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Weizhong Xia
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Weizhong Xia
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Weizhong Xia (Gerrit)
Nov 13, 2024, 12:08:19 PMNov 13
to Mason Freed, Tricium, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Weizhong Xia voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Nov 13, 2024, 12:17:01 PMNov 13
to Weizhong Xia, Mason Freed, Tricium, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/49151.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 13, 2024, 12:38:36 PMNov 13
to Weizhong Xia, Blink W3C Test Autoroller, Mason Freed, Tricium, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Do not use * in variant names
Variant names will be append to test names, then that will cause problem
if we need add the tests to text expectations or test filter files.
'*' used here is meant to be part of a regular expression. As there
are always more than 0 character after 'HTML', use '+' instead.
Bug: None
Change-Id: I71cb68c27b85c82fce22cc082242f63840287713
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Weizhong Xia <weiz...@google.com>
Cr-Commit-Position: refs/heads/main@{#1382419}
Files:
- M third_party/blink/web_tests/external/wpt/html/dom/idlharness.https.html
- R third_party/blink/web_tests/external/wpt/html/dom/idlharness.https_exclude=(Document_Window_HTML.+)-expected.txt
- R third_party/blink/web_tests/external/wpt/html/dom/idlharness.https_include=HTML.+-expected.txt
Change size: XS
Delta: 3 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Nov 13, 2024, 1:10:22 PMNov 13
to Weizhong Xia, Chromium LUCI CQ, Mason Freed, Tricium, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/49151
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages