Handle ThrottlingURLLoader deletion during throttle calls [chromium/src : main]

0 views

Skip to first unread message

Hiroshige Hayashizaki (Gerrit)

unread,

Jul 2, 2024, 4:54:01 PM (14 hours ago) Jul 2

to Tsuyoshi Horo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Tsuyoshi Horo

Hiroshige Hayashizaki added 1 comment

File third_party/blink/common/loader/throttling_url_loader_unittest.cc

Line 341, Patchset 3 (Latest): response_url_ = response_url;

Hiroshige Hayashizaki . unresolved

This is moved before `will_process_response_callback_` which can delete the Throttling URL loader and then `this` as well.

Open in Gerrit

Related details

Attention is currently required from:

Tsuyoshi Horo

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Tsuyoshi Horo (Gerrit)

unread,

3:07 AM (3 hours ago) 3:07 AM

to Hiroshige Hayashizaki, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Hiroshige Hayashizaki

Tsuyoshi Horo voted and added 1 comment

Votes added by Tsuyoshi Horo

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Tsuyoshi Horo . resolved

lgtm

Thank you.