Michael Wilson (Gerrit)

unread,

Mar 7, 2026, 1:48:09 AMMar 7

to Hongchan Choi, Chromium LUCI CQ, kelsen liu, Mahesh Kannan, AyeAye, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Hongchan Choi

Michael Wilson added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Michael Wilson . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Hongchan Choi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hongchan Choi (Gerrit)

unread,

Mar 9, 2026, 6:44:56 PMMar 9

to Chromium LUCI CQ, kelsen liu, Mahesh Kannan, AyeAye, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Michael Wilson

Hongchan Choi voted and added 4 comments

Votes added by Hongchan Choi

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hongchan Choi . resolved

LGTM with nits

File third_party/blink/renderer/platform/audio/audio_bus.cc

Line 562, Patchset 1 (Latest):

      destinations[channel_index]
          .first(frames_to_process)
          .copy_from(sources[channel_index].first(frames_to_process));

Hongchan Choi . resolved

Isn't this just a channel-wise copy?

```suggestion
      destinations[channel_index].copy_from(sources[channel_index]);
```

Line 570, Patchset 1 (Latest): 0);

Hongchan Choi . resolved

Nit: type clarify

```suggestion
                        0.0f);
```

Line 709, Patchset 1 (Latest): destination[i] = (source_l[i] + source_r[i]) / 2;

Hongchan Choi . resolved

Nit: While we're at it... (another type clarify)

```suggestion
        destination[i] = (source_l[i] + source_r[i]) * 0.5f;
```

Open in Gerrit

Related details

Attention is currently required from:

Michael Wilson

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Michael Wilson (Gerrit)

unread,

Mar 9, 2026, 9:17:08 PMMar 9

to Hongchan Choi, Chromium LUCI CQ, kelsen liu, Mahesh Kannan, AyeAye, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Michael Wilson voted and added 3 comments

Votes added by Michael Wilson

Commit-Queue

+2

3 comments

File third_party/blink/renderer/platform/audio/audio_bus.cc

Line 562, Patchset 1:

      destinations[channel_index]
          .first(frames_to_process)
          .copy_from(sources[channel_index].first(frames_to_process));

Hongchan Choi . resolved

Isn't this just a channel-wise copy?

```suggestion
      destinations[channel_index].copy_from(sources[channel_index]);
```

Michael Wilson

I wanted to be explicit about the number of frames that were being copied. If it's not necessary let's fix it in a follow-up.

Line 570, Patchset 1: 0);

Hongchan Choi . resolved

Nit: type clarify

```suggestion
                        0.0f);
```

Michael Wilson

Done.

Line 709, Patchset 1: destination[i] = (source_l[i] + source_r[i]) / 2;

Hongchan Choi . resolved

Nit: While we're at it... (another type clarify)
```suggestion
        destination[i] = (source_l[i] + source_r[i]) * 0.5f;
```

Michael Wilson

Done.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 9, 2026, 10:42:43 PMMar 9

to Hongchan Choi, kelsen liu, Mahesh Kannan, AyeAye, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/renderer/platform/audio/audio_bus.cc
Insertions: 2, Deletions: 2.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Replace UNSAFE_TODO in AudioBus with safe operations

This should cause no functional change.

Bug: 401184803

Change-Id: I0daedfc20ebe80ec31a5f2c4d60f8af67cc1022b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7645510

Commit-Queue: Michael Wilson <mjwi...@chromium.org>

Reviewed-by: Hongchan Choi <hong...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1596794}

Files:

M third_party/blink/renderer/platform/audio/audio_bus.cc

Change size: S

Delta: 1 file changed, 17 insertions(+), 17 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Hongchan Choi

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Replace UNSAFE_TODO in AudioBus with safe operations [chromium/src : main]

Michael Wilson (Gerrit)

Michael Wilson added 1 comment

Related details

Hongchan Choi (Gerrit)

Hongchan Choi voted and added 4 comments

Votes added by Hongchan Choi

4 comments

Related details

Michael Wilson (Gerrit)

Michael Wilson voted and added 3 comments

Votes added by Michael Wilson

3 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information