Remove dead code from platform/wtf/functional_test.cc [chromium/src : main]

0 views
Skip to first unread message

Henrique Ferreiro (Gerrit)

unread,
Jul 2, 2024, 6:58:14 AM (23 hours ago) Jul 2
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Henrique Ferreiro added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Henrique Ferreiro . resolved

PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9a3edbb1f0859aac33f6b3d884c9ede7f903057
Gerrit-Change-Number: 5658438
Gerrit-PatchSet: 4
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 10:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jul 2, 2024, 7:27:54 PM (11 hours ago) Jul 2
to Henrique Ferreiro, Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Henrique Ferreiro

Kent Tamura voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Henrique Ferreiro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9a3edbb1f0859aac33f6b3d884c9ede7f903057
Gerrit-Change-Number: 5658438
Gerrit-PatchSet: 4
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Attention: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Comment-Date: Tue, 02 Jul 2024 23:27:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Henrique Ferreiro (Gerrit)

unread,
3:10 AM (3 hours ago) 3:10 AM
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Henrique Ferreiro voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9a3edbb1f0859aac33f6b3d884c9ede7f903057
Gerrit-Change-Number: 5658438
Gerrit-PatchSet: 4
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 07:10:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
3:15 AM (3 hours ago) 3:15 AM
to Henrique Ferreiro, Kent Tamura, chromium...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove dead code from platform/wtf/functional_test.cc

Also, update includes and replace usage of base/functional with wtf/.
Change-Id: Ib9a3edbb1f0859aac33f6b3d884c9ede7f903057
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Henrique Ferreiro <hfer...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1322618}
Files:
  • M third_party/blink/renderer/platform/wtf/functional_test.cc
Change size: M
Delta: 1 file changed, 7 insertions(+), 86 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kent Tamura
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib9a3edbb1f0859aac33f6b3d884c9ede7f903057
Gerrit-Change-Number: 5658438
Gerrit-PatchSet: 5
Gerrit-Owner: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Henrique Ferreiro <hfer...@igalia.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages