Enable KeyboardFocusableScrollers to stable [chromium/src : main]
0 views
Skip to first unread message
Di Zhang (Gerrit)
Aug 9, 2024, 1:21:02 PM8/9/24
to Mason Freed, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed
Di Zhang voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Aug 9, 2024, 1:26:15 PM8/9/24
to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Di Zhang
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Mason Freed . resolved
LGTM! 🎉
(this'll likely fail the virtual/stable tests and need another reviewer.)
Related details
Attention is currently required from:
- Di Zhang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Aug 9, 2024, 3:15:02 PM8/9/24
to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Di Zhang
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
Mason Freed . resolved
LGTM! 🎉
(this'll likely fail the virtual/stable tests and need another reviewer.)
Mason Freed
Forgot this doesn't change any observable APIs.
Related details
Attention is currently required from:
- Di Zhang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Aug 9, 2024, 3:16:22 PM8/9/24
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Di Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Di Zhang
| Commit-Queue | +2 |
Mason Freed . resolved
Mason FreedLGTM! 🎉
(this'll likely fail the virtual/stable tests and need another reviewer.)
Forgot this doesn't change any observable APIs.
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 9, 2024, 3:19:27 PM8/9/24
to Di Zhang, Mason Freed, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Enable KeyboardFocusableScrollers to stable
KeyboardFocusableScrollers is shipping in M127 through Finch. Here we
update the runtime_enabled_features.json5 to mark the feature as stable.
Note that this feature should not be removed until the end of its
KeyboardFocusableScrollersOptOut deprecation trial.
Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/jzMA5vUqNDs/m/VbhNdHgQAgAJ
Intent to Experiment for Deprecation Trial:
https://groups.google.com/a/chromium.org/g/blink-dev/c/2qwzMaEGWTk/m/7-DeUOg-AgAJ
Change-Id: Iee465a4c3afdf9e0a2b38eaca6af15412240ab10
Fixed: 40113891
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775613
Commit-Queue: Di Zhang <dizh...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1339799}
Files:
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages