Speculative fix for crash in SpeechRecognition::StartController [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
Feb 6, 2026, 5:26:59 PM (2 days ago) Feb 6
to Evan Liu, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Evan Liu
Joe Mason voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Evan Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 6, 2026, 5:29:06 PM (2 days ago) Feb 6
to Chromium LUCI CQ, Evan Liu, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Evan Liu
Joe Mason added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/speech/speech_recognition.cc
Line 546, Patchset 2 (Latest):
blink::BindOnce(Joe Mason . resolved
Review note: adding the `task_runner` param caused "error: call to 'BindOnce' is ambiguous" (possibilities being `base::BindOnce` and `blink::BindOnce`). No idea how the compiler could get confused there but the explicit namespace fixed it.
Related details
Attention is currently required from:
- Evan Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Liu (Gerrit)
Feb 7, 2026, 1:54:48 AM (yesterday) Feb 7
to Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Joe Mason
Evan Liu voted and added 2 comments![]( "Open in Gerrit")
Votes added by Evan Liu
| Code-Review | +1 |
2 comments
Patchset-level comments
File third_party/blink/renderer/modules/speech/speech_recognition.cc
Line 568, Patchset 2 (Parent):
GetExecutionContext()->GetTaskRunner(TaskType::kMiscPlatformAPI));Evan Liu . unresolved
Is it problematic that this is returning null here? Should we even attempt to start the controller if the context is dead?
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages