Implement keep custom element registry null in shadow root [chromium/src : main]

[Jayson Chen (Gerrit)]

Attention needed from Joey Arhar and Mason Freed

Jayson Chen added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jayson Chen . resolved

Hey all, here's a small PR that implements a part I was missing from shadowrootcustomelementregistry attribute implementation. PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Mason Freed

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1365e8a84e47fda7cfb0940597a088978a606336

Gerrit-Change-Number: 7476200

Gerrit-PatchSet: 1

Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mason Freed <mas...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Wed, 14 Jan 2026 19:39:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mason Freed (Gerrit)]

Attention needed from Jayson Chen and Joey Arhar

Mason Freed added 2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Mason Freed . resolved

Code looks good, just a naming question.

Also red bots, but I think those are from the upstream CL.

File third_party/blink/renderer/core/dom/shadow_root.h

Line 186, Patchset 1 (Latest): void SetKeepCustomElementRegistryNull(bool flag) {

Mason Freed . unresolved

Unless this corresponds to a spec concept, I don't really like the name. This seems more like "WaitingForCustomizedRegistry" or something? The "Keep" doesn't tell me what it means. Keep it null forever? Until what? Why?

Open in Gerrit

Related details

Attention is currently required from:

• Jayson Chen
• Joey Arhar

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1365e8a84e47fda7cfb0940597a088978a606336

Gerrit-Change-Number: 7476200

Gerrit-PatchSet: 1

Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jayson Chen <jayso...@microsoft.com>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Wed, 14 Jan 2026 21:59:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Jayson Chen (Gerrit)]

Attention needed from Joey Arhar and Mason Freed

Jayson Chen added 1 comment

File third_party/blink/renderer/core/dom/shadow_root.h

Line 186, Patchset 1: void SetKeepCustomElementRegistryNull(bool flag) {

Mason Freed . resolved

Unless this corresponds to a spec concept, I don't really like the name. This seems more like "WaitingForCustomizedRegistry" or something? The "Keep" doesn't tell me what it means. Keep it null forever? Until what? Why?

Jayson Chen

It is indeed associated with a [spec concept](https://dom.spec.whatwg.org/#shadowroot-keep-custom-element-registry-null). I can add a comment to clarify the usage of it. The idea is that the registry of the shadow root should not be restored during adoption and should be kept null, unless it's explicitly initialized by the user.

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Mason Freed

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1365e8a84e47fda7cfb0940597a088978a606336

Gerrit-Change-Number: 7476200

Gerrit-PatchSet: 4

Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mason Freed <mas...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Thu, 15 Jan 2026 22:56:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mason Freed <mas...@chromium.org>

[Joey Arhar (Gerrit)]

Attention needed from Jayson Chen and Mason Freed

Joey Arhar added 1 comment

File third_party/blink/renderer/core/dom/shadow_root.h

Line 186, Patchset 1: void SetKeepCustomElementRegistryNull(bool flag) {

Mason Freed . unresolved

Unless this corresponds to a spec concept, I don't really like the name. This seems more like "WaitingForCustomizedRegistry" or something? The "Keep" doesn't tell me what it means. Keep it null forever? Until what? Why?

Jayson Chen

It is indeed associated with a [spec concept](https://dom.spec.whatwg.org/#shadowroot-keep-custom-element-registry-null). I can add a comment to clarify the usage of it. The idea is that the registry of the shadow root should not be restored during adoption and should be kept null, unless it's explicitly initialized by the user.

Joey Arhar

want to add a link to the spec in that new comment?

Open in Gerrit

Related details

Attention is currently required from:

• Jayson Chen
• Mason Freed

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1365e8a84e47fda7cfb0940597a088978a606336

Gerrit-Change-Number: 7476200

Gerrit-PatchSet: 4

Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jayson Chen <jayso...@microsoft.com>

Gerrit-Attention: Mason Freed <mas...@chromium.org>

Gerrit-Comment-Date: Fri, 16 Jan 2026 17:56:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jayson Chen <jayso...@microsoft.com>

Comment-In-Reply-To: Mason Freed <mas...@chromium.org>

[Jayson Chen (Gerrit)]

Attention needed from Joey Arhar and Mason Freed

Jayson Chen added 1 comment

File third_party/blink/renderer/core/dom/shadow_root.h

Line 186, Patchset 1: void SetKeepCustomElementRegistryNull(bool flag) {

Mason Freed . resolved

Unless this corresponds to a spec concept, I don't really like the name. This seems more like "WaitingForCustomizedRegistry" or something? The "Keep" doesn't tell me what it means. Keep it null forever? Until what? Why?

Jayson Chen

It is indeed associated with a [spec concept](https://dom.spec.whatwg.org/#shadowroot-keep-custom-element-registry-null). I can add a comment to clarify the usage of it. The idea is that the registry of the shadow root should not be restored during adoption and should be kept null, unless it's explicitly initialized by the user.

Joey Arhar

want to add a link to the spec in that new comment?

Jayson Chen

Done

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Mason Freed

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1365e8a84e47fda7cfb0940597a088978a606336

Gerrit-Change-Number: 7476200

Gerrit-PatchSet: 5

Gerrit-Owner: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Jayson Chen <jayso...@microsoft.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Mason Freed <mas...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mason Freed <mas...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Sat, 17 Jan 2026 10:41:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Jayson Chen <jayso...@microsoft.com>

Comment-In-Reply-To: Mason Freed <mas...@chromium.org>

Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>