WebMCP: Expose document.modelContext [chromium/src : main]

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 2

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Thu, 21 May 2026 21:53:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Mark Foltz (Gerrit)]

Attention needed from Dominic Farolino

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

Code-Review

+1

1 comment

File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js

Line 1, Patchset 2 (Latest):async function waitForTool(name) {

Mark Foltz . unresolved

This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Farolino

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 2

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dominic Farolino <d...@chromium.org>

Gerrit-Comment-Date: Fri, 22 May 2026 21:51:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mark Foltz (Gerrit)]

Attention needed from Dominic Farolino

Mark Foltz added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Mark Foltz . resolved

Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋

Gerrit-Comment-Date: Fri, 22 May 2026 21:52:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted and added 2 comments

Votes added by Dominic Farolino

Commit-Queue

+1

2 comments

Patchset-level comments

File-level comment, Patchset 2:

Mark Foltz . resolved

Looks like a rebaseline is needed for a bunch of WPTs because of the deprecation warning 😋

Dominic Farolino

Think I got them all. We'll see if the bots are happy.

File third_party/blink/web_tests/wpt_internal/webmcp/resources/webmcp-helpers.js

Line 1, Patchset 2:async function waitForTool(name) {

Mark Foltz . resolved

This duplicates waitForTool in third_party/blink/web_tests/fast/webmcp/resources/webmcp-helpers.js ...

Dominic Farolino

Yeah so there is some unfortunate duplication, there are three `webmcp-helpers.js` files:
 - fast/
 - wpt_internal
 - external/wpt

The duplication between the first two is what you're commenting on, but I don't think those two types of tests can share files, so it is what it is. The last two technically don't have to be duplicated, so I've removed `wpt_internal/webmcp/resources/webmcp-helpers.js` and updated the internal WPTs to reference the external file. Seems like a good change.

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 4

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Sun, 24 May 2026 15:49:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Mark Foltz <mfo...@chromium.org>

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 5

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Sun, 24 May 2026 16:26:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+0

Commit-Queue

+0

Gerrit-Comment-Date: Sun, 24 May 2026 16:26:37 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted and added 1 comment

Votes added by Dominic Farolino

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Dominic Farolino . resolved

Jetski botched the rebase but I fixed it...

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 6

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Sun, 24 May 2026 16:39:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 7

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Sun, 24 May 2026 17:15:43 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Dominic Farolino (Gerrit)]

Attention needed from Mark Foltz

Dominic Farolino voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Mark Foltz

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 8

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mark Foltz <mfo...@chromium.org>

Gerrit-Comment-Date: Mon, 25 May 2026 15:59:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Mark Foltz (Gerrit)]

Attention needed from Dominic Farolino

Mark Foltz voted and added 1 comment

Votes added by Mark Foltz

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Mark Foltz . resolved

Thanks for cleaning up the duplicate helper script 👍

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Farolino

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 8

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dominic Farolino <d...@chromium.org>

Gerrit-Comment-Date: Tue, 26 May 2026 00:08:12 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Attention needed from Dominic Farolino

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/60158.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

• Dominic Farolino

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2005719574b78367199c0a87f94f3577b8039f15

Gerrit-Change-Number: 7867800

Gerrit-PatchSet: 8

Gerrit-Owner: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>

Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Khushal Sagar <khusha...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Dominic Farolino <d...@chromium.org>

Gerrit-Comment-Date: Tue, 26 May 2026 00:16:03 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No