Add Web Smart Card Protocol configuration. [chromium/src : main]
Paulina Gacek (Gerrit)
Paulina Gacek added 1 comment![]( "Open in Gerrit")
import("//content/public/common/features.gni")Paulina GacekOther cases like `enable_bluetooth_emulation` seems to use `.gni` files from directories more specific to the feature instead of `//content/public/common/features.gni`. Is that possible to do for this as well? (Just not sure if the flag belongs in that file, but if there's no other better choice maybe it's fine)
Paulina GacekHi Akita, thanks for the feedback! We've placed the `enable_smart_card` flag here because this feature will have code in both the `content/` layer and in `third_party/blink/`.
Paulina Gacek*Rakina, apologies 🙏
Alex MoshchukAcknowledged
Zgroza (Luke) KlimekPlacing it in content/public would expose it more widely outside of content/, though (e.g., it would be accessible from //chrome). I'm not sure that's needed, though maybe as Rakina said, there's no better choice? Typically for cases where content and blink need to share some code, the feature definition would go into blink/public, and content would include that dependency (content can use stuff from blink/public). So just curious if it'd be better to define this in blink? (e.g., maybe [here](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/BUILD.gn;l=26;drc=a35f3c68a82831260fbf2d9ce29c00c9007ad3ac)? - though I'd defer to Blink owners for guidance)
Rakina Zata AmniSo, the plan is to use it from:
- `//third_party/blink`
- `//content`
- `//chrome`
so something as widely accessible as possible would be good indeed.
Paulina GacekYou can't include `//content` from `//third_party/blink`, so if you want to use the flag from there, it's probably better to have it in `//third_party/blink/public` like Alex suggested.
Done, thank you!
Related details
- Alex Moshchuk
- Rakina Zata Amni
- Zgroza (Luke) Klimek
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zgroza (Luke) Klimek (Gerrit)
Zgroza (Luke) Klimek voted Code-Review+1![]( "Open in Gerrit")
- Alex Moshchuk
- Paulina Gacek
- Rakina Zata Amni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Moshchuk (Gerrit)
Alex Moshchuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Moshchuk
| Code-Review | +1 |
1 comment
Thanks, content/ LGTM, with the understanding that the new flag will eventually be needed in blink/ as well, per https://chromium-review.googlesource.com/c/chromium/src/+/7238354/comment/8cd73c76_e0b58514/.
Related details
- Paulina Gacek
- Rakina Zata Amni
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |