[mq-4] Move queried-axes computation to MediaQuery[Set] [chromium/src : main]

Anders Hartvoll Ruud (Gerrit)

unread,

Oct 26, 2021, 4:20:40 PM10/26/21

to Kevin Babbitt, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Attention is currently required from: Kevin Babbitt.

Anders Hartvoll Ruud would like Kevin Babbitt to review this change.

[mq-4] Move queried-axes computation to MediaQuery[Set]

This eliminates one public caller of MediaQuery::Expressions,
which makes it easier to change the internal representation of the
query to MediaQueryExpNode.

Bug: 962417
Change-Id: Id65021bc06bd329ac6b73a6d462bf932e89cc5d5
---
M third_party/blink/renderer/core/css/media_query.h
M third_party/blink/renderer/core/css/media_list.h
M third_party/blink/renderer/core/css/media_query_set_test.cc
M third_party/blink/renderer/core/css/media_query.cc
M third_party/blink/renderer/core/css/container_query.cc
M third_party/blink/renderer/core/css/media_list.cc
6 files changed, 67 insertions(+), 20 deletions(-)

To view, visit change 3245397. To unsubscribe, or for help writing mail filters, visit settings.

Anders Hartvoll Ruud (Gerrit)

unread,

Oct 26, 2021, 4:20:48 PM10/26/21

to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

Attention is currently required from: Kevin Babbitt.

View Change

To view, visit change 3245397. To unsubscribe, or for help writing mail filters, visit settings.

Kevin Babbitt (Gerrit)

unread,

Oct 28, 2021, 1:11:52 AM10/28/21

to Anders Hartvoll Ruud, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

Attention is currently required from: Anders Hartvoll Ruud.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  lgtm

To view, visit change 3245397. To unsubscribe, or for help writing mail filters, visit settings.

Anders Hartvoll Ruud (Gerrit)

unread,

Oct 28, 2021, 4:56:36 AM10/28/21

to apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

Attention is currently required from: Anders Hartvoll Ruud.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 3245397. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 28, 2021, 6:04:57 AM10/28/21

to Anders Hartvoll Ruud, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, Kevin Babbitt, Alexis Menard, chromium...@chromium.org, Kenneth Rohde Christiansen, Yoav Weiss

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Kevin Babbitt: Looks good to me
  Anders Hartvoll Ruud: Commit

[mq-4] Move queried-axes computation to MediaQuery[Set]

This eliminates one public caller of MediaQuery::Expressions,
which makes it easier to change the internal representation of the
query to MediaQueryExpNode.

Bug: 962417
Change-Id: Id65021bc06bd329ac6b73a6d462bf932e89cc5d5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3245397
Reviewed-by: Kevin Babbitt <kbab...@microsoft.com>
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935811}


---
M third_party/blink/renderer/core/css/media_query.h
M third_party/blink/renderer/core/css/media_list.h
M third_party/blink/renderer/core/css/media_query_set_test.cc
M third_party/blink/renderer/core/css/media_query.cc
M third_party/blink/renderer/core/css/container_query.cc
M third_party/blink/renderer/core/css/media_list.cc

6 files changed, 71 insertions(+), 20 deletions(-)

To view, visit change 3245397. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward