webnn: Fix incorrect peephole weight slicing in LSTM for ifgo layout [chromium/src : main]

0 views
Skip to first unread message

Fu, Junwei (Gerrit)

unread,
1:11 AM (9 hours ago) 1:11 AM
to Hu, Ningxin, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Hu, Ningxin and Reilly Grant

Fu, Junwei added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Fu, Junwei . resolved

PTAL, thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Hu, Ningxin
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b1c230dff0501752119bddd5d6d960f1aa9ea73
Gerrit-Change-Number: 7748290
Gerrit-PatchSet: 1
Gerrit-Owner: Fu, Junwei <junw...@intel.com>
Gerrit-Reviewer: Fu, Junwei <junw...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-Attention: Hu, Ningxin <ningx...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 05:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hu, Ningxin (Gerrit)

unread,
2:30 AM (7 hours ago) 2:30 AM
to Fu, Junwei, Reilly Grant, Chromium LUCI CQ, chromium...@chromium.org, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Fu, Junwei and Reilly Grant

Hu, Ningxin voted and added 3 comments

Votes added by Hu, Ningxin

Code-Review+1

3 comments

Patchset-level comments
Hu, Ningxin . resolved

LGTM with comments for test data

File third_party/blink/web_tests/external/wpt/webnn/conformance_tests/lstm_cell.https.any.js
Line 455, Patchset 1 (Latest): 'data': [0, 0, 0, 0, 0, 0],
Hu, Ningxin . unresolved

Using all-zero peephole weights may not distinguish between the correct and incorrect slicing behavior.

Line 904, Patchset 1 (Latest): 'data': [0, 0, 0, 0, 0, 0],
Hu, Ningxin . unresolved

Same here.

Open in Gerrit

Related details

Attention is currently required from:
  • Fu, Junwei
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9b1c230dff0501752119bddd5d6d960f1aa9ea73
Gerrit-Change-Number: 7748290
Gerrit-PatchSet: 1
Gerrit-Owner: Fu, Junwei <junw...@intel.com>
Gerrit-Reviewer: Fu, Junwei <junw...@intel.com>
Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-Attention: Fu, Junwei <junw...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Mon, 13 Apr 2026 06:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fu, Junwei (Gerrit)

unread,
8:03 AM (2 hours ago) 8:03 AM
to Hu, Ningxin, Reilly Grant, chromiu...@luci-project-accounts.iam.gserviceaccount.com, chromium...@chromium.org, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Fu, Junwei and Reilly Grant

Fu, Junwei voted and added 3 comments

Votes added by Fu, Junwei

Commit-Queue+1

3 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Fu, Junwei . resolved

Done, thanks for review.

File third_party/blink/web_tests/external/wpt/webnn/conformance_tests/lstm_cell.https.any.js
Line 455, Patchset 1: 'data': [0, 0, 0, 0, 0, 0],
Hu, Ningxin . resolved

Using all-zero peephole weights may not distinguish between the correct and incorrect slicing behavior.

Fu, Junwei

Done

Line 904, Patchset 1: 'data': [0, 0, 0, 0, 0, 0],
Hu, Ningxin . resolved

Same here.

Fu, Junwei

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Fu, Junwei
  • Reilly Grant
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9b1c230dff0501752119bddd5d6d960f1aa9ea73
    Gerrit-Change-Number: 7748290
    Gerrit-PatchSet: 3
    Gerrit-Owner: Fu, Junwei <junw...@intel.com>
    Gerrit-Reviewer: Fu, Junwei <junw...@intel.com>
    Gerrit-Reviewer: Hu, Ningxin <ningx...@intel.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-Attention: Fu, Junwei <junw...@intel.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Apr 2026 12:02:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Hu, Ningxin <ningx...@intel.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages