Align enumerations for AI metrics in xml and code [chromium/src : main]

0 views
Skip to first unread message

Jiacheng Guo (Gerrit)

unread,
Jul 2, 2024, 4:21:54 AM (yesterday) Jul 2
to Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org

Jiacheng Guo has uploaded the change for review

Commit message

Align enumerations for AI metrics in xml and code

The CL aligns the enumeration definition in enums.xml and ai_metrics.h.
LINT checks are also added to prevent future disalignment.
Bug: None
Change-Id: I7198089d935af32f2691684aa27afdce38344a18

Change diff


Change information

Files:
  • M third_party/blink/renderer/modules/ai/ai.h
  • M third_party/blink/renderer/modules/ai/ai_metrics.h
  • M tools/metrics/histograms/metadata/ai/enums.xml
Change size: S
Delta: 3 files changed, 15 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7198089d935af32f2691684aa27afdce38344a18
Gerrit-Change-Number: 5671195
Gerrit-PatchSet: 1
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mingyu Lei (Gerrit)

unread,
Jul 2, 2024, 4:54:25 AM (yesterday) Jul 2
to Jiacheng Guo, Takashi Toyoshima, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Jiacheng Guo and Takashi Toyoshima

Mingyu Lei voted and added 1 comment

Votes added by Mingyu Lei

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Mingyu Lei . resolved

Thanks for fixing this and adding the lint!

Open in Gerrit

Related details

Attention is currently required from:
  • Jiacheng Guo
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7198089d935af32f2691684aa27afdce38344a18
Gerrit-Change-Number: 5671195
Gerrit-PatchSet: 6
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Mingyu Lei <le...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Jiacheng Guo <g...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 08:54:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
Jul 2, 2024, 9:19:48 PM (9 hours ago) Jul 2
to Jiacheng Guo, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Jiacheng Guo

Takashi Toyoshima voted and added 2 comments

Votes added by Takashi Toyoshima

Code-Review+1

2 comments

File third_party/blink/renderer/modules/ai/ai.h
Line 28, Patchset 6 (Latest): public:
Takashi Toyoshima . unresolved

hum... we missed the histogram enum comment,
```
// These values are persisted to logs. Entries should not be renumbered and
// numeric values should never be reused.
```

Can you add it?

https://chromium.googlesource.com/chromium/src/tools/+/refs/heads/main/metrics/histograms/README.md#Enum-Histograms

File third_party/blink/renderer/modules/ai/ai_metrics.h
Line 19, Patchset 6 (Latest): //
Takashi Toyoshima . unresolved

ditto

Open in Gerrit

Related details

Attention is currently required from:
  • Jiacheng Guo
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7198089d935af32f2691684aa27afdce38344a18
    Gerrit-Change-Number: 5671195
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Mingyu Lei <le...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Comment-Date: Wed, 03 Jul 2024 01:19:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jiacheng Guo (Gerrit)

    unread,
    Jul 2, 2024, 10:27:59 PM (8 hours ago) Jul 2
    to Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org

    Jiacheng Guo has uploaded the change for review

    Commit message

    Align enumerations for AI metrics in xml and code

    The CL aligns the enumeration definition in enums.xml and ai_metrics.h.
    LINT checks are also added to prevent future disalignment.

    NO_IFTTT=Adding missing LINTS, no code change required
    Bug: None
    Change-Id: I7198089d935af32f2691684aa27afdce38344a18
    Change-Id: I1346a4ae8447a9d9f0f31e9ef5b709cc5f41bc9d
    Change diff

    Change information
    Files:
    • M third_party/blink/renderer/modules/ai/ai.h
    • M third_party/blink/renderer/modules/ai/ai_metrics.h
    • M tools/metrics/histograms/metadata/ai/enums.xml
    Change size: S
    Delta: 3 files changed, 21 insertions(+), 0 deletions(-)
     Open in Gerrit
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: newchange 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I1346a4ae8447a9d9f0f31e9ef5b709cc5f41bc9d 
    

     Gerrit-Change-Number: 5674060 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Jiacheng Guo <g...@google.com> 
    

    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Jiacheng Guo (Gerrit)
    unread,
    Jul 2, 2024, 10:28:17 PM (8 hours ago) Jul 2
    to Takashi Toyoshima, Mingyu Lei, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
    Jiacheng Guo voted and added 2 comments
    Votes added by Jiacheng Guo
    Commit-Queue+2
    2 comments
    File third_party/blink/renderer/modules/ai/ai.h
    Takashi Toyoshima . resolved
    hum... we missed the histogram enum comment,
    ```
    // These values are persisted to logs. Entries should not be renumbered and
    // numeric values should never be reused.
    ```
    Can you add it?
    https://chromium.googlesource.com/chromium/src/tools/+/refs/heads/main/metrics/histograms/README.md#Enum-Histograms
    Jiacheng Guo
    Done
    File third_party/blink/renderer/modules/ai/ai_metrics.h
    Takashi Toyoshima . resolved
    ditto
    Jiacheng Guo
    Done
    Open in Gerrit
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: comment 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I7198089d935af32f2691684aa27afdce38344a18 
    

     Gerrit-Change-Number: 5671195 
    

     Gerrit-PatchSet: 6 
    

     Gerrit-Owner: Jiacheng Guo <g...@google.com> 
    

     Gerrit-Reviewer: Jiacheng Guo <g...@google.com> 
    

     Gerrit-Reviewer: Mingyu Lei <le...@chromium.org> 
    

     Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org> 
    


     Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com> 
    


     Gerrit-Comment-Date: Wed, 03 Jul 2024 02:28:03 +0000 
    

     Gerrit-HasComments: Yes 
    

     Gerrit-Has-Labels: Yes 
    

     Comment-In-Reply-To: Takashi Toyoshima <toyo...@chromium.org> 
    


    satisfied_requirement
    open
    diffy
    Chromium LUCI CQ (Gerrit)
    unread,
    Jul 2, 2024, 10:31:31 PM (8 hours ago) Jul 2
    to Jiacheng Guo, Takashi Toyoshima, Mingyu Lei, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
    Chromium LUCI CQ submitted the change
    Change information
    Commit message:
    Align enumerations for AI metrics in xml and code

    The CL aligns the enumeration definition in enums.xml and ai_metrics.h.
    LINT checks are also added to prevent future disalignment.

    NO_IFTTT=Adding missing LINTS, no code change required
    Bug: None
    Change-Id: I7198089d935af32f2691684aa27afdce38344a18
    Commit-Queue: Jiacheng Guo <g...@google.com>
    Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
    Reviewed-by: Mingyu Lei <le...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1322538}
    Files:
    • M third_party/blink/renderer/modules/ai/ai.h
    • M third_party/blink/renderer/modules/ai/ai_metrics.h
    • M tools/metrics/histograms/metadata/ai/enums.xml
    Change size: S
    Delta: 3 files changed, 15 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mingyu Lei, +1 by Takashi Toyoshima
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I7198089d935af32f2691684aa27afdce38344a18 
    

     Gerrit-Change-Number: 5671195 
    

     Gerrit-PatchSet: 7 
    

     Gerrit-Owner: Jiacheng Guo <g...@google.com> 
    

     Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
    

     Gerrit-Reviewer: Jiacheng Guo <g...@google.com> 
    

     Gerrit-Reviewer: Mingyu Lei <le...@chromium.org> 
    

     Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org> 
    

    open
    diffy
    satisfied_requirement
    Jiacheng Guo (Gerrit)
    unread,
    2:41 AM (4 hours ago) 2:41 AM
    to Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
    Jiacheng Guo abandoned this change
    Related details
    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: abandon 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I1346a4ae8447a9d9f0f31e9ef5b709cc5f41bc9d 
    

     Gerrit-Change-Number: 5674060 
    

     Gerrit-PatchSet: 1 
    

     Gerrit-Owner: Jiacheng Guo <g...@google.com> 
    

    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages