Make registerAltDictionaryAndWait more robust and review usages. [chromium/src : main]
0 views
Skip to first unread message
Frédéric Wang Nélar (Gerrit)
Jul 24, 2026, 1:24:37 AM (3 days ago) Jul 24
to Patrick Meenan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Patrick Meenan
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Patrick Meenan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Meenan (Gerrit)
Jul 24, 2026, 11:20:20 AM (3 days ago) Jul 24
to Frédéric Wang Nélar, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Frédéric Wang Nélar
Patrick Meenan voted and added 3 comments![]( "Open in Gerrit")
Votes added by Patrick Meenan
| Code-Review | +1 |
3 comments
Patchset-level comments
File third_party/blink/web_tests/external/wpt/fetch/compression-dictionary/resources/compression-dictionary-util.sub.js
Line 159, Patchset 1 (Latest):
const pattern = encodeURIComponent("/fetch/compression-dictionary/resources/echo-headers2.py");Patrick Meenan . unresolved
nit: some hardening to make sure new tests don't accidentally not pass in a dictionary ID.
```suggestion
assert_true(typeof dictionary_id === 'string' && dictionary_id.length > 0,
'registerAltDictionaryAndWait requires a valid dictionary_id');
const pattern = encodeURIComponent("/fetch/compression-dictionary/resources/echo-headers2.py");
```
Line 162, Patchset 1 (Latest):
await waitUntilHeader(
t, 'dictionary-id',
{expected_header: `"${dictionary_id}"`, use_alt_path: true});Patrick Meenan . unresolved
`waitUntilHeader` returns an error string (`'"dictionary-id" header is not available'`) on timeout after 10 retries. `registerAltDictionaryAndWait` awaits `waitUntilHeader` without inspecting or asserting the returned string, causing timeout failures to silently resolve as success.
```suggestion
const res = await waitUntilHeader(
t, 'dictionary-id',
{expected_header: `"${dictionary_id}"`, use_alt_path: true});
assert_equals(res, `"${dictionary_id}"`);
```
Related details
Attention is currently required from:
- Frédéric Wang Nélar
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frédéric Wang Nélar (Gerrit)
Jul 26, 2026, 5:48:25 AM (23 hours ago) Jul 26
to Patrick Meenan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Frédéric Wang Nélar voted and added 2 comments![]( "Open in Gerrit")
Votes added by Frédéric Wang Nélar
| Commit-Queue | +2 |
2 comments
File third_party/blink/web_tests/external/wpt/fetch/compression-dictionary/resources/compression-dictionary-util.sub.js
Line 159, Patchset 1:
const pattern = encodeURIComponent("/fetch/compression-dictionary/resources/echo-headers2.py");Patrick Meenan . resolved
nit: some hardening to make sure new tests don't accidentally not pass in a dictionary ID.
```suggestion
assert_true(typeof dictionary_id === 'string' && dictionary_id.length > 0,
'registerAltDictionaryAndWait requires a valid dictionary_id');
const pattern = encodeURIComponent("/fetch/compression-dictionary/resources/echo-headers2.py");
```
Frédéric Wang Nélar
Done
Line 162, Patchset 1:
await waitUntilHeader(
t, 'dictionary-id',
{expected_header: `"${dictionary_id}"`, use_alt_path: true});Patrick Meenan . resolved
`waitUntilHeader` returns an error string (`'"dictionary-id" header is not available'`) on timeout after 10 retries. `registerAltDictionaryAndWait` awaits `waitUntilHeader` without inspecting or asserting the returned string, causing timeout failures to silently resolve as success.
```suggestion
const res = await waitUntilHeader(
t, 'dictionary-id',
{expected_header: `"${dictionary_id}"`, use_alt_path: true});
assert_equals(res, `"${dictionary_id}"`);
```
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Jul 26, 2026, 5:49:44 AM (22 hours ago) Jul 26
to Frédéric Wang Nélar, Patrick Meenan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/61534.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frédéric Wang Nélar (Gerrit)
Jul 26, 2026, 12:01:27 PM (16 hours ago) Jul 26
to Blink W3C Test Autoroller, Patrick Meenan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Frédéric Wang Nélar voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frédéric Wang Nélar (Gerrit)
2:37 AM (2 hours ago) 2:37 AM
to Blink W3C Test Autoroller, Patrick Meenan, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Frédéric Wang Nélar voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages