Reland "blink: Update scrollbar existence after pinch-zoom" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Dec 22, 2025, 3:40:20 AM (yesterday) Dec 22
to Ryo Hashimoto, Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, Steve Kobes, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Nidhi Jaju and Robert Flack

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nidhi Jaju
  • Robert Flack
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
Gerrit-Change-Number: 7297835
Gerrit-PatchSet: 1
Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Steve Kobes <sko...@chromium.org>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 08:40:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 22, 2025, 3:42:15 AM (yesterday) Dec 22
to Ryo Hashimoto, Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, Steve Kobes, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Nidhi Jaju and Robert Flack

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nidhi Jaju
  • Robert Flack
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
Gerrit-Change-Number: 7297835
Gerrit-PatchSet: 2
Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
Gerrit-CC: David Bokan <bo...@chromium.org>
Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
Gerrit-CC: Steve Kobes <sko...@chromium.org>
Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
Gerrit-Attention: Robert Flack <fla...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Dec 2025 08:42:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Dec 22, 2025, 3:45:17 AM (yesterday) Dec 22
to Ryo Hashimoto, Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, Steve Kobes, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Nidhi Jaju and Robert Flack

Message from Rubber Stamper

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:
  • Nidhi Jaju
  • Robert Flack
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Gerrit-Change-Number: 7297835
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Steve Kobes <sko...@chromium.org>
    Gerrit-Attention: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 08:45:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ryo Hashimoto (Gerrit)

    unread,
    Dec 22, 2025, 9:49:18 AM (22 hours ago) Dec 22
    to Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, Steve Kobes, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Robert Flack

    Ryo Hashimoto added 2 comments

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Ryo Hashimoto . resolved

    PTAL

    Patch set #1 is the original CL that was reverted. Confirmed that patch set #3 fixes the failing tests.

    File third_party/blink/renderer/core/scroll/scrollable_area.cc
    Line 927, Patchset 3 (Latest): ScrollbarVisibilityChanged();
    Ryo Hashimoto . resolved

    It turned out that calling `ScrollbarVisibilityChanged()` was necessary to update scroll values for chrome automation API used by tests.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Flack
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Gerrit-Change-Number: 7297835
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-CC: Steve Kobes <sko...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 14:48:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Steve Kobes (Gerrit)

    unread,
    Dec 22, 2025, 10:59:21 AM (21 hours ago) Dec 22
    to Ryo Hashimoto, Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Robert Flack and Ryo Hashimoto

    Steve Kobes voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Flack
    • Ryo Hashimoto
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Gerrit-Change-Number: 7297835
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
    Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-Attention: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Mon, 22 Dec 2025 15:59:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ryo Hashimoto (Gerrit)

    unread,
    Dec 22, 2025, 8:46:36 PM (11 hours ago) Dec 22
    to Steve Kobes, Chromium LUCI CQ, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Robert Flack

    Ryo Hashimoto voted and added 1 comment

    Votes added by Ryo Hashimoto

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Ryo Hashimoto . resolved

    Thank you for reviewing!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Robert Flack
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Gerrit-Change-Number: 7297835
    Gerrit-PatchSet: 3
    Gerrit-Owner: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nidhi Jaju <nidh...@chromium.org>
    Gerrit-Reviewer: Robert Flack <fla...@chromium.org>
    Gerrit-Reviewer: Ryo Hashimoto <hash...@chromium.org>
    Gerrit-Reviewer: Steve Kobes <sko...@chromium.org>
    Gerrit-CC: Bao-Duy Tran <tranb...@chromium.org>
    Gerrit-CC: David Bokan <bo...@chromium.org>
    Gerrit-CC: Kenneth Rohde Christiansen <kenneth.ch...@gmail.com>
    Gerrit-Attention: Robert Flack <fla...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 01:46:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 22, 2025, 8:49:55 PM (11 hours ago) Dec 22
    to Ryo Hashimoto, Steve Kobes, Nidhi Jaju, Robert Flack, AyeAye, Kenneth Rohde Christiansen, David Bokan, Bao-Duy Tran, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Reland "blink: Update scrollbar existence after pinch-zoom"

    This reverts commit f1636720382d830f0d7e74ef05f6da9a72f2bb62.

    Reason for revert: Fixed failures

    Original change's description:
    > Revert "blink: Update scrollbar existence after pinch-zoom"
    >
    > This reverts commit edec534d70f03b9d6650d8b5b21cefd3131ec9f8.
    >
    > Reason for revert: Causing consistent failures on chromeos-betty-chrome-dchecks
    > i.e. https://ci.chromium.org/ui/p/chrome/builders/ci/chromeos-betty-chrome-dchecks/5021/overview
    >
    > Original change's description:
    > > blink: Update scrollbar existence after pinch-zoom
    > >
    > > Enable scrollbars when the visual viewport is scrollable, and non-custom overlay scrollbar is used.
    > >
    > > BUG=459997344
    > >
    > > Change-Id: I0fed5413cb8eb381ffdc2d3f203c5a0e713e7a9d
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7220770
    > > Reviewed-by: Robert Flack <fla...@chromium.org>
    > > Commit-Queue: Ryo Hashimoto <hash...@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#1560981}
    >
    > Bug: 459997344
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Change-Id: I013145c98eba10c82fe1071ffe5cade5201d0d77
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7277830
    > Owners-Override: Nidhi Jaju <nidh...@chromium.org>
    > Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > Auto-Submit: Nidhi Jaju <nidh...@chromium.org>
    > Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > Cr-Commit-Position: refs/heads/main@{#1561028}
    Bug: 459997344
    Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chromium.try:linux-chromeos-rel;luci.chrome.try:chromeos-betty-chrome,chromeos-betty-chrome-dchecks
    Reviewed-by: Steve Kobes <sko...@chromium.org>
    Commit-Queue: Ryo Hashimoto <hash...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1562043}
    Files:
    • M third_party/blink/renderer/core/frame/root_frame_viewport.cc
    • M third_party/blink/renderer/core/frame/root_frame_viewport.h
    • M third_party/blink/renderer/core/paint/compositing/compositing_test.cc
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area.h
    • M third_party/blink/renderer/core/paint/paint_layer_scrollable_area_test.cc
    • M third_party/blink/renderer/core/scroll/scrollable_area.cc
    • M third_party/blink/renderer/core/scroll/scrollable_area.h
    Change size: M
    Delta: 8 files changed, 188 insertions(+), 14 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Steve Kobes
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I763aad1440112d38bbb56afde2e71135a0a5d922
    Gerrit-Change-Number: 7297835
    Gerrit-PatchSet: 4
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages