[Extensions] Silence unhandled promise rejections in extensions-sidebar [chromium/src : main]
Justin Lulejian (Gerrit)
Justin Lulejian voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Oliver Dunk
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oliver Dunk (Gerrit)
Oliver Dunk added 1 comment![]( "Open in Gerrit")
Would you be able to share a link to an example test failure you are trying to fix? This doesn't seem completely unreasonable, but it is hard to tell if this is the right solution based on just the other CLs linked.
Related details
- Justin Lulejian
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Lulejian (Gerrit)
Justin Lulejian added 1 comment![]( "Open in Gerrit")
Would you be able to share a link to an example test failure you are trying to fix? This doesn't seem completely unreasonable, but it is hard to tell if this is the right solution based on just the other CLs linked.
Hi Oliver!
Here's a link to the test failure: [failed - devtools_frontend_linux_blink_light_rel_fastbuild 42207](https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel_fastbuild/42207/overview). This is technically from patchset 16 of [\[Extensions\] Promisify chrome.devtools.panels namespace (7802276)](https://crrev.com/c/7802276/16?tab=checks) since I'm hitting some different failures on the latest patchset.
You'll see it in the text diff. The failure shows `Uncaught exception in extension context: Script error. [:0]` which is the uncaught promise error throwing.
Related details
- Oliver Dunk
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Oliver Dunk (Gerrit)
Oliver Dunk added 1 comment![]( "Open in Gerrit")
Justin LulejianWould you be able to share a link to an example test failure you are trying to fix? This doesn't seem completely unreasonable, but it is hard to tell if this is the right solution based on just the other CLs linked.
Hi Oliver!
Here's a link to the test failure: [failed - devtools_frontend_linux_blink_light_rel_fastbuild 42207](https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel_fastbuild/42207/overview). This is technically from patchset 16 of [\[Extensions\] Promisify chrome.devtools.panels namespace (7802276)](https://crrev.com/c/7802276/16?tab=checks) since I'm hitting some different failures on the latest patchset.
You'll see it in the text diff. The failure shows `Uncaught exception in extension context: Script error. [:0]` which is the uncaught promise error throwing.
Hmm, I'm still a bit confused here. It seems like `extension_testElementsSidebarSetObject` is failing. Doesn't that mean an API call is returning a rejected Promise unexpectedly?
Maybe I am misunderstanding but I'm a bit worried we are just bypassing the test failure here and letting a genuine failing test behave as a pass.
Related details
- Justin Lulejian
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |