[WebCrypto] add encapsulate/decapsulate operations [chromium/src : main]

[Hubert Chao (Gerrit)]

Attention needed from Lily Chen

Hubert Chao added 1 comment

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Hubert Chao . resolved

@chl...@chromium.org for initial review

Open in Gerrit

Related details

Attention is currently required from:

• Lily Chen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 9

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Lily Chen <chl...@chromium.org>

Gerrit-Comment-Date: Fri, 06 Mar 2026 21:38:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Lily Chen (Gerrit)]

Attention needed from Hubert Chao

Lily Chen voted and added 2 comments

Votes added by Lily Chen

Code-Review

+1

2 comments

File third_party/blink/renderer/modules/crypto/subtle_crypto.idl

Line 58, Patchset 11 (Latest):

Lily Chen . unresolved

nit: delete this newline? In the spec it seems that encapsulateKey and encapsulateBits are together, and decapsulateKey and decapsulateBits are together.

File third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc

Line 66, Patchset 11 (Latest): WebCryptoAlgorithmInfo::kUndefined // DecapsulateBits

Lily Chen . unresolved

nit: does the formatter allow you to put a trailing comma here? It might make future additions a bit easier.

Open in Gerrit

Related details

Attention is currently required from:

• Hubert Chao

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 11

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hubert Chao <hc...@chromium.org>

Gerrit-Comment-Date: Mon, 09 Mar 2026 18:57:15 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hubert Chao (Gerrit)]

Hubert Chao added 2 comments

File third_party/blink/renderer/modules/crypto/subtle_crypto.idl

Line 58, Patchset 11:

Lily Chen . resolved

nit: delete this newline? In the spec it seems that encapsulateKey and encapsulateBits are together, and decapsulateKey and decapsulateBits are together.

Hubert Chao

Done

File third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc

Line 66, Patchset 11: WebCryptoAlgorithmInfo::kUndefined // DecapsulateBits

Lily Chen . resolved

nit: does the formatter allow you to put a trailing comma here? It might make future additions a bit easier.

Hubert Chao

oh hey that does work. that's better, fixed.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 12

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Wed, 11 Mar 2026 18:31:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Lily Chen <chl...@chromium.org>

[Daniel Cheng (Gerrit)]

Attention needed from Hubert Chao

Daniel Cheng voted and added 2 comments

Votes added by Daniel Cheng

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Daniel Cheng . resolved

LGTM

File third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc

Line 503, Patchset 12 (Latest): }

Daniel Cheng . unresolved

I'm assuming this stuff is all covered by tests somewhere.

Open in Gerrit

Related details

Attention is currently required from:

• Hubert Chao

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 12

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hubert Chao <hc...@chromium.org>

Gerrit-Comment-Date: Thu, 12 Mar 2026 18:58:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Hubert Chao (Gerrit)]

Hubert Chao added 1 comment

File third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc

Line 503, Patchset 12: }

Daniel Cheng . resolved

I'm assuming this stuff is all covered by tests somewhere.

Hubert Chao

yep, there are WPTs for all of this. Doesn't matter that much right when the methods aren't implemented, but it'll have coverage once the implementation takes shape.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 13

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Fri, 13 Mar 2026 14:17:57 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

[Hubert Chao (Gerrit)]

Hubert Chao voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Fri, 13 Mar 2026 14:17:59 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

12 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: tools/metrics/histograms/metadata/blink/enums.xml
Insertions: 13, Deletions: 4.

The diff is too large to show. Please review the diff.
```
```
The name of the file: third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
Insertions: 11, Deletions: 4.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[WebCrypto] add encapsulate/decapsulate operations

Add the following functions to SubtleCrypto:

* encapsulateKey
* encapsulateBits
* decapsulateKey
* decapsulateBits

Following the spec at
https://wicg.github.io/webcrypto-modern-algos/#partial-subtlecrypto-interface.

Functions are not implemented yet; this is just adding the
boilerplate scaffolding needed to recognize these functions.

These will be used in ML-KEM. Updated expectations here are because the error
messages have changed.

Bug: 450627019

Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7609661

Commit-Queue: Hubert Chao <hc...@chromium.org>

Reviewed-by: Lily Chen <chl...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1599077}

Files:

• M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
• M third_party/blink/public/platform/web_crypto_algorithm.h
• M third_party/blink/public/platform/web_crypto_key.h
• M third_party/blink/renderer/bindings/generated_in_modules.gni
• M third_party/blink/renderer/bindings/idl_in_modules.gni
• M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_deserializer_for_modules.cc
• M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc
• M third_party/blink/renderer/bindings/modules/v8/serialization/web_crypto_sub_tags.h
• M third_party/blink/renderer/modules/crypto/crypto_key.cc
• A third_party/blink/renderer/modules/crypto/encapsulation.idl
• M third_party/blink/renderer/modules/crypto/normalize_algorithm.cc
• M third_party/blink/renderer/modules/crypto/subtle_crypto.cc
• M third_party/blink/renderer/modules/crypto/subtle_crypto.h
• M third_party/blink/renderer/modules/crypto/subtle_crypto.idl
• M third_party/blink/renderer/platform/exported/web_crypto_algorithm.cc
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/encap_decap/encap_decap_bits.tentative.https.any-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/encap_decap/encap_decap_bits.tentative.https.any.worker-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/encap_decap/encap_decap_keys.tentative.https.any-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/encap_decap/encap_decap_keys.tentative.https.any.worker-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/generateKey/failures_ML-KEM.tentative.https.any-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/generateKey/failures_ML-KEM.tentative.https.any.worker-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/generateKey/successes_ML-KEM.tentative.https.any-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/generateKey/successes_ML-KEM.tentative.https.any.worker-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/import_export/ML-KEM_importKey.tentative.https.any-expected.txt
• M third_party/blink/web_tests/external/wpt/WebCryptoAPI/import_export/ML-KEM_importKey.tentative.https.any.worker-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/encap_decap/encap_decap_bits.tentative.https.any-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/encap_decap/encap_decap_bits.tentative.https.any.worker-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/encap_decap/encap_decap_keys.tentative.https.any-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/encap_decap/encap_decap_keys.tentative.https.any.worker-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/generateKey/successes_ML-KEM.tentative.https.any-expected.txt
• A third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/generateKey/successes_ML-KEM.tentative.https.any.worker-expected.txt
• M third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/import_export/ML-KEM_importKey.tentative.https.any-expected.txt
• M third_party/blink/web_tests/virtual/webcrypto-pqc/external/wpt/WebCryptoAPI/import_export/ML-KEM_importKey.tentative.https.any.worker-expected.txt
• M tools/metrics/histograms/metadata/blink/enums.xml

Change size: XL

Delta: 34 files changed, 5574 insertions(+), 3126 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Daniel Cheng, +1 by Lily Chen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 14

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert

[mexsumjlo088 mexsumjlo088 (Gerrit)]

mexsumjlo088 mexsumjlo088 added 1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

mexsumjlo088 mexsumjlo088 . resolved

Permision Hadir Dan Selamat Hari raya idulfitri 2026 Semoga hari ini menjadi Lebih Baik Dari Hari Hari Yang Lalu Sekian dan Salam Dari Saya maksum marsompel terimakasih

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I4a61bc20d9bcdfa5d1d996b2df55ac264733e72c

Gerrit-Change-Number: 7609661

Gerrit-PatchSet: 14

Gerrit-Owner: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>

Gerrit-Reviewer: Lily Chen <chl...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Benjamin <davi...@chromium.org>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: mexsumjlo088 mexsumjlo088 <mexsum...@gmail.com>

Gerrit-Comment-Date: Sat, 21 Mar 2026 04:54:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Hubert Chao (Gerrit)]

Hubert Chao removed mexsumjlo088 mexsumjlo088 from this change

Deleted Reviewers:

• mexsumjlo088 mexsumjlo088

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: deleteReviewer