[task] Do not align dom timers < 32ms [chromium/src : main]
Etienne Pierre-Doray (Gerrit)
Attention is currently required from: Francois Pierre Doray.
Etienne Pierre-Doray would like Francois Pierre Doray to review this change.
[task] Do not align dom timers < 32ms
Change-Id: I9afb998c64718c0c026ff321aaaddf77287079e8
---
M third_party/blink/common/scheduler/web_scheduler_tracked_feature.cc
M third_party/blink/public/common/scheduler/web_scheduler_tracked_feature.h
M third_party/blink/renderer/modules/mediastream/media_stream_track_impl.cc
M third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
M third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
M third_party/blink/renderer/modules/scheduler/dom_timer.cc
M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/public/scheduling_policy.h
M third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_impl.cc
9 files changed, 5 insertions(+), 43 deletions(-)
To view, visit change 4589092. To unsubscribe, or for help writing mail filters, visit settings.
Etienne Pierre-Doray (Gerrit)
Attention is currently required from: Francois Pierre Doray.
To view, visit change 4589092. To unsubscribe, or for help writing mail filters, visit settings.
Francois Pierre Doray (Gerrit)
Attention is currently required from: Etienne Pierre-Doray.
Patch set 2:Code-Review +1
2 comments:
Patchset:
LGTM
File third_party/blink/renderer/modules/scheduler/dom_timer.cc:
// Under AlignWakeUps experiment, avoid timer alignment if the original delay
// is small, to avoid being affected by ongoing experiments on delay clamping
// MaxUnthrottledTimeoutNestingLevel and SetTimeoutZeroWithoutClamping.
// TODO(1153139) Remove this logic one experiments have shipped.Update comment:
```
// A timer with a long timeout probably doesn't need to run at a precise time,
// so allow some leeway on it. On the other hand, a timer with a short timeout
// may need to run on time to deliver the best user experience.
```
To view, visit change 4589092. To unsubscribe, or for help writing mail filters, visit settings.
Etienne Pierre-Doray (Gerrit)
Attention is currently required from: Kentaro Hara.
Etienne Pierre-Doray would like Kentaro Hara to review this change.
[task] Do not align dom timers < 32ms
Change-Id: I9afb998c64718c0c026ff321aaaddf77287079e8
---
M third_party/blink/common/scheduler/web_scheduler_tracked_feature.cc
M third_party/blink/public/common/scheduler/web_scheduler_tracked_feature.h
M third_party/blink/renderer/modules/mediastream/media_stream_track_impl.cc
M third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
M third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
M third_party/blink/renderer/modules/scheduler/dom_timer.cc
M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/public/scheduling_policy.h
M third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_impl.cc
9 files changed, 8 insertions(+), 47 deletions(-)
Etienne Pierre-Doray (Gerrit)
Attention is currently required from: Kentaro Hara.
2 comments:
Patchset:
+haraken@ for blink/renderer/modules/ owner approval
File third_party/blink/renderer/modules/scheduler/dom_timer.cc:
// Under AlignWakeUps experiment, avoid timer alignment if the original delay
// is small, to avoid being affected by ongoing experiments on delay clamping
// MaxUnthrottledTimeoutNestingLevel and SetTimeoutZeroWithoutClamping.
// TODO(1153139) Remove this logic one experiments have shipped.
Update comment: […]
Done
To view, visit change 4589092. To unsubscribe, or for help writing mail filters, visit settings.
Kentaro Hara (Gerrit)
Attention is currently required from: Etienne Pierre-Doray.
Patch set 3:Code-Review +1
1 comment:
Patchset:
LGTM
To view, visit change 4589092. To unsubscribe, or for help writing mail filters, visit settings.
Etienne Pierre-Doray (Gerrit)
Attention is currently required from: Etienne Pierre-Doray.
Patch set 3:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[task] Do not align dom timers < 32ms
Change-Id: I9afb998c64718c0c026ff321aaaddf77287079e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4589092
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1155552}
---
M third_party/blink/common/scheduler/web_scheduler_tracked_feature.cc
M third_party/blink/public/common/scheduler/web_scheduler_tracked_feature.h
M third_party/blink/renderer/modules/mediastream/media_stream_track_impl.cc
M third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc
M third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc
M third_party/blink/renderer/modules/scheduler/dom_timer.cc
M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
M third_party/blink/renderer/platform/scheduler/public/scheduling_policy.h
M third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_impl.cc
9 files changed, 8 insertions(+), 47 deletions(-)