Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency [chromium/src : main]
Rahul Singh (Gerrit)
Rahul Singh added 6 comments![]( "Open in Gerrit")
Thanks for this change. It mostly looks good. A few comments about other opportunities for renaming.
internal terminology with navigator.storage.persist() and improveShould we also update the UsageCounters for these APIs to use Persistent vs. Durable.
The enum is defined here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom;drc=e1494a7e19155f597a5ff078a42bdefbca492208;l=900-902
And persisted to logs here:
https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/blink/enums.xml;drc=af140c76c416302ecadb5e7cf3f989d6293ba5ec;l=1683-1685
// Once user clears site setting data for `origins`, the Durable storage bitPersistent?
async function checkPermissionUsingPermissionApi() {Thanks for renaming this file. Would `persistent-storage-permissions.html` be an appropriate name based off the browser test that uses this file and the contents of this file?
bool CookieSettings::IsStorageDurable(const GURL& origin) const {nit: IsStoragePersistent?
Would also suggest Find and Replacing other occurances of `IsStorageDurable`.
persistentStorageFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
Related details
- Xiaohan Zhao
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 4 comments![]( "Open in Gerrit")
internal terminology with navigator.storage.persist() and improveShould we also update the UsageCounters for these APIs to use Persistent vs. Durable.
The enum is defined here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom;drc=e1494a7e19155f597a5ff078a42bdefbca492208;l=900-902And persisted to logs here:
https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/blink/enums.xml;drc=af140c76c416302ecadb5e7cf3f989d6293ba5ec;l=1683-1685
Done
// Once user clears site setting data for `origins`, the Durable storage bitXiaohan ZhaoPersistent?
Done
async function checkPermissionUsingPermissionApi() {Thanks for renaming this file. Would `persistent-storage-permissions.html` be an appropriate name based off the browser test that uses this file and the contents of this file?
Done
bool CookieSettings::IsStorageDurable(const GURL& origin) const {nit: IsStoragePersistent?
Would also suggest Find and Replacing other occurances of `IsStorageDurable`.
Do we also need to update the `durable_` member name as well as the `AddDurable` method's name in this class? https://source.chromium.org/chromium/chromium/src/+/main:storage/browser/test/mock_special_storage_policy.h;bpv=1;bpt=1;l=42?gsn=AddDurable&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dstorage%2Fbrowser%2Ftest%2Fmock_special_storage_policy.h%23t9qdr0qJnEgP7W56g22hgQUa_3QhqdEqRzZZPosllsg
Related details
- Rahul Singh
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rahul Singh (Gerrit)
Rahul Singh voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rahul Singh
| Code-Review | +1 |
1 comment
LGTM %ing the question about updates in the devtools_protocol dir. Thanks!
Related details
- Xiaohan Zhao
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 2 comments![]( "Open in Gerrit")
Hi folks, this is a rename-only CL -- changed `DURABLE_STORAGE` to `PERSISTENT_STORAGE`.
Adding OWNERS for relevant files/directories:
- Adding pec...@chromium.org for `android_webview/browser/ aw_permission_manager.cc`.
- Adding ay...@chromium.org for files under `chrome/browser/browsing_data/`.
- Adding dfr...@chromium.org for `chrome/browser/controlled_frame/ controlled_frame_permissions_unittest.cc`.
- Adding mea...@chromium.org for files under `chrome/browser/engagement/`.
Thanks!
persistentStorageFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Related details
- Ayu Ishii
- Dana Fried
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dana Fried (Gerrit)
Dana Fried voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dana Fried
| Code-Review | +1 |
1 comment
LGTM for stuff in chrome/browser (appears to be all straight-up rename), but I am also concerned about the rename and how it will affect any third-party dependents. Please resolve that conversation before submitting.
Related details
- Ayu Ishii
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
- Xiaohan Zhao
Code-Coverage
Code-Review
Ayu Ishii (Gerrit)
Ayu Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ayu Ishii
| Code-Review | +1 |
1 comment
Zijie He (Gerrit)
Zijie He voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zijie He
| Code-Review | +1 |
1 comment
fuchsia_web/ LGTM
Mustafa Emre Acer (Gerrit)
Mustafa Emre Acer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mustafa Emre Acer
| Code-Review | +1 |
1 comment
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
Hi folks, this is a rename-only CL -- changed `DURABLE_STORAGE` to `PERSISTENT_STORAGE`.
Adding OWNERS for relevant files/directories:
- Adding tk...@chromium.org for third_party/blink/public/devtools_protocol/ browser_protocol.pdl. We have a concern that this renaming might have repercussions for clients of this protocol. Please let me know if you think the rename is appropriate, and whether client-side updates would be needed. Thanks!
- Adding tun...@chromium.org for files under components/permissions/.
- Adding ale...@chromium.org for content/public/test/permission_type_unittest.cc.
- Adding fja...@chromium.org for files under content/browser/permissions/.
Thanks!
Related details
- Alex Moshchuk
- Florian Jacky
- Kent Tamura
- Peter Conn
- Rahul Singh
- Thomas Nguyen
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
- Alex Moshchuk
- Evan Stade
- Florian Jacky
- Thomas Nguyen
- Xiaohan Zhao
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
persistentStorageXiaohan ZhaoFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!
Related details
- Alex Moshchuk
- Evan Stade
- Florian Jacky
- Rahul Singh
- Thomas Nguyen
Kent Tamura (Gerrit)
Kent Tamura added 1 comment![]( "Open in Gerrit")
persistentStorageXiaohan ZhaoFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
Xiaohan ZhaoThis change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!
I'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?
Related details
- Alex Moshchuk
- Evan Stade
- Florian Jacky
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
Evan Stade (Gerrit)
Evan Stade added 5 comments![]( "Open in Gerrit")
// Grant if requesting_origin is bookmarked.nit: could you remove this incorrect comment while you're here?
(I assume this was correct at one point, but the decision matrix is a lot more complicated now, and it wasn't updated, nor worth updating IMO)
// ContentSettingPermissionContextBase implementation.nit: most idiomatic and concise style is simply:
`// ContentSettingsPermissionContextBase:`
return "PersistentStorage";this appears to be used to construct a number of different histogram names, such as "Permissions.Action.PersistentStorage.CrossOriginFrame", and therefore we shouldn't change it.
kPersistentStorageEstimate = 1371,I'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.
If we are allowed, I would say they should be called
```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```
since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)
case PermissionName::PERSISTENT_STORAGE:
return "persistent_storage";unfortunately this is exposed to the web via [this interface](https://w3c.github.io/permissions/#permissionstatus-interface) so even though the current name is no-good-very-bad-awful, we can't simply change it.
Related details
- Alex Moshchuk
- Daniel Cheng
- Florian Jacky
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Stade (Gerrit)
Evan Stade added 1 comment![]( "Open in Gerrit")
case PermissionName::PERSISTENT_STORAGE:
return "persistent_storage";unfortunately this is exposed to the web via [this interface](https://w3c.github.io/permissions/#permissionstatus-interface) so even though the current name is no-good-very-bad-awful, we can't simply change it.
(and by "it" I mean the string being returned)
Daniel Cheng (Gerrit)
Daniel Cheng added 1 comment![]( "Open in Gerrit")
kPersistentStorageEstimate = 1371,I'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.
If we are allowed, I would say they should be called
```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)
It should be OK to rename them as long as the values are preserved. If it isn't OK... well, that's something that tooling somewhere should have caught. I'll defer to @evan...@microsoft.com on the naming.
(I've already LGTMed one other CL renaming things so :)
Related details
- Alex Moshchuk
Alex Moshchuk (Gerrit)
Alex Moshchuk voted Code-Review+1![]( "Open in Gerrit")
Evan Stade (Gerrit)
Evan Stade added 1 comment![]( "Open in Gerrit")
kPersistentStorageEstimate = 1371,Daniel ChengI'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.
If we are allowed, I would say they should be called
```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)
It should be OK to rename them as long as the values are preserved. If it isn't OK... well, that's something that tooling somewhere should have caught. I'll defer to @evan...@microsoft.com on the naming.
(I've already LGTMed one other CL renaming things so :)
great, thanks! created https://chromium-review.googlesource.com/c/chromium/src/+/6658778 to make it clearer
Related details
- Daniel Cheng
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
persistentStorageXiaohan ZhaoFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
Xiaohan ZhaoThis change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Kent TamuraHi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!
I'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?
Got it! Looping in Alex @alexr...@chromium.org for clarification, thanks!
Related details
- Alex Rudenko
- Daniel Cheng
- Florian Jacky
- Kent Tamura
- Rahul Singh
- Thomas Nguyen
Alex Rudenko (Gerrit)
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | +1 |
1 comment
persistentStorageXiaohan ZhaoFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
Xiaohan ZhaoThis change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Kent TamuraHi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!
Xiaohan ZhaoI'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?
Got it! Looping in Alex @alexr...@chromium.org for clarification, thanks!
I think the change would not affect the DevTools frontend but might affect WebDriver(ChromeDriver) and Puppeteer implementations. cc @ale...@chromium.org
Since the type is marked as experimental, I think it is fine to make this change but the downstream projects will need to make adjustments.
Related details
- Alex N. Jose
- Florian Jacky
- Kent Tamura
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Nguyen (Gerrit)
Thomas Nguyen voted Code-Review+1![]( "Open in Gerrit")
- Alex N. Jose
- Florian Jacky
- Kent Tamura
- Rahul Singh
- Xiaohan Zhao
Florian Jacky (Gerrit)
Florian Jacky voted and added 1 comment![]( "Open in Gerrit")
Votes added by Florian Jacky
| Code-Review | +1 |
1 comment
- Alex N. Jose
Peter Conn (Gerrit)
Peter Conn voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter Conn
| Code-Review | +1 |
1 comment
//android_webview/ LGTM
Related details
- Alex N. Jose
- Kent Tamura
- Rahul Singh
- Xiaohan Zhao
Code-Coverage
Code-Owners
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
please ping once the CL is ready to land
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Florian Jacky
- Kent Tamura
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
- Zijie He
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 5 comments![]( "Open in Gerrit")
Xiaohan ZhaoLGTM for stuff in chrome/browser (appears to be all straight-up rename), but I am also concerned about the rename and how it will affect any third-party dependents. Please resolve that conversation before submitting.
Done
// Grant if requesting_origin is bookmarked.nit: could you remove this incorrect comment while you're here?
(I assume this was correct at one point, but the decision matrix is a lot more complicated now, and it wasn't updated, nor worth updating IMO)
Done
// ContentSettingPermissionContextBase implementation.nit: most idiomatic and concise style is simply:
`// ContentSettingsPermissionContextBase:`
Done
this appears to be used to construct a number of different histogram names, such as "Permissions.Action.PersistentStorage.CrossOriginFrame", and therefore we shouldn't change it.
Done
case PermissionName::PERSISTENT_STORAGE:
return "persistent_storage";Evan Stadeunfortunately this is exposed to the web via [this interface](https://w3c.github.io/permissions/#permissionstatus-interface) so even though the current name is no-good-very-bad-awful, we can't simply change it.
(and by "it" I mean the string being returned)
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
- Thomas Nguyen
- Zijie He
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Peter Conn (Gerrit)
Peter Conn voted Code-Review+1![]( "Open in Gerrit")
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Mustafa Emre Acer
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
- Zijie He
Thomas Nguyen (Gerrit)
Thomas Nguyen voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Mustafa Emre Acer
- Rahul Singh
- Xiaohan Zhao
- Zijie He
Code-Coverage
Code-Owners
Code-Review
Florian Jacky (Gerrit)
Florian Jacky voted Code-Review+1![]( "Open in Gerrit")
Dana Fried (Gerrit)
Dana Fried added 1 comment![]( "Open in Gerrit")
Waiting on those with better context to make their calls on this.
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
Waiting on those with better context to make their calls on this.
We won't be changing `third_party/blink/public/devtools_protocol/browser_protocol.pdl` for now.
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Mustafa Emre Acer
- Rahul Singh
- Zijie He
Evan Stade (Gerrit)
Evan Stade voted and added 6 comments![]( "Open in Gerrit")
Votes added by Evan Stade
| Commit-Queue | +1 |
| Mega-CQ | +1 |
6 comments
// Copyright 2025 The Chromium Authorsnit: leave year unchanged
// Copyright 2025 The Chromium Authorsnit: leave this as 2015. It's not really a new file even though `git` thinks it is.
// Copyright 2025 The Chromium Authorsnit: leave year unchanged
Register(ContentSettingsType::PERSISTENT_STORAGE, "persistent-storage",I'm only somewhat sure that this string also can't/shouldn't change, as it is exposed to the extension API for modifying content settings. The [docs](https://developer.chrome.com/docs/extensions/reference/api/contentSettings) don't mention this type, but...
[This code](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/content_settings/content_settings_api.cc;l=191-325;drc=0601cef25944198e500b53867354c1b495de36ab;bpv=1;bpt=1) looks up the content type from an extension-provided string, and that string is defined here in this Register call. Then certain types are filtered out, such as `ANTI_ABUSE`. But durable/persistent storage is not one of those types.
@msr...@chromium.org am I interpreting this code wrong? Also are there tests that cover this?
if (!delegate) {
return Response::ServerError(
"Browser context management is not supported.");
}
if (!browser_context_id.has_value()) {
*browser_context = delegate->GetDefaultBrowserContext();
if (*browser_context == nullptr) {
return Response::ServerError(
"Browser context management is not supported.");
}
return Response::Success();
}
Please revert all the unnecessary changes in this file. Even though they are valid style/formatting fixes, they make it harder to find the relevant changes in this patch, and pollute the git history (`blame`). I only see one line that actually needs to have changed, but the file stats are (-25, +46). Normally I think `git cl format` does a good job of only fixing lines that are actually modified locally. Did you by chance invoke a different command?
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Xiaohan Zhao
- Zijie He
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
if (!delegate) {
return Response::ServerError(
"Browser context management is not supported.");
}
if (!browser_context_id.has_value()) {
*browser_context = delegate->GetDefaultBrowserContext();
if (*browser_context == nullptr) {
return Response::ServerError(
"Browser context management is not supported.");
}
return Response::Success();
}
Please revert all the unnecessary changes in this file. Even though they are valid style/formatting fixes, they make it harder to find the relevant changes in this patch, and pollute the git history (`blame`). I only see one line that actually needs to have changed, but the file stats are (-25, +46). Normally I think `git cl format` does a good job of only fixing lines that are actually modified locally. Did you by chance invoke a different command?
I think `git cl format` did this. I only used `git cl format`, and I've turned off Vscode's auto format.
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Evan Stade
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Zijie He
Evan Stade (Gerrit)
Evan Stade added 1 comment![]( "Open in Gerrit")
if (!delegate) {
return Response::ServerError(
"Browser context management is not supported.");
}
if (!browser_context_id.has_value()) {
*browser_context = delegate->GetDefaultBrowserContext();
if (*browser_context == nullptr) {
return Response::ServerError(
"Browser context management is not supported.");
}
return Response::Success();
}
Xiaohan ZhaoPlease revert all the unnecessary changes in this file. Even though they are valid style/formatting fixes, they make it harder to find the relevant changes in this patch, and pollute the git history (`blame`). I only see one line that actually needs to have changed, but the file stats are (-25, +46). Normally I think `git cl format` does a good job of only fixing lines that are actually modified locally. Did you by chance invoke a different command?
I think `git cl format` did this. I only used `git cl format`, and I've turned off Vscode's auto format.
Hmm, not sure what went wrong then. When I make just the necessary changes to this file and then run `git cl format`, it doesn't add all these curlies. ([patch](https://chromium-review.googlesource.com/c/chromium/src/+/6897749))
This is working as intended --- to get the full file reformatted, you'd have to pass `--full`. But we intentionally don't make `--full` the default setting as we don't want to generate more changes than necessary.
Luckily it should be simple enough to revert the changes in this file, and re-fix the two lines that need updating. If `git cl format` is still behaving weirdly for you then we can file a bug and follow up on it later.
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Dana Fried
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Xiaohan Zhao
- Zijie He
Evan Stade (Gerrit)
Evan Stade added 1 comment![]( "Open in Gerrit")
Register(ContentSettingsType::PERSISTENT_STORAGE, "persistent-storage",I'm only somewhat sure that this string also can't/shouldn't change, as it is exposed to the extension API for modifying content settings. The [docs](https://developer.chrome.com/docs/extensions/reference/api/contentSettings) don't mention this type, but...
[This code](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/content_settings/content_settings_api.cc;l=191-325;drc=0601cef25944198e500b53867354c1b495de36ab;bpv=1;bpt=1) looks up the content type from an extension-provided string, and that string is defined here in this Register call. Then certain types are filtered out, such as `ANTI_ABUSE`. But durable/persistent storage is not one of those types.
@msr...@chromium.org am I interpreting this code wrong? Also are there tests that cover this?
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
Martin Šrámek (Gerrit)
Martin Šrámek added 1 comment![]( "Open in Gerrit")
Register(ContentSettingsType::PERSISTENT_STORAGE, "persistent-storage",Evan StadeI'm only somewhat sure that this string also can't/shouldn't change, as it is exposed to the extension API for modifying content settings. The [docs](https://developer.chrome.com/docs/extensions/reference/api/contentSettings) don't mention this type, but...
[This code](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/content_settings/content_settings_api.cc;l=191-325;drc=0601cef25944198e500b53867354c1b495de36ab;bpv=1;bpt=1) looks up the content type from an extension-provided string, and that string is defined here in this Register call. Then certain types are filtered out, such as `ANTI_ABUSE`. But durable/persistent storage is not one of those types.
@msr...@chromium.org am I interpreting this code wrong? Also are there tests that cover this?
Martin to reviewer, ptal this file
This ultimately ends up in `WebsiteSettingsInfo::name_`.
Primarily, WebsiteSettingsInfo uses it to compute `pref_name_` and `default_value_pref_name_` which are used by DefaultProvider and PrefProvider, respectively. These two store the user-defined values for settings, i.e. values that users make in chrome://settings/content, grants from permission prompts, etc.
Looking at the `ContentSettings.RegularProfile.Exceptions.durable-storage` histogram which has non-zero data, it seems that it is possible to store user-defined exceptions, despite this setting not being represented in chrome://settings/content. I guess that's because this permission is handled by `PermissionContext`, despite not being an actual user-facing permission?
So if you rename this, you'll reset the permission for everyone because we'll start reading from new prefs which are empty. And we'll also end up with some orphaned PII in the PrefStore that we'll have to clean up. If you want to rename it, you'll have to properly migrate the data. That's probably not worth it - I'd recommend keeping as is, at least for the sake of this already large CL.
You're right that it's also exposed through the `WebsiteSettingsInfo::name()` getter which seems to be called from the extensions code. I'm not quite sure what this is for, but we're not exposing this permission in https://developer.chrome.com/docs/extensions/reference/api/contentSettings so unless there is some other API, this is probably moot.
Related details
- Alex Moshchuk
- Alex N. Jose
- Ayu Ishii
- Kent Tamura
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 8 comments![]( "Open in Gerrit")
Xiaohan ZhaoWaiting on those with better context to make their calls on this.
We won't be changing `third_party/blink/public/devtools_protocol/browser_protocol.pdl` for now.
Done
// Copyright 2025 The Chromium AuthorsXiaohan Zhaonit: leave year unchanged
Done
nit: leave this as 2015. It's not really a new file even though `git` thinks it is.
Done
// Copyright 2025 The Chromium AuthorsXiaohan Zhaonit: leave year unchanged
Done
// Copyright 2025 The Chromium AuthorsXiaohan Zhaoditto
Done
Register(ContentSettingsType::PERSISTENT_STORAGE, "persistent-storage",Evan StadeI'm only somewhat sure that this string also can't/shouldn't change, as it is exposed to the extension API for modifying content settings. The [docs](https://developer.chrome.com/docs/extensions/reference/api/contentSettings) don't mention this type, but...
[This code](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/extensions/api/content_settings/content_settings_api.cc;l=191-325;drc=0601cef25944198e500b53867354c1b495de36ab;bpv=1;bpt=1) looks up the content type from an extension-provided string, and that string is defined here in this Register call. Then certain types are filtered out, such as `ANTI_ABUSE`. But durable/persistent storage is not one of those types.
@msr...@chromium.org am I interpreting this code wrong? Also are there tests that cover this?
Martin ŠrámekMartin to reviewer, ptal this file
This ultimately ends up in `WebsiteSettingsInfo::name_`.
Primarily, WebsiteSettingsInfo uses it to compute `pref_name_` and `default_value_pref_name_` which are used by DefaultProvider and PrefProvider, respectively. These two store the user-defined values for settings, i.e. values that users make in chrome://settings/content, grants from permission prompts, etc.
Looking at the `ContentSettings.RegularProfile.Exceptions.durable-storage` histogram which has non-zero data, it seems that it is possible to store user-defined exceptions, despite this setting not being represented in chrome://settings/content. I guess that's because this permission is handled by `PermissionContext`, despite not being an actual user-facing permission?
So if you rename this, you'll reset the permission for everyone because we'll start reading from new prefs which are empty. And we'll also end up with some orphaned PII in the PrefStore that we'll have to clean up. If you want to rename it, you'll have to properly migrate the data. That's probably not worth it - I'd recommend keeping as is, at least for the sake of this already large CL.
You're right that it's also exposed through the `WebsiteSettingsInfo::name()` getter which seems to be called from the extensions code. I'm not quite sure what this is for, but we're not exposing this permission in https://developer.chrome.com/docs/extensions/reference/api/contentSettings so unless there is some other API, this is probably moot.
Done
if (!delegate) {
return Response::ServerError(
"Browser context management is not supported.");
}
if (!browser_context_id.has_value()) {
*browser_context = delegate->GetDefaultBrowserContext();
if (*browser_context == nullptr) {
return Response::ServerError(
"Browser context management is not supported.");
}
return Response::Success();
}
Xiaohan ZhaoPlease revert all the unnecessary changes in this file. Even though they are valid style/formatting fixes, they make it harder to find the relevant changes in this patch, and pollute the git history (`blame`). I only see one line that actually needs to have changed, but the file stats are (-25, +46). Normally I think `git cl format` does a good job of only fixing lines that are actually modified locally. Did you by chance invoke a different command?
Evan StadeI think `git cl format` did this. I only used `git cl format`, and I've turned off Vscode's auto format.
Hmm, not sure what went wrong then. When I make just the necessary changes to this file and then run `git cl format`, it doesn't add all these curlies. ([patch](https://chromium-review.googlesource.com/c/chromium/src/+/6897749))
This is working as intended --- to get the full file reformatted, you'd have to pass `--full`. But we intentionally don't make `--full` the default setting as we don't want to generate more changes than necessary.
Luckily it should be simple enough to revert the changes in this file, and re-fix the two lines that need updating. If `git cl format` is still behaving weirdly for you then we can file a bug and follow up on it later.
Done
persistentStorageXiaohan ZhaoFlagging for follow up with directory OWNERS.
Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?
Xiaohan ZhaoThis change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)
Kent TamuraHi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!
Xiaohan ZhaoI'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?
Alex RudenkoGot it! Looping in Alex @alexr...@chromium.org for clarification, thanks!
I think the change would not affect the DevTools frontend but might affect WebDriver(ChromeDriver) and Puppeteer implementations. cc @ale...@chromium.org
Since the type is marked as experimental, I think it is fine to make this change but the downstream projects will need to make adjustments.
- Alex Moshchuk
- Alex N. Jose
- Alex Rudenko
- Ayu Ishii
- Dana Fried
- Evan Stade
- Florian Jacky
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
- Thomas Nguyen
- Zijie He
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Stade (Gerrit)
Evan Stade voted and added 1 comment![]( "Open in Gerrit")
Votes added by Evan Stade
- Alex Moshchuk
- Alex N. Jose
- Alex Rudenko
- Ayu Ishii
- Dana Fried
- Florian Jacky
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Peter Conn
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
- Zijie He
Evan Stade (Gerrit)
Evan Stade added 1 comment![]( "Open in Gerrit")
thanks!
hmm, I guess the PersistentStoragePermissionContextTest failure is related... but +1 modulo fixing that.
Dana Fried (Gerrit)
Dana Fried added 1 comment![]( "Open in Gerrit")
I only own one file and only distantly; added in a more relevant reviewer.
Related details
- Alex Moshchuk
- Alex N. Jose
- Alex Rudenko
- Ayu Ishii
- Christine Ying
Peter Conn (Gerrit)
Peter Conn voted and added 1 comment![]( "Open in Gerrit")
Votes added by Peter Conn
| Code-Review | +1 |
1 comment
- Alex Moshchuk
- Alex N. Jose
- Alex Rudenko
- Ayu Ishii
- Christine Ying
- Florian Jacky
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
- Zijie He
Code-Coverage
Code-Owners
Code-Review
Alex Moshchuk (Gerrit)
Alex Moshchuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Moshchuk
| Code-Review | +1 |
1 comment
Zijie He (Gerrit)
Zijie He added 1 comment![]( "Open in Gerrit")
I don't think my lgtm is needed anymore 😄
Related details
- Alex N. Jose
- Alex Rudenko
- Ayu Ishii
- Christine Ying
- Florian Jacky
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
- Alex N. Jose
- Ayu Ishii
- Christine Ying
- Florian Jacky
- Kent Tamura
- Martin Šrámek
- Mustafa Emre Acer
- Rahul Singh
- Thomas Nguyen
- Xiaohan Zhao
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zijie He (Gerrit)
Zijie He voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Martin Šrámek (Gerrit)
Martin Šrámek voted and added 1 comment![]( "Open in Gerrit")
Votes added by Martin Šrámek
| Code-Review | +1 |
1 comment
site_settings* and content_settings* LGTM
(renaming is OK everywhere EXCEPT in the string passed to ContentSettingsRegistry, as this is the pref name, so we're keeping it as-is)
Related details
- Alex N. Jose
- Ayu Ishii
- Christine Ying
- Florian Jacky
- Kent Tamura
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
Hi folks, this is a rename-only CL -- changed DURABLE_STORAGE to PERSISTENT_STORAGE.
Adding OWNERS for relevant files/directories:
- Adding tl...@chromium.org for `chrome/browser/controlled_frame/controlled_frame_permissions_unittest.cc` and `chrome/browser/ui/webui/settings/safety_hub_handler_unittest.cc`
- Adding emil...@chromium.org for
- `chrome/browser/extensions/extension_special_storage_policy.h`
- `chrome/browser/extensions/extension_special_storage_policy.cc`
- `chrome/browser/extensions/extension_special_storage_policy_unittest.cc`
- `extensions/shell/browser/shell_special_storage_policy.h`
- `extensions/shell/browser/shell_special_storage_policy.cc`
- Adding jop...@chromium.org for `components/cast_receiver/browser/permissions_manager_impl_unittest.cc`
Thanks!
Related details
- Alex N. Jose
- Emilia Paz
- Florian Jacky
- Jordan Bayles
- Rahul Singh
- Tom Lukaszewicz
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tom Lukaszewicz (Gerrit)
Tom Lukaszewicz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tom Lukaszewicz
| Code-Review | +1 |
1 comment
- Alex N. Jose
- Emilia Paz
- Florian Jacky
- Jordan Bayles
- Rahul Singh
- Xiaohan Zhao
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
Hi folks, this is a rename-only CL -- changed DURABLE_STORAGE to PERSISTENT_STORAGE. Please take a look when you have time. Thanks!
Related details
- Alex N. Jose
- Balazs Engedy
- Chromium IPC Reviews
- Emilia Paz
- Florian Jacky
- Jordan Bayles
- Rahul Singh
- Rakina Zata Amni
- Richard (Torne) Coles
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Balazs Engedy (Gerrit)
Balazs Engedy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Balazs Engedy
| Code-Review | +1 |
1 comment
- Alex N. Jose
- Chromium IPC Reviews
- Emilia Paz
- Florian Jacky
- Jordan Bayles
- Rahul Singh
- Rakina Zata Amni
- Richard (Torne) Coles
- Xiaohan Zhao
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Alex N. Jose
- Emilia Paz
- Florian Jacky
- Jordan Bayles
- Ken Buchanan
- Rahul Singh
- Rakina Zata Amni
- Richard (Torne) Coles
- Xiaohan Zhao
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
- Alex N. Jose
Richard (Torne) Coles (Gerrit)
Richard (Torne) Coles voted and added 1 comment![]( "Open in Gerrit")
Votes added by Richard (Torne) Coles
| Code-Review | +1 |
1 comment
- Alex N. Jose
- Florian Jacky
- Jordan Bayles
- Ken Buchanan
- Rahul Singh
- Rakina Zata Amni
- Xiaohan Zhao
Ken Buchanan (Gerrit)
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
- Alex N. Jose
- Florian Jacky
- Jordan Bayles
Jordan Bayles (Gerrit)
Jordan Bayles voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jordan Bayles
| Code-Review | +1 |
1 comment
LGTM.
There may be a few more places to rename. For example, the ContentType enums.xml description mentiones a "Durable storage setting": https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;drc=635a890faddb6b584d58988671fc82ff780c0572;l=2371.
And I'm not sure exactly how the devtools fronted protocol.ts gets generated, maybe it's covered here? https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/generated/protocol.ts;drc=f054abc24946b4ff6cbb52affb091c31481136f6;l=2224
Related details
- Alex N. Jose
- Florian Jacky
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
LGTM.
There may be a few more places to rename. For example, the ContentType enums.xml description mentiones a "Durable storage setting": https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/enums.xml;drc=635a890faddb6b584d58988671fc82ff780c0572;l=2371.
And I'm not sure exactly how the devtools fronted protocol.ts gets generated, maybe it's covered here? https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/generated/protocol.ts;drc=f054abc24946b4ff6cbb52affb091c31481136f6;l=2224
Thanks for the review! The ContentType enums.xml description has been updated, it's included here https://chromium-review.googlesource.com/c/chromium/src/+/6625736/15/tools/metrics/histograms/enums.xml.
For the devtools fronted protocol.ts, it can get updated by updating the `third_party/devtools-frontend/src/node_modules/devtools-protocol/pdl/domains/Browser.pdl` https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/node_modules/devtools-protocol/pdl/domains/Browser.pdl;l=1?q=Browser.pdl&sq=#:~:text=displayCapture-,durableStorage,-geolocation. Would this have repercussions for clients of this protocol? We have discussed whether to update the `third_party/blink/public/devtools_protocol/domains/Browser.pdl` previously (https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/devtools_protocol/domains/Browser.pdl#:~:text=displayCapture-,durableStorage,-geolocation), and we think it might affect WebDriver(ChromeDriver) and Puppeteer implementations. cc. But considering this CL already touches a large number of files, and updating this would also require downstream changes, so we decided to not include it for now. Do you think the third_party/devtools_front_end/ pdl should follow the same approach, or handle it differently? Thanks!
Related details
- Alex N. Jose
- Florian Jacky
- Rahul Singh
- Rakina Zata Amni
Xiaohan Zhao (Gerrit)
Xiaohan Zhao added 1 comment![]( "Open in Gerrit")
Hello Zijie, this is a rename-only CL -- changed DURABLE_STORAGE to PERSISTENT_STORAGE. Please take a look when you have time. Thanks!
Related details
- Alex N. Jose
- Florian Jacky
- Rahul Singh
- Rakina Zata Amni
- Zijie He
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Rakina Zata Amni voted Code-Review+1![]( "Open in Gerrit")
- Alex N. Jose
- Florian Jacky
- Rahul Singh
- Xiaohan Zhao
- Zijie He
Zijie He (Gerrit)
Zijie He voted and added 1 comment![]( "Open in Gerrit")
Votes added by Zijie He
| Code-Review | +1 |
1 comment
fuchsia_web/ LGTM.
Related details
- Alex N. Jose
- Florian Jacky
- Rahul Singh
- Xiaohan Zhao
Code-Coverage
Code-Owners
Xiaohan Zhao (Gerrit)
Xiaohan Zhao voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
- Alex N. Jose
- Florian Jacky
- Rahul Singh
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency
This patch renames instances of ContentSettingsType::DURABLE_STORAGE
to PERSISTENT_STORAGE across multiple components. The goal is to align
internal terminology with navigator.storage.persist() and improve
code clarity.
This is a cleanup-only change and does not affect any IPC messaging
logic or privilege-sensitive data flow. It is limited to enum renaming
and related test updates.
- M android_webview/browser/aw_permission_manager.cc
- M chrome/browser/BUILD.gn
- M chrome/browser/browsing_data/chrome_browsing_data_remover_constants.h
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
- M chrome/browser/browsing_data/counters/site_data_counting_helper.cc
- M chrome/browser/controlled_frame/controlled_frame_permissions_unittest.cc
- M chrome/browser/engagement/important_sites_util.cc
- M chrome/browser/engagement/important_sites_util.h
- M chrome/browser/extensions/extension_special_storage_policy.cc
- M chrome/browser/extensions/extension_special_storage_policy.h
- M chrome/browser/extensions/extension_special_storage_policy_unittest.cc
- M chrome/browser/permissions/permission_manager_factory.cc
- M chrome/browser/resources/privacy_sandbox/internals/content_settings_groups.ts
- D chrome/browser/storage/durable_storage_permission_context.h
- R chrome/browser/storage/persistent_storage_browsertest.cc
- R chrome/browser/storage/persistent_storage_permission_context.cc
- A chrome/browser/storage/persistent_storage_permission_context.h
- R chrome/browser/storage/persistent_storage_permission_context_unittest.cc
- M chrome/browser/ui/views/permissions/permission_prompt_bubble_base_view_browsertest.cc
- M chrome/browser/ui/webui/settings/safety_hub_handler_unittest.cc
- M chrome/browser/ui/webui/settings/site_settings_handler.cc
- M chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
- M chrome/browser/ui/webui/settings/site_settings_helper.cc
- M chrome/test/BUILD.gn
- R chrome/test/data/persistent/persistent-storage-permissions.html
- M components/cast_receiver/browser/permissions_manager_impl_unittest.cc
- M components/content_settings/core/browser/content_settings_registry.cc
- M components/content_settings/core/browser/content_settings_registry_unittest.cc
- M components/content_settings/core/browser/content_settings_uma_util.cc
- M components/content_settings/core/browser/cookie_settings.cc
- M components/content_settings/core/browser/cookie_settings.h
- M components/content_settings/core/common/content_settings_types.mojom
- M components/permissions/content_setting_permission_context_base_unittest.cc
- M components/permissions/permission_decision_auto_blocker_unittest.cc
- M components/permissions/permission_util.cc
- M content/browser/buckets/bucket_host.cc
- M content/browser/buckets/bucket_manager_host.cc
- M content/browser/devtools/protocol/browser_handler.cc
- M content/browser/permissions/permission_controller_impl.cc
- M content/browser/permissions/permission_descriptor_util.cc
- M content/public/test/permission_type_unittest.cc
- M content/shell/browser/shell_permission_manager.cc
- M extensions/shell/browser/shell_special_storage_policy.cc
- M extensions/shell/browser/shell_special_storage_policy.h
- M fuchsia_web/webengine/browser/frame_impl.cc
- M fuchsia_web/webengine/browser/frame_permission_controller.cc
- M storage/browser/quota/quota_database.cc
- M storage/browser/quota/quota_database_unittest.cc
- M storage/browser/quota/special_storage_policy.h
- M storage/browser/test/mock_special_storage_policy.cc
- M storage/browser/test/mock_special_storage_policy.h
- M third_party/blink/common/permissions/permission_utils.cc
- M third_party/blink/public/common/permissions/permission_utils.h
- M third_party/blink/public/mojom/permissions/permission.mojom
- M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
- M third_party/blink/renderer/modules/permissions/permission_utils.cc
- M third_party/blink/renderer/modules/quota/storage_manager.cc
- M third_party/blink/renderer/modules/quota/storage_manager.idl
- M tools/metrics/histograms/enums.xml
- M tools/metrics/histograms/metadata/blink/enums.xml
Code-Review: +1 by Balazs Engedy, +1 by Rakina Zata Amni, +1 by Tom Lukaszewicz, +1 by Ken Buchanan, +1 by Zijie He, +1 by Emilia Paz, +1 by Richard (Torne) Coles, +1 by Jordan Bayles
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |