Rename DURABLE_STORAGE to PERSISTENT_STORAGE for consistency [chromium/src : main]

[Rahul Singh (Gerrit)]

Attention needed from Xiaohan Zhao

Rahul Singh added 6 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Rahul Singh . resolved

Thanks for this change. It mostly looks good. A few comments about other opportunities for renaming.

Commit Message

Line 11, Patchset 3 (Latest):internal terminology with navigator.storage.persist() and improve

Rahul Singh . unresolved

Should we also update the UsageCounters for these APIs to use Persistent vs. Durable.

The enum is defined here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom;drc=e1494a7e19155f597a5ff078a42bdefbca492208;l=900-902

It's used here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/quota/storage_manager.idl;drc=df8b3d6ba0348e17fbba01217a3e9614b3d97e06;l=10-14

And persisted to logs here:
https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/blink/enums.xml;drc=af140c76c416302ecadb5e7cf3f989d6293ba5ec;l=1683-1685

File chrome/browser/ui/webui/settings/site_settings_handler.cc

Line 2453, Patchset 3 (Latest): // Once user clears site setting data for `origins`, the Durable storage bit

Rahul Singh . unresolved

Persistent?

File chrome/test/data/persistent/persistence-permissions.html

Line 8, Patchset 3 (Latest):async function checkPermissionUsingPermissionApi() {

Rahul Singh . unresolved

Thanks for renaming this file. Would `persistent-storage-permissions.html` be an appropriate name based off the browser test that uses this file and the contents of this file?

File components/content_settings/core/browser/cookie_settings.cc

Line 264, Patchset 3 (Latest):bool CookieSettings::IsStorageDurable(const GURL& origin) const {

Rahul Singh . unresolved

nit: IsStoragePersistent?

Would also suggest Find and Replacing other occurances of `IsStorageDurable`.

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3 (Latest): persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Open in Gerrit

Related details

Attention is currently required from:

• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 3

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Wed, 11 Jun 2025 19:06:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Xiaohan Zhao (Gerrit)]

Attention needed from Rahul Singh

Xiaohan Zhao added 4 comments

Commit Message

Line 11, Patchset 3 (Latest):internal terminology with navigator.storage.persist() and improve

Rahul Singh . resolved

Should we also update the UsageCounters for these APIs to use Persistent vs. Durable.

The enum is defined here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom;drc=e1494a7e19155f597a5ff078a42bdefbca492208;l=900-902

It's used here:
https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/quota/storage_manager.idl;drc=df8b3d6ba0348e17fbba01217a3e9614b3d97e06;l=10-14

And persisted to logs here:
https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/blink/enums.xml;drc=af140c76c416302ecadb5e7cf3f989d6293ba5ec;l=1683-1685

Xiaohan Zhao

Done

File chrome/browser/ui/webui/settings/site_settings_handler.cc

Line 2453, Patchset 3 (Latest): // Once user clears site setting data for `origins`, the Durable storage bit

Rahul Singh . resolved

Persistent?

Xiaohan Zhao

Done

File chrome/test/data/persistent/persistence-permissions.html

Line 8, Patchset 3 (Latest):async function checkPermissionUsingPermissionApi() {

Rahul Singh . resolved

Thanks for renaming this file. Would `persistent-storage-permissions.html` be an appropriate name based off the browser test that uses this file and the contents of this file?

Xiaohan Zhao

Done

File components/content_settings/core/browser/cookie_settings.cc

Line 264, Patchset 3 (Latest):bool CookieSettings::IsStorageDurable(const GURL& origin) const {

Rahul Singh . resolved

nit: IsStoragePersistent?

Would also suggest Find and Replacing other occurances of `IsStorageDurable`.

Xiaohan Zhao

Do we also need to update the `durable_` member name as well as the `AddDurable` method's name in this class? https://source.chromium.org/chromium/chromium/src/+/main:storage/browser/test/mock_special_storage_policy.h;bpv=1;bpt=1;l=42?gsn=AddDurable&gs=KYTHE%3A%2F%2Fkythe%3A%2F%2Fchromium.googlesource.com%2Fcodesearch%2Fchromium%2Fsrc%2F%2Fmain%3Flang%3Dc%252B%252B%3Fpath%3Dstorage%2Fbrowser%2Ftest%2Fmock_special_storage_policy.h%23t9qdr0qJnEgP7W56g22hgQUa_3QhqdEqRzZZPosllsg

Open in Gerrit

Related details

Attention is currently required from:

• Rahul Singh

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 3

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Comment-Date: Fri, 13 Jun 2025 00:24:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rahul Singh <rah...@microsoft.com>

[Rahul Singh (Gerrit)]

Attention needed from Xiaohan Zhao

Rahul Singh voted and added 1 comment

Votes added by Rahul Singh

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Rahul Singh . resolved

LGTM %ing the question about updates in the devtools_protocol dir. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Tue, 17 Jun 2025 19:23:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Xiaohan Zhao (Gerrit)]

Attention needed from Ayu Ishii, Dana Fried, Mustafa Emre Acer, Peter Conn and Rahul Singh

Xiaohan Zhao added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Xiaohan Zhao . resolved

Hi folks, this is a rename-only CL -- changed `DURABLE_STORAGE` to `PERSISTENT_STORAGE`.

Adding OWNERS for relevant files/directories:

• Adding pec...@chromium.org for `android_webview/browser/ aw_permission_manager.cc`.
• Adding ay...@chromium.org for files under `chrome/browser/browsing_data/`.
• Adding dfr...@chromium.org for `chrome/browser/controlled_frame/ controlled_frame_permissions_unittest.cc`.
• Adding mea...@chromium.org for files under `chrome/browser/engagement/`.

Thanks!

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3: persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Xiaohan Zhao

This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)

Open in Gerrit

Related details

Attention is currently required from:

• Ayu Ishii
• Dana Fried
• Mustafa Emre Acer
• Peter Conn
• Rahul Singh

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Attention: Ayu Ishii <ay...@chromium.org>

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Dana Fried <dfr...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Comment-Date: Tue, 17 Jun 2025 23:41:10 +0000

[Dana Fried (Gerrit)]

Attention needed from Ayu Ishii, Mustafa Emre Acer, Peter Conn, Rahul Singh and Xiaohan Zhao

Dana Fried voted and added 1 comment

Votes added by Dana Fried

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Dana Fried . unresolved

LGTM for stuff in chrome/browser (appears to be all straight-up rename), but I am also concerned about the rename and how it will affect any third-party dependents. Please resolve that conversation before submitting.

Open in Gerrit

Related details

Attention is currently required from:

• Ayu Ishii

• Mustafa Emre Acer
• Peter Conn
• Rahul Singh

• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Jun 2025 15:13:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Ayu Ishii (Gerrit)]

Attention needed from Mustafa Emre Acer, Peter Conn, Rahul Singh and Xiaohan Zhao

Ayu Ishii voted and added 1 comment

Votes added by Ayu Ishii

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Ayu Ishii . resolved

LGTM chrome/browser/browsing_data/*

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Jun 2025 17:30:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Zijie He (Gerrit)]

Attention needed from Mustafa Emre Acer, Peter Conn, Rahul Singh and Xiaohan Zhao

Zijie He voted and added 1 comment

Votes added by Zijie He

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Zijie He . resolved

fuchsia_web/ LGTM

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Jun 2025 17:56:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Mustafa Emre Acer (Gerrit)]

Attention needed from Peter Conn, Rahul Singh and Xiaohan Zhao

Mustafa Emre Acer voted and added 1 comment

Votes added by Mustafa Emre Acer

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Mustafa Emre Acer . resolved

*.mojom LGTM

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Jun 2025 19:07:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Xiaohan Zhao (Gerrit)]

Attention needed from Alex Moshchuk, Florian Jacky, Kent Tamura, Peter Conn, Rahul Singh and Thomas Nguyen

Xiaohan Zhao added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Xiaohan Zhao . resolved

Hi folks, this is a rename-only CL -- changed `DURABLE_STORAGE` to `PERSISTENT_STORAGE`.

Adding OWNERS for relevant files/directories:

• Adding tk...@chromium.org for third_party/blink/public/devtools_protocol/ browser_protocol.pdl. We have a concern that this renaming might have repercussions for clients of this protocol. Please let me know if you think the rename is appropriate, and whether client-side updates would be needed. Thanks!
• Adding tun...@chromium.org for files under components/permissions/.
• Adding ale...@chromium.org for content/public/test/permission_type_unittest.cc.
• Adding fja...@chromium.org for files under content/browser/permissions/.

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Florian Jacky
• Kent Tamura
• Peter Conn
• Rahul Singh
• Thomas Nguyen

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Florian Jacky <fja...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Jun 2025 20:46:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Alex Moshchuk, Evan Stade, Florian Jacky, Thomas Nguyen and Xiaohan Zhao

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Evan Stade
• Florian Jacky
• Thomas Nguyen
• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>

Gerrit-Reviewer: Florian Jacky <fja...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Evan Stade <evan...@microsoft.com>

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Thu, 19 Jun 2025 22:17:27 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Xiaohan Zhao (Gerrit)]

Attention needed from Alex Moshchuk, Evan Stade, Florian Jacky, Rahul Singh and Thomas Nguyen

Xiaohan Zhao added 1 comment

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3: persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Xiaohan Zhao

This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)

Xiaohan Zhao

Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Evan Stade
• Florian Jacky

• Rahul Singh
• Thomas Nguyen

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 00:17:13 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rahul Singh <rah...@microsoft.com>

Comment-In-Reply-To: Xiaohan Zhao <xiaoh...@microsoft.com>

[Kent Tamura (Gerrit)]

Attention needed from Alex Moshchuk, Evan Stade, Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Kent Tamura added 1 comment

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3: persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Xiaohan Zhao

This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)

Xiaohan Zhao

Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!

Kent Tamura

I'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Evan Stade
• Florian Jacky
• Rahul Singh
• Thomas Nguyen

• Xiaohan Zhao

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 00:21:01 +0000

[Evan Stade (Gerrit)]

Attention needed from Alex Moshchuk, Daniel Cheng, Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Evan Stade added 5 comments

File chrome/browser/storage/persistent_storage_permission_context.h

Line 28, Patchset 5 (Parent): // Grant if requesting_origin is bookmarked.

Evan Stade . unresolved

nit: could you remove this incorrect comment while you're here?

(I assume this was correct at one point, but the decision matrix is a lot more complicated now, and it wasn't updated, nor worth updating IMO)

Line 27, Patchset 5 (Parent): // ContentSettingPermissionContextBase implementation.

Evan Stade . unresolved

nit: most idiomatic and concise style is simply:

`// ContentSettingsPermissionContextBase:`

File third_party/blink/common/permissions/permission_utils.cc

Line 37, Patchset 5 (Latest): return "PersistentStorage";

Evan Stade . unresolved

this appears to be used to construct a number of different histogram names, such as "Permissions.Action.PersistentStorage.CrossOriginFrame", and therefore we shouldn't change it.

File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom

Line 902, Patchset 5 (Latest): kPersistentStorageEstimate = 1371,

Evan Stade . unresolved

I'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.

If we are allowed, I would say they should be called

```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```

since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)

File third_party/blink/renderer/modules/permissions/permission_utils.cc

Line 86, Patchset 5 (Latest): case PermissionName::PERSISTENT_STORAGE:
return "persistent_storage";

Evan Stade . unresolved

unfortunately this is exposed to the web via [this interface](https://w3c.github.io/permissions/#permissionstatus-interface) so even though the current name is no-good-very-bad-awful, we can't simply change it.

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Daniel Cheng

• Florian Jacky
• Rahul Singh
• Thomas Nguyen
• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>

Gerrit-Reviewer: Florian Jacky <fja...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 00:25:25 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Evan Stade (Gerrit)]

Attention needed from Alex Moshchuk, Daniel Cheng, Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Evan Stade added 1 comment

File third_party/blink/renderer/modules/permissions/permission_utils.cc

Line 86, Patchset 5 (Latest): case PermissionName::PERSISTENT_STORAGE:
return "persistent_storage";

Evan Stade . unresolved

unfortunately this is exposed to the web via [this interface](https://w3c.github.io/permissions/#permissionstatus-interface) so even though the current name is no-good-very-bad-awful, we can't simply change it.

Evan Stade

(and by "it" I mean the string being returned)

Gerrit-Comment-Date: Fri, 20 Jun 2025 00:27:10 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Evan Stade <evan...@microsoft.com>

[Daniel Cheng (Gerrit)]

Attention needed from Alex Moshchuk, Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Daniel Cheng added 1 comment

File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom

Line 902, Patchset 5 (Latest): kPersistentStorageEstimate = 1371,

Evan Stade . unresolved

I'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.

If we are allowed, I would say they should be called

```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```

since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)

Daniel Cheng

It should be OK to rename them as long as the values are preserved. If it isn't OK... well, that's something that tooling somewhere should have caught. I'll defer to @evan...@microsoft.com on the naming.

(I've already LGTMed one other CL renaming things so :)

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 05:43:23 +0000

[Alex Moshchuk (Gerrit)]

Attention needed from Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Alex Moshchuk voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 18:14:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Evan Stade (Gerrit)]

Attention needed from Daniel Cheng, Florian Jacky, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Evan Stade added 1 comment

File third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom

Line 902, Patchset 5 (Latest): kPersistentStorageEstimate = 1371,

Evan Stade . resolved

I'm unsure about whether we're allowed to rename this. My guess is yes, but need @dch...@chromium.org (closest OWNER) or someone to confirm.

If we are allowed, I would say they should be called

```
kStorageManagerPersist
kStorageManagerPersisted
kStorageManagerEstimate
```

since they correlate to [this interface](https://storage.spec.whatwg.org/#storagemanager)

Daniel Cheng

It should be OK to rename them as long as the values are preserved. If it isn't OK... well, that's something that tooling somewhere should have caught. I'll defer to @evan...@microsoft.com on the naming.

(I've already LGTMed one other CL renaming things so :)

Evan Stade

great, thanks! created https://chromium-review.googlesource.com/c/chromium/src/+/6658778 to make it clearer

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 18:25:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

Comment-In-Reply-To: Evan Stade <evan...@microsoft.com>

[Xiaohan Zhao (Gerrit)]

Attention needed from Alex Rudenko, Daniel Cheng, Florian Jacky, Kent Tamura, Rahul Singh and Thomas Nguyen

Xiaohan Zhao added 1 comment

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3: persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Xiaohan Zhao

This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)

Xiaohan Zhao

Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!

Kent Tamura

I'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?

Xiaohan Zhao

Got it! Looping in Alex @alexr...@chromium.org for clarification, thanks!

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Daniel Cheng
• Florian Jacky
• Kent Tamura
• Rahul Singh
• Thomas Nguyen

Gerrit-CC: Alex Rudenko <alexr...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 20 Jun 2025 18:40:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Alex N. Jose, Florian Jacky, Kent Tamura, Rahul Singh, Thomas Nguyen and Xiaohan Zhao

Alex Rudenko voted and added 1 comment

Votes added by Alex Rudenko

Code-Review

+1

1 comment

File third_party/blink/public/devtools_protocol/browser_protocol.pdl

Line 1497, Patchset 3: persistentStorage

Rahul Singh . unresolved

Flagging for follow up with directory OWNERS.

Would this have repercussions for clients of this protocol? E.g. third_party/devtools_front_end has usage of durableStorage. Should those usages be updated too? Or should we avoid updating this entry?

Xiaohan Zhao

This change is related to the change in [content/browser/devtools/protocol/browser_handler.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/devtools/protocol/browser_handler.cc;bpv=1;bpt=1;l=237?q=PermissionTypeEnum%20-path:out&ss=chromium%2Fchromium%2Fsrc)

Xiaohan Zhao

Hi Kent @tk...@chromium.org, could you please give us suggestions on clients side updates? Thanks!

Kent Tamura

I'm not familiar with DevTools protocol. Can you ask devtools_protocol/OWNERS ?

Xiaohan Zhao

Got it! Looping in Alex @alexr...@chromium.org for clarification, thanks!

Alex Rudenko

I think the change would not affect the DevTools frontend but might affect WebDriver(ChromeDriver) and Puppeteer implementations. cc @ale...@chromium.org

Since the type is marked as experimental, I think it is fine to make this change but the downstream projects will need to make adjustments.

Open in Gerrit

Related details

Attention is currently required from:

• Alex N. Jose

• Florian Jacky
• Kent Tamura
• Rahul Singh
• Thomas Nguyen

• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 5

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>

Gerrit-Reviewer: Florian Jacky <fja...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: Alex N. Jose <ale...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Alex N. Jose <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Mon, 23 Jun 2025 07:15:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Thomas Nguyen (Gerrit)]

Attention needed from Alex N. Jose, Florian Jacky, Kent Tamura, Rahul Singh and Xiaohan Zhao

Thomas Nguyen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Alex N. Jose
• Florian Jacky
• Kent Tamura
• Rahul Singh

• Xiaohan Zhao

Gerrit-Comment-Date: Mon, 23 Jun 2025 09:18:31 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Florian Jacky (Gerrit)]

Attention needed from Alex N. Jose, Kent Tamura, Rahul Singh and Xiaohan Zhao

Florian Jacky voted and added 1 comment

Votes added by Florian Jacky

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Florian Jacky . resolved

content/browser/permissions lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Alex N. Jose

Gerrit-Attention: Alex N. Jose <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Comment-Date: Mon, 23 Jun 2025 09:49:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Peter Conn (Gerrit)]

Attention needed from Alex N. Jose, Kent Tamura, Rahul Singh and Xiaohan Zhao

Peter Conn voted and added 1 comment

Votes added by Peter Conn

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Peter Conn . resolved

//android_webview/ LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Alex N. Jose
• Kent Tamura
• Rahul Singh
• Xiaohan Zhao

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Comment-Date: Mon, 30 Jun 2025 09:45:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Alex Rudenko (Gerrit)]

Attention needed from Alex Moshchuk, Alex N. Jose, Ayu Ishii, Florian Jacky, Kent Tamura, Mustafa Emre Acer, Peter Conn, Rahul Singh, Thomas Nguyen, Xiaohan Zhao and Zijie He

Alex Rudenko added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Alex Rudenko . resolved

please ping once the CL is ready to land

Open in Gerrit

Related details

Attention is currently required from:

• Alex Moshchuk
• Alex N. Jose
• Ayu Ishii
• Florian Jacky
• Kent Tamura

• Mustafa Emre Acer
• Peter Conn

• Rahul Singh
• Thomas Nguyen
• Xiaohan Zhao

• Zijie He

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia8ef1cacedbaa79cb2e64fd9ce32dcc43404b074

Gerrit-Change-Number: 6625736

Gerrit-PatchSet: 8

Gerrit-Owner: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Ayu Ishii <ay...@chromium.org>

Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Evan Stade <evan...@microsoft.com>

Gerrit-Reviewer: Florian Jacky <fja...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Reviewer: Peter Conn <pec...@chromium.org>

Gerrit-Reviewer: Rahul Singh <rah...@microsoft.com>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-Reviewer: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Reviewer: Zijie He <zij...@google.com>

Gerrit-CC: Alex N. Jose <ale...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mustafa Emre Acer <mea...@chromium.org>

Gerrit-Attention: Ayu Ishii <ay...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Peter Conn <pec...@chromium.org>

Gerrit-Attention: Florian Jacky <fja...@chromium.org>

Gerrit-Attention: Zijie He <zij...@google.com>

Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>

Gerrit-Attention: Rahul Singh <rah...@microsoft.com>

Gerrit-Attention: Alex N. Jose <ale...@chromium.org>

Gerrit-Attention: Xiaohan Zhao <xiaoh...@microsoft.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Comment-Date: Fri, 04 Jul 2025 07:05:53 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No