Pass const BasicShape& to ValueForBasicShape() [chromium/src : main]

[Fredrik Söderquist (Gerrit)]

Attention needed from Ian Kilpatrick

Fredrik Söderquist voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ian Kilpatrick

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I69284ed202fb54a6d32b2b1a15c297eecec8e5da

Gerrit-Change-Number: 7814047

Gerrit-PatchSet: 1

Gerrit-Owner: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-Comment-Date: Tue, 05 May 2026 08:17:24 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Ian Kilpatrick (Gerrit)]

Attention needed from Fredrik Söderquist

Ian Kilpatrick voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

• Fredrik Söderquist

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I69284ed202fb54a6d32b2b1a15c297eecec8e5da

Gerrit-Change-Number: 7814047

Gerrit-PatchSet: 1

Gerrit-Owner: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Fredrik Söderquist <f...@opera.com>

Gerrit-Comment-Date: Tue, 05 May 2026 16:07:45 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Pass const BasicShape& to ValueForBasicShape()

It already assumes a non-null `basic_shape`. Update the dereferences and
drop redundant type declarations.

Drop unnecessary template arguments for the InitializeBorderRadius()
implementations and reorder the arguments to match coding style.

Change-Id: I69284ed202fb54a6d32b2b1a15c297eecec8e5da

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7814047

Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>

Commit-Queue: Ian Kilpatrick <ikilp...@chromium.org>

Auto-Submit: Fredrik Söderquist <f...@opera.com>

Cr-Commit-Position: refs/heads/main@{#1625500}

Files:

• M third_party/blink/renderer/core/css/basic_shape_functions.cc
• M third_party/blink/renderer/core/css/basic_shape_functions.h
• M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
• M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc

Change size: M

Delta: 4 files changed, 73 insertions(+), 73 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Ian Kilpatrick

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I69284ed202fb54a6d32b2b1a15c297eecec8e5da

Gerrit-Change-Number: 7814047

Gerrit-PatchSet: 2

Gerrit-Owner: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>

Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>