Remove RAPPOR reporting infrastructure. [chromium/src : master]

Alexei Svitkine (Gerrit)

unread,

Feb 4, 2021, 1:45:14 PM2/4/21

to Steven Holte, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org

Attention is currently required from: Steven Holte.

Alexei Svitkine would like Steven Holte to review this change.

View Change

Remove RAPPOR reporting infrastructure.

Only a handful of metrics were still reported using this, which
are have been confirmed to be OK to remove.

Includes code to clear the obsolete rappor prefs.

Bug: 1016906
Change-Id: I8765494bcf6730107e585e8a244195b29d61f42e
---
M .gitignore
M BUILD.gn
M WATCHLISTS
M chrome/android/BUILD.gn
M chrome/android/chrome_java_sources.gni
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivityLifecycleUmaTracker.java
D chrome/android/java/src/org/chromium/chrome/browser/rappor/RapporServiceBridge.java
M chrome/browser/BUILD.gn
M chrome/browser/DEPS
D chrome/browser/android/rappor/rappor_service_bridge.cc
M chrome/browser/android/vr/BUILD.gn
M chrome/browser/browser_process.h
M chrome/browser/browser_process_impl.cc
M chrome/browser/browser_process_impl.h
M chrome/browser/chrome_browser_main.cc
M chrome/browser/chromeos/BUILD.gn
M chrome/browser/extensions/BUILD.gn
M chrome/browser/metrics/chrome_metrics_services_manager_client.cc
M chrome/browser/metrics/chrome_metrics_services_manager_client.h
M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
M chrome/browser/prefs/browser_prefs.cc
M chrome/browser/prefs/pref_service_incognito_allowlist.cc
M chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_win.cc
M chrome/browser/ui/BUILD.gn
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc
M chrome/browser/ui/content_settings/content_setting_bubble_model.h
M chrome/browser/vr/BUILD.gn
M chrome/renderer/DEPS
M chrome/test/BUILD.gn
M chrome/test/base/testing_browser_process.cc
M chrome/test/base/testing_browser_process.h
M chrome/tools/build/win/FILES.cfg
M components/BUILD.gn
M components/metrics/net/net_metrics_log_uploader.cc
M components/metrics_services_manager/BUILD.gn
M components/metrics_services_manager/DEPS
M components/metrics_services_manager/metrics_services_manager.cc
M components/metrics_services_manager/metrics_services_manager.h
M components/metrics_services_manager/metrics_services_manager_client.h
M components/ntp_tiles/BUILD.gn
M components/ntp_tiles/DEPS
D components/rappor/BUILD.gn
D components/rappor/DEPS
D components/rappor/DIR_METADATA
D components/rappor/OWNERS
D components/rappor/README.md
D components/rappor/bloom_filter.cc
D components/rappor/bloom_filter.h
D components/rappor/bloom_filter_unittest.cc
D components/rappor/byte_vector_utils.cc
D components/rappor/byte_vector_utils.h
D components/rappor/byte_vector_utils_unittest.cc
D components/rappor/log_uploader.cc
D components/rappor/log_uploader.h
D components/rappor/log_uploader_interface.h
D components/rappor/log_uploader_unittest.cc
D components/rappor/proto/BUILD.gn
D components/rappor/proto/rappor_metric.proto
D components/rappor/public/BUILD.gn
D components/rappor/public/rappor_parameters.h
D components/rappor/public/rappor_service.h
D components/rappor/public/rappor_utils.h
D components/rappor/public/sample.h
D components/rappor/rappor_metric.cc
D components/rappor/rappor_metric.h
D components/rappor/rappor_metric_unittest.cc
D components/rappor/rappor_parameters.cc
D components/rappor/rappor_pref_names.cc
D components/rappor/rappor_pref_names.h
D components/rappor/rappor_prefs.cc
D components/rappor/rappor_prefs.h
D components/rappor/rappor_prefs_unittest.cc
D components/rappor/rappor_service_impl.cc
D components/rappor/rappor_service_impl.h
D components/rappor/rappor_service_unittest.cc
D components/rappor/rappor_utils.cc
D components/rappor/rappor_utils_unittest.cc
D components/rappor/reports.cc
D components/rappor/reports.h
D components/rappor/reports_unittest.cc
D components/rappor/sample.cc
D components/rappor/sampler.cc
D components/rappor/sampler.h
D components/rappor/sampler_unittest.cc
D components/rappor/test_log_uploader.cc
D components/rappor/test_log_uploader.h
D components/rappor/test_rappor_service.cc
D components/rappor/test_rappor_service.h
M components/security_interstitials/DEPS
M content/browser/BUILD.gn
M content/browser/DEPS
M content/browser/renderer_host/DEPS
M content/browser/renderer_host/render_widget_host_delegate.cc
M content/browser/renderer_host/render_widget_host_delegate.h
M content/browser/web_contents/web_contents_impl.cc
M content/browser/web_contents/web_contents_impl.h
M content/test/BUILD.gn
M ios/chrome/browser/BUILD.gn
M ios/chrome/browser/DEPS
M ios/chrome/browser/application_context.h
M ios/chrome/browser/application_context_impl.h
M ios/chrome/browser/application_context_impl.mm
M ios/chrome/browser/ios_chrome_main_parts.mm
M ios/chrome/browser/metrics/BUILD.gn
M ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h
M ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
M ios/chrome/browser/prefs/BUILD.gn
M ios/chrome/browser/prefs/browser_prefs.mm
M ios/chrome/browser/ui/ntp/BUILD.gn
M ios/chrome/test/testing_application_context.h
M ios/chrome/test/testing_application_context.mm
M ios/components/security_interstitials/BUILD.gn
M ios/components/security_interstitials/ios_blocking_page_metrics_helper.h
M tools/metrics/BUILD.gn
M tools/metrics/histograms/histograms_xml/others/histograms.xml
M tools/metrics/metrics_python_tests.py
D tools/metrics/rappor/OWNERS
D tools/metrics/rappor/PRESUBMIT.py
D tools/metrics/rappor/README.md
D tools/metrics/rappor/pretty_print.py
D tools/metrics/rappor/rappor.xml
D tools/metrics/rappor/rappor_model.py
D tools/metrics/rappor/rappor_model_test.py
M tools/traffic_annotation/summary/annotations.xml
M tools/traffic_annotation/summary/grouping.xml
125 files changed, 38 insertions(+), 4,985 deletions(-)

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Svitkine (Gerrit)

unread,

Feb 4, 2021, 1:45:22 PM2/4/21

to alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Attention is currently required from: Steven Holte.

View Change

1 comment:

Patchset:
- Patch Set #7:
  holte: overall review
  Will add other OWNERS afterwards.

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Svitkine (Gerrit)

unread,

Feb 4, 2021, 1:57:21 PM2/4/21

to Martin Šrámek, Jochen Eisinger, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Steven Holte

Attention is currently required from: Martin Šrámek, Jochen Eisinger, Steven Holte.

Alexei Svitkine would like Martin Šrámek and Jochen Eisinger to review this change.

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Svitkine (Gerrit)

unread,

Feb 4, 2021, 1:57:27 PM2/4/21

to alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Martin Šrámek, Jochen Eisinger, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Attention is currently required from: Martin Šrámek, Jochen Eisinger, Steven Holte.

View Change

1 comment:

Patchset:

Patch Set #7:

'git cl owners' suggested adding jochen@ and msramek@ to get full OWNERS coverage for this CL.

msramek:
  chrome/browser/ui/content_settings/content_setting_bubble_model.cc
  chrome/browser/ui/content_settings/content_setting_bubble_model.h
  tools/traffic_annotation/summary/annotations.xml
  tools/traffic_annotation/summary/grouping.xml
jochen:
  <everything else other than metrics directories that holte@ covers>

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Martin Šrámek (Gerrit)

unread,

Feb 4, 2021, 2:40:25 PM2/4/21

to Alexei Svitkine, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Jochen Eisinger, Steven Holte, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Attention is currently required from: Alexei Svitkine, Jochen Eisinger, Steven Holte.

Patch set 8:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #8:
  The end of an era! Here's 🥂 to a better one with federated analytics that could come eventually :)
  content_settings/ and traffic_annotations/ LGTM

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Steven Holte (Gerrit)

unread,

Feb 4, 2021, 4:03:43 PM2/4/21

to Alexei Svitkine, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Steven Holte, Martin Šrámek, Jochen Eisinger, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Attention is currently required from: Alexei Svitkine, Jochen Eisinger.

Patch set 8:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #8:
  Good to see this get cleaned up!

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Jochen Eisinger (Gerrit)

unread,

Feb 4, 2021, 4:29:12 PM2/4/21

to Alexei Svitkine, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Steven Holte, Martin Šrámek, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Attention is currently required from: Alexei Svitkine.

Patch set 8:Code-Review +1

View Change

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Alexei Svitkine (Gerrit)

unread,

Feb 4, 2021, 5:28:39 PM2/4/21

to alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Jochen Eisinger, Steven Holte, Martin Šrámek, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Patch set 8:Commit-Queue +2

View Change

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Feb 4, 2021, 6:25:31 PM2/4/21

to Alexei Svitkine, alexmo...@chromium.org, amalov...@chromium.org, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, csharris...@chromium.org, droger+w...@chromium.org, druber...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, joenotcha...@chromium.org, juncai...@chromium.org, lizeb+watch...@chromium.org, loading-rev...@chromium.org, marq+...@chromium.org, mlamouri+w...@chromium.org, nasko+c...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, oshima...@chromium.org, peconn...@chromium.org, pshmako...@chromium.org, speed-metr...@chromium.org, tommyw+w...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, Jochen Eisinger, Steven Holte, Martin Šrámek, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, Rijubrata Bhaumik, srirama chandra sekhar, Tim Volodine

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Martin Šrámek: Looks good to me
  Steven Holte: Looks good to me
  Jochen Eisinger: Looks good to me
  Alexei Svitkine: Commit

Remove RAPPOR reporting infrastructure.

Only a handful of metrics were still reported using this, which
are have been confirmed to be OK to remove.

Includes code to clear the obsolete rappor prefs.

Bug: 1016906
Change-Id: I8765494bcf6730107e585e8a244195b29d61f42e

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2672923
Reviewed-by: Martin Šrámek <msr...@chromium.org>
Reviewed-by: Steven Holte <ho...@chromium.org>
Reviewed-by: Jochen Eisinger <joc...@chromium.org>
Commit-Queue: Alexei Svitkine <asvi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#850848}

125 files changed, 42 insertions(+), 4,985 deletions(-)

To view, visit change 2672923. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward