Remove dark mode DarkModeInversionAlgorithm and force dark switches. [chromium/src : main]

0 views
Skip to first unread message

Prashant Nevase (Gerrit)

unread,
Nov 13, 2025, 10:48:42 AM (yesterday) Nov 13
to Philip Rogers, Stephen Chenney, Peter Conn, Peter Beverloo, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Peter Beverloo, Peter Conn, Philip Rogers and Stephen Chenney

Prashant Nevase voted and added 1 comment

Votes added by Prashant Nevase

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Prashant Nevase . resolved

ptal

Open in Gerrit

Related details

Attention is currently required from:
  • Peter Beverloo
  • Peter Conn
  • Philip Rogers
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I551a73269bda5f98d951ee763afc5f98edbc7cc7
Gerrit-Change-Number: 7146839
Gerrit-PatchSet: 3
Gerrit-Owner: Prashant Nevase <pne...@microsoft.com>
Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Prashant Nevase <pne...@microsoft.com>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Prashant Nevase <pras...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Peter Conn <pec...@chromium.org>
Gerrit-Attention: Peter Beverloo <pe...@chromium.org>
Gerrit-Comment-Date: Thu, 13 Nov 2025 15:48:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Conn (Gerrit)

unread,
Nov 13, 2025, 11:52:29 AM (yesterday) Nov 13
to Prashant Nevase, Chromium LUCI CQ, Philip Rogers, Stephen Chenney, Peter Beverloo, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Peter Beverloo, Philip Rogers, Prashant Nevase and Stephen Chenney

Peter Conn voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Peter Beverloo
  • Philip Rogers
  • Prashant Nevase
  • Stephen Chenney
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I551a73269bda5f98d951ee763afc5f98edbc7cc7
    Gerrit-Change-Number: 7146839
    Gerrit-PatchSet: 3
    Gerrit-Owner: Prashant Nevase <pne...@microsoft.com>
    Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
    Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Prashant Nevase <pne...@microsoft.com>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Prashant Nevase <pras...@chromium.org>
    Gerrit-Attention: Prashant Nevase <pne...@microsoft.com>
    Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Thu, 13 Nov 2025 16:52:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Peter Beverloo (Gerrit)

    unread,
    Nov 13, 2025, 12:21:08 PM (yesterday) Nov 13
    to Prashant Nevase, Peter Conn, Chromium LUCI CQ, Philip Rogers, Stephen Chenney, Peter Beverloo, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Philip Rogers, Prashant Nevase and Stephen Chenney

    Peter Beverloo added 1 comment

    Patchset-level comments
    Peter Beverloo . resolved

    Would you mind removing the references from the following two files as well?

    android_webview/browser/aw_feature_entries.cc
    android_webview/browser/aw_feature_entries_unittest.cc

    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Comment-Date: Thu, 13 Nov 2025 17:20:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Prashant Nevase (Gerrit)

    unread,
    Nov 13, 2025, 11:53:20 PM (23 hours ago) Nov 13
    to Peter Conn, Chromium LUCI CQ, Philip Rogers, Stephen Chenney, Peter Beverloo, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Peter Beverloo, Philip Rogers and Stephen Chenney

    Prashant Nevase voted and added 1 comment

    Votes added by Prashant Nevase

    Auto-Submit+0

    1 comment

    Patchset-level comments
    Peter Beverloo . resolved

    Would you mind removing the references from the following two files as well?

    android_webview/browser/aw_feature_entries.cc
    android_webview/browser/aw_feature_entries_unittest.cc

    Prashant Nevase

    ya I missed it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Peter Beverloo
    • Philip Rogers
    • Stephen Chenney
    Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 04:52:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Peter Beverloo <pe...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Peter Beverloo (Gerrit)

    unread,
    5:11 AM (18 hours ago) 5:11 AM
    to Prashant Nevase, Peter Beverloo, Peter Conn, Chromium LUCI CQ, Philip Rogers, Stephen Chenney, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, android-web...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Peter Conn, Philip Rogers, Prashant Nevase and Stephen Chenney

    Peter Beverloo voted and added 2 comments

    Votes added by Peter Beverloo

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Peter Beverloo . resolved

    Thank you!

    File android_webview/browser/aw_feature_entries_unittest.cc
    Line 29, Patchset 5 (Latest):const flags_ui::FeatureEntry::FeatureVariation kForceDarkVariations[] = {
    Peter Beverloo . unresolved

    nit: now unused, you can delete this (which will also fix the build issue)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Peter Conn
    • Philip Rogers
    • Prashant Nevase
    • Stephen Chenney
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I551a73269bda5f98d951ee763afc5f98edbc7cc7
      Gerrit-Change-Number: 7146839
      Gerrit-PatchSet: 5
      Gerrit-Owner: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
      Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Prashant Nevase <pras...@chromium.org>
      Gerrit-Attention: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Philip Rogers <p...@chromium.org>
      Gerrit-Attention: Peter Conn <pec...@chromium.org>
      Gerrit-Comment-Date: Fri, 14 Nov 2025 10:10:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Philip Rogers (Gerrit)

      unread,
      6:36 PM (5 hours ago) 6:36 PM
      to Prashant Nevase, Peter Beverloo, Peter Conn, Chromium LUCI CQ, Stephen Chenney, AyeAye, chromium...@chromium.org, Dirk Schulze, Prashant Nevase, android-web...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Peter Conn, Prashant Nevase and Stephen Chenney

      Philip Rogers added 2 comments

      Patchset-level comments
      File-level comment, Patchset 7 (Latest):
      Philip Rogers . resolved

      LGTM

      File android_webview/browser/aw_feature_entries_unittest.cc
      Line 35, Patchset 7 (Latest):TEST(AwFeatureEntriesTest, ForceDarkEntry) {
      Philip Rogers . unresolved

      This seems to be crashing. Is `NameForOption(2)` right?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Peter Conn
      • Prashant Nevase
      • Stephen Chenney
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I551a73269bda5f98d951ee763afc5f98edbc7cc7
      Gerrit-Change-Number: 7146839
      Gerrit-PatchSet: 7
      Gerrit-Owner: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Reviewer: Peter Beverloo <pe...@chromium.org>
      Gerrit-Reviewer: Peter Conn <pec...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Prashant Nevase <pras...@chromium.org>
      Gerrit-Attention: Prashant Nevase <pne...@microsoft.com>
      Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Peter Conn <pec...@chromium.org>
      Gerrit-Comment-Date: Fri, 14 Nov 2025 23:36:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages