Commit-Queue | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Code-Review | +1 |
switch (property_type) {
Same comment as the other review to look into if we need this or can make this templatized and get the template value directly.
}
Might be worth adding a NOT_REACHED to the end to catch cases where a new type is supported, and we forget to add a case to one of the related switch statements
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Might be worth adding a NOT_REACHED to the end to catch cases where a new type is supported, and we forget to add a case to one of the related switch statements
Added that at first, but from discussions with @kbab...@microsoft.com, he suggested I leave that to the compiler in this discussion:
https://chromium-review.googlesource.com/c/chromium/src/+/5962852/comment/40450188_14ee0066/
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Code-Review | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |
[Gap Decorations]: Generalize `column-rule-color` parsing code
This CL generalizes the parsing logic for `column-rule-color` by
introducing the `ConsumeGapDecorationPropertyValue` function. This
function consumes different values based on the
`CSSGapDecorationPropertyType`. Following this, calls to `ConsumeColor`
are replaced with `ConsumeGapDecorationPropertyValue`. This approach
avoids the need to repeat the entire parsing logic when the only
difference is the value consumed.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. | Gerrit |