Norge Vizcay (Gerrit)

unread,

Jun 12, 2026, 5:38:55 AMJun 12

to Tamino Bauknecht, Daniel Cheng, Jihad Hanna, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, browser-comp...@chromium.org

Attention needed from Jihad Hanna and Tamino Bauknecht

Norge Vizcay voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jihad Hanna
Tamino Bauknecht

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jihad Hanna (Gerrit)

unread,

Jun 12, 2026, 7:13:40 PMJun 12

to Tamino Bauknecht, Norge Vizcay, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, browser-comp...@chromium.org

Attention needed from Tamino Bauknecht

Jihad Hanna voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Tamino Bauknecht

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 15, 2026, 5:19:12 AM (13 days ago) Jun 15

to Tamino Bauknecht, Jihad Hanna, Norge Vizcay, Daniel Cheng, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jshin...@chromium.org, browser-comp...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

autofill: Wrap all fields in test::FieldDescription in std::optional

This allows other functions to reuse this type and check if a test
explicitly set the field or if it simply wanted to use the default
value.

Specifically, this will be used by crrev.com/c/7912947 that creates a
custom matcher that can directly match a `FormFieldData` against a
`test::FieldDescription` without the need of creating another
`FormFieldData` first.

Bug: 41483772

Change-Id: Ie53942732be6ca423f08a2c34e2cd7005cb516a4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7912946

Reviewed-by: Jihad Hanna <jihad...@google.com>

Commit-Queue: Tamino Bauknecht <tam...@chromium.org>

Reviewed-by: Norge Vizcay <viz...@google.com>

Cr-Commit-Position: refs/heads/main@{#1646649}

Files:

M chrome/browser/autofill/actor/actor_form_filling_service_unittest.cc
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_encoding_unittest.cc
M components/autofill/core/browser/crowdsourcing/determine_possible_field_types_unittest.cc
M components/autofill/core/browser/filling/form_filler_unittest.cc
M components/autofill/core/browser/metrics/prediction_quality_metrics_unittest.cc
M components/autofill/core/common/test_utils/autofill_form_test_utils.h

Change size: M

Delta: 6 files changed, 75 insertions(+), 78 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Jihad Hanna, +1 by Norge Vizcay

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

autofill: Wrap all fields in test::FieldDescription in std::optional [chromium/src : main]

Norge Vizcay (Gerrit)

Norge Vizcay voted Code-Review+1

Related details

Jihad Hanna (Gerrit)

Jihad Hanna voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information