More dumps to investigate AnchorElementMetricsSender::UpdateMetrics [chromium/src : main]
0 views
Skip to first unread message
Kevin McNee (Gerrit)
Apr 24, 2024, 11:32:49 AMApr 24
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Jeremy Roman
Kevin McNee added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Apr 25, 2024, 11:12:40 AMApr 25
to Kevin McNee, Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Kevin McNee
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kevin McNee
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kevin McNee (Gerrit)
Apr 25, 2024, 1:54:20 PMApr 25
to Jeremy Roman, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Kevin McNee voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 25, 2024, 2:48:18 PMApr 25
to Kevin McNee, Jeremy Roman, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
More dumps to investigate AnchorElementMetricsSender::UpdateMetrics
The checks related to metrics_partitions_ hold, so we turn those into
full checks.
We continue to investigate why the EraseIf assertions don't hold.
A possibility could be that an anchor gets an id that isn't valid to
store in a map. We dump if that happens.
Bug: 331043758
Change-Id: I604ec08893897713fac96f4e734c6d793f36bef8
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Commit-Queue: Kevin McNee <mc...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1292597}
Files:
- M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
Change size: S
Delta: 1 file changed, 16 insertions(+), 15 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages