Make Cookie-Indices experimental [chromium/src : main]
0 views
Skip to first unread message
Domenic Denicola (Gerrit)
Jun 17, 2025, 3:26:33 AMJun 17
to Rakina Zata Amni, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Kent Tamura and Rakina Zata Amni
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kent Tamura
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 17, 2025, 3:29:15 AMJun 17
to Domenic Denicola, Kent Tamura, Rakina Zata Amni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Domenic Denicola and Rakina Zata Amni
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Domenic Denicola
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 17, 2025, 7:51:30 PMJun 17
to Domenic Denicola, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Domenic Denicola
Rakina Zata Amni added 1 comment![]( "Open in Gerrit")
File content/public/common/content_features.h
Line 182, Patchset 6 (Latest):
CONTENT_EXPORT BASE_DECLARE_FEATURE(kPrefetchCookieIndices);Rakina Zata Amni . unresolved
Since this is not used outside of `//content`, can you put this in `content/common/features.h` instead which is also included from `content/public/common/content_switch_dependent_feature_overrides.cc`?
Related details
Attention is currently required from:
- Domenic Denicola
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Domenic Denicola (Gerrit)
Jun 18, 2025, 2:49:41 AMJun 18
to Kent Tamura, Rakina Zata Amni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Kent Tamura and Rakina Zata Amni
Domenic Denicola voted and added 1 comment![]( "Open in Gerrit")
Votes added by Domenic Denicola
| Commit-Queue | +1 |
1 comment
File content/public/common/content_features.h
Line 182, Patchset 6:
CONTENT_EXPORT BASE_DECLARE_FEATURE(kPrefetchCookieIndices);Rakina Zata Amni . resolved
Since this is not used outside of `//content`, can you put this in `content/common/features.h` instead which is also included from `content/public/common/content_switch_dependent_feature_overrides.cc`?
Domenic Denicola
Done! Sorry for missing the comment at the top of the file :(
Related details
Attention is currently required from:
- Kent Tamura
- Rakina Zata Amni
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Jun 18, 2025, 3:04:44 AMJun 18
to Domenic Denicola, Kent Tamura, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Domenic Denicola and Kent Tamura
Rakina Zata Amni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rakina Zata Amni
| Code-Review | +1 |
Rakina Zata Amni . resolved
Attention is currently required from:
- Domenic Denicola
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Jun 18, 2025, 3:08:32 AMJun 18
to Domenic Denicola, Kent Tamura, Rakina Zata Amni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Attention needed from Domenic Denicola
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Domenic Denicola
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Domenic Denicola (Gerrit)
Jun 18, 2025, 9:16:50 PMJun 18
to Kent Tamura, Rakina Zata Amni, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Domenic Denicola voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 18, 2025, 9:20:03 PMJun 18
to Domenic Denicola, Kent Tamura, Rakina Zata Amni, AyeAye, chromium...@chromium.org, prerendering-reviews, blink-...@chromium.org, gavin...@chromium.org, tburkar...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make Cookie-Indices experimental
To help reduce the number of prefetch-related virtual test suites, we
mark the Cookie-Indices related features as dependent on experimental
web platform features, so that they are on by default when running web
platform tests.
This requires moving the base::Feature declarations from
prefetch_features.h to content_features.h so they can be referenced from
content_switch_dependent_feature_overrides.cc.
Bug: 328628231
Change-Id: If48e2e8f48e01793d22a3c9549bb73d1421e2031
Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Commit-Queue: Domenic Denicola <dom...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1475954}
Files:
- M content/browser/preloading/prefetch/prefetch_features.cc
- M content/browser/preloading/prefetch/prefetch_features.h
- M content/common/features.cc
- M content/common/features.h
- M content/public/common/content_switch_dependent_feature_overrides.cc
- M third_party/blink/web_tests/VirtualTestSuites
Change size: S
Delta: 6 files changed, 15 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rakina Zata Amni, +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages