preloading: Cancel prerendering if window.closed is called [chromium/src : main]
Hiroki Nakagawa (Gerrit)
Hiroki Nakagawa voted and added 4 comments![]( "Open in Gerrit")
Votes added by Hiroki Nakagawa
| Code-Review | +1 |
4 comments
for more details.I wonder if we should have a spec text about this behavior in the speculation rules spec.
AddPrerenderAsync(kPrerenderingUrl);`AddPrerender()` should work without `PrerenderHostRegistryObserver`
```
int host_id = AddPrerender(kPrerenderingUrl);
```
Also, `AddPrerender()` internally calls `WaitForPrerenderLoadCompletion()`, so you don't need to call it explicitly.
EXPECT_TRUE(ExecJs(web_contents(), ""));qq: What happens when the initiator page is unexpectedly closed? Does `ExecJs()` return false or crash?
Related details
- Huanpo Lin
- Rakina Zata Amni
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Huanpo Lin (Gerrit)
Huanpo Lin added 3 comments![]( "Open in Gerrit")
for more details.I wonder if we should have a spec text about this behavior in the speculation rules spec.
I think yes, is there any guidance about how to update the spec(?
`AddPrerender()` should work without `PrerenderHostRegistryObserver`
```
int host_id = AddPrerender(kPrerenderingUrl);
```Also, `AddPrerender()` internally calls `WaitForPrerenderLoadCompletion()`, so you don't need to call it explicitly.
Updated, thanks.
EXPECT_TRUE(ExecJs(web_contents(), ""));qq: What happens when the initiator page is unexpectedly closed? Does `ExecJs()` return false or crash?
It returns false with the error message `(a JavaScript error: "RenderFrame deleted."`. It doesn't crash.
https://source.chromium.org/chromium/chromium/src/+/main:content/public/test/browser_test_utils.h;l=954?q=ExecJs
Related details
- Hiroki Nakagawa
- Rakina Zata Amni
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Huanpo Lin (Gerrit)
Huanpo Lin added 1 comment![]( "Open in Gerrit")
include caseq@ for reviewing `third_party/blink/public/devtools_protocol/browser_protocol.pdl`
Related details
- Andrey Kosyakov
- Hiroki Nakagawa
- Rakina Zata Amni
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hiroki Nakagawa (Gerrit)
Hiroki Nakagawa voted and added 2 comments![]( "Open in Gerrit")
Votes added by Hiroki Nakagawa
| Code-Review | +1 |
2 comments
for more details.Huanpo LinI wonder if we should have a spec text about this behavior in the speculation rules spec.
I think yes, is there any guidance about how to update the spec(?
Basically you are expected to file a spec issue in https://github.com/WICG/nav-speculation/ and then write a PR like other PRs on the repository. I think domenic@ may know the definitive guide for newcomers. Can you reach out to him?
EXPECT_TRUE(ExecJs(web_contents(), ""));Huanpo Linqq: What happens when the initiator page is unexpectedly closed? Does `ExecJs()` return false or crash?
It returns false with the error message `(a JavaScript error: "RenderFrame deleted."`. It doesn't crash.
https://source.chromium.org/chromium/chromium/src/+/main:content/public/test/browser_test_utils.h;l=954?q=ExecJs
- Andrey Kosyakov
- Huanpo Lin
- Rakina Zata Amni
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rakina Zata Amni (Gerrit)
Rakina Zata Amni added 1 comment![]( "Open in Gerrit")
// For prerendered pages, if window.close is called, it should be cancelled.From `ClosePageSource`, it looks like this function can also be called because the browser/tab is shutting down. Do you want to differentiate or exclude those cases maybe?
Related details
- Andrey Kosyakov
- Huanpo Lin
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Domenic Denicola (Gerrit)
Domenic Denicola added 1 comment![]( "Open in Gerrit")
Bug: 348232620It might be good to have a separate bug for this feature in particular, just so we can more accurately and publicly track all the different workstreams blocking this meta bug.
Related details
- Andrey Kosyakov
- Huanpo Lin
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Domenic Denicola (Gerrit)
Domenic Denicola added 1 comment![]( "Open in Gerrit")
preloading: Cancel prerendering if window.closed is calledclosed -> close