Allow inline-level scroll markers. [chromium/src : main]
0 views
Skip to first unread message
Morten Stenshorne (Gerrit)
Nov 12, 2024, 1:20:35 PMNov 12
to Rune Lillesveen, Daniil Sakhapov, Tricium, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Daniil Sakhapov and Rune Lillesveen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Daniil Sakhapov
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Nov 12, 2024, 1:38:10 PMNov 12
to Morten Stenshorne, Rune Lillesveen, Tricium, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne and Rune Lillesveen
Daniil Sakhapov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniil Sakhapov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Morten Stenshorne
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniil Sakhapov (Gerrit)
Nov 12, 2024, 1:38:24 PMNov 12
to Morten Stenshorne, Rune Lillesveen, Tricium, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne and Rune Lillesveen
Daniil Sakhapov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Daniil Sakhapov . resolved
feels like a
Daniil Sakhapov
woops, bad ui, sorry
Rune Lillesveen (Gerrit)
Nov 13, 2024, 4:55:31 AMNov 13
to Morten Stenshorne, Rune Lillesveen, Daniil Sakhapov, Tricium, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Morten Stenshorne
Rune Lillesveen voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Nov 13, 2024, 6:02:05 AMNov 13
to Rune Lillesveen, Daniil Sakhapov, Tricium, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Morten Stenshorne voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 13, 2024, 6:05:47 AMNov 13
to Morten Stenshorne, Rune Lillesveen, Daniil Sakhapov, Tricium, Alexis Menard, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[carousel] Allow inline-level scroll markers.
We used to unconditionally blockify all scroll markers, due to
implementation limitations. But we should only blockify them if the real
layout parent requires it (e.g. if the scroll marker group is a flex or
grid container).
To fix this, wrap inline-level scroll markers inside an anonymous block,
since our child fragment mutation code cannot handle inline-level
children.
We already had such an anonymous block wrapper mechanism in place, since
it's also needed by multicol. Tidy up the code a little bit. There was
an AllowsInlineChildren() which didn't really do exactly what it
suggested (it would disqualify anonymous blocks because that was fine at
the sole call site). Also no need to check for IsLayoutNGObject().
That's legacy layout cleanup residue.
Update the expectations of three existing tests, since they depended on
incorrect blockification.
There are existing tests that have scroll marker groups as flex
containers, which still get their scroll markers blockified, as they
should. One such test is
wpt_internal/css/css-overflow/scroll-marker-002.html
There's one remaining thing to fix here: AdjustStyleForDisplay() is
still invoked during style calculation of scroll markers, but at that
point it will use the originating element as the layout parent, which
might lead to unwanted blockification (e.g. if the originating element
has display:flex, but the scroll marker group is a regular block
container). Will fix this in a follow-up.
Bug: 376834376
Change-Id: I5e8b1e604f9b501212722c9b409dad4266600c92
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Reviewed-by: Daniil Sakhapov <sakh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382247}
Files:
- M third_party/blink/renderer/core/css/resolver/style_adjuster.cc
- M third_party/blink/renderer/core/css/resolver/style_adjuster.h
- M third_party/blink/renderer/core/dom/pseudo_element.cc
- M third_party/blink/renderer/core/dom/pseudo_element.h
- M third_party/blink/renderer/core/dom/scroll_marker_group_pseudo_element.cc
- M third_party/blink/renderer/core/layout/layout_block_flow.cc
- M third_party/blink/renderer/core/layout/physical_box_fragment.h
- A third_party/blink/web_tests/wpt_internal/css/css-overflow/column-scroll-marker-008.html
- M third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-001-ref.html
- M third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-003-ref.html
- M third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-010-ref.html
- A third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-011-ref.html
- A third_party/blink/web_tests/wpt_internal/css/css-overflow/scroll-marker-011.html
Change size: M
Delta: 13 files changed, 124 insertions(+), 47 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniil Sakhapov, +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages