[APC] Return WebElement unavailable reasons [chromium/src : main]

0 views
Skip to first unread message

Nan Lin (Gerrit)

unread,
Jul 1, 2026, 5:22:14 PM (5 days ago) Jul 1
to Aaron Leventhal, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Aaron Leventhal

Nan Lin voted and added 4 comments

Votes added by Nan Lin

Code-Review+1

4 comments

File chrome/renderer/actor/click_tool.cc
Line 202, Patchset 8 (Latest): !element.IsNull() && element.GetUnavailableReason()) {
Nan Lin . unresolved

Consider using `.has_value()` here to make it explicitly clear to readers that `GetUnavailableReason()` returns an optional rather than a boolean.

```suggestion
        !element.IsNull() && element.GetUnavailableReason().has_value()) {
```
File chrome/renderer/actor/tool_base.cc
Line 163, Patchset 8 (Latest): if (element.GetUnavailableReason()) {
Nan Lin . unresolved

Consider using `.has_value()` for clarity.

```suggestion
  if (element.GetUnavailableReason().has_value()) {
```
File third_party/blink/renderer/core/exported/web_element.cc
Line 113, Patchset 8 (Latest): return EqualIgnoringAsciiCase(role, keywords::kPresentation) ||
EqualIgnoringAsciiCase(role, keywords::kNone);
Nan Lin . unresolved

Can we revert this change?

Line 345, Patchset 8 (Latest): if (GetUnavailableReason()) {
Nan Lin . unresolved

Consider using `.has_value()` for clarity.

```suggestion
  if (GetUnavailableReason().has_value()) {
```
Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
Gerrit-Change-Number: 8025201
Gerrit-PatchSet: 8
Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
Gerrit-Attention: Aaron Leventhal <aleve...@google.com>
Gerrit-Comment-Date: Wed, 01 Jul 2026 21:22:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Jul 1, 2026, 6:28:12 PM (5 days ago) Jul 1
to Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Nan Lin

Aaron Leventhal added 4 comments

File chrome/renderer/actor/click_tool.cc
Line 202, Patchset 9 (Latest): !element.IsNull() && element.GetUnavailableReason().has_value()) {
Aaron Leventhal . resolved

Done.

File chrome/renderer/actor/tool_base.cc
Line 163, Patchset 9 (Latest): if (element.GetUnavailableReason().has_value()) {
Aaron Leventhal . unresolved

Done.

File third_party/blink/renderer/core/exported/web_element.cc
Line 113, Patchset 8: return EqualIgnoringAsciiCase(role, keywords::kPresentation) ||
EqualIgnoringAsciiCase(role, keywords::kNone);
Nan Lin . resolved

Can we revert this change?

Aaron Leventhal

Done

Line 345, Patchset 8: if (GetUnavailableReason()) {
Nan Lin . resolved

Consider using `.has_value()` for clarity.

```suggestion
  if (GetUnavailableReason().has_value()) {
```
Aaron Leventhal

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Nan Lin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
Gerrit-Change-Number: 8025201
Gerrit-PatchSet: 9
Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
Gerrit-Attention: Nan Lin <lin...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Jul 2026 22:28:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nan Lin <lin...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Jul 1, 2026, 6:28:38 PM (5 days ago) Jul 1
to Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Nan Lin

Aaron Leventhal added 1 comment

File chrome/renderer/actor/tool_base.cc
Line 163, Patchset 9 (Latest): if (element.GetUnavailableReason().has_value()) {
Aaron Leventhal . resolved

Done.

Aaron Leventhal

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Nan Lin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
    Gerrit-Change-Number: 8025201
    Gerrit-PatchSet: 9
    Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Attention: Nan Lin <lin...@chromium.org>
    Gerrit-Comment-Date: Wed, 01 Jul 2026 22:28:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Aaron Leventhal <aleve...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Aaron Leventhal (Gerrit)

    unread,
    9:51 AM (6 hours ago) 9:51 AM
    to Dave Tapuska, Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Dave Tapuska and Nan Lin

    Aaron Leventhal voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dave Tapuska
    • Nan Lin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
    Gerrit-Change-Number: 8025201
    Gerrit-PatchSet: 9
    Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Comment-Date: Mon, 06 Jul 2026 13:51:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dave Tapuska (Gerrit)

    unread,
    10:03 AM (6 hours ago) 10:03 AM
    to Aaron Leventhal, Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
    Attention needed from Aaron Leventhal and Nan Lin

    Dave Tapuska added 2 comments

    File third_party/blink/public/web/web_element.h
    Line 131, Patchset 9 (Latest): std::optional<WebElementUnavailableReason> GetUnavailableReason();
    Dave Tapuska . unresolved

    Maybe just InteractionDisallowedReason?

    Line 56, Patchset 9 (Latest):enum class WebElementUnavailableReason {
    Dave Tapuska . unresolved

    Can we make this more specific like WebElementInteractionDisallowedReason?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Aaron Leventhal
    • Nan Lin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
      Gerrit-Change-Number: 8025201
      Gerrit-PatchSet: 9
      Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
      Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
      Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
      Gerrit-Attention: Aaron Leventhal <aleve...@google.com>
      Gerrit-Attention: Nan Lin <lin...@chromium.org>
      Gerrit-Comment-Date: Mon, 06 Jul 2026 14:03:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Aaron Leventhal (Gerrit)

      unread,
      1:54 PM (2 hours ago) 1:54 PM
      to Dave Tapuska, Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
      Attention needed from Dave Tapuska and Nan Lin

      Aaron Leventhal voted and added 3 comments

      Votes added by Aaron Leventhal

      Auto-Submit+1

      3 comments

      Patchset-level comments
      File-level comment, Patchset 10 (Latest):
      Aaron Leventhal . resolved

      Thanks for the review Dave, PTAL

      File third_party/blink/public/web/web_element.h
      Line 131, Patchset 9: std::optional<WebElementUnavailableReason> GetUnavailableReason();
      Dave Tapuska . resolved

      Maybe just InteractionDisallowedReason?

      Aaron Leventhal

      Done

      Line 56, Patchset 9:enum class WebElementUnavailableReason {
      Dave Tapuska . resolved

      Can we make this more specific like WebElementInteractionDisallowedReason?

      Aaron Leventhal

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Dave Tapuska
      • Nan Lin
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
        Gerrit-Change-Number: 8025201
        Gerrit-PatchSet: 10
        Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
        Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Comment-Date: Mon, 06 Jul 2026 17:53:59 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Dave Tapuska (Gerrit)

        unread,
        1:56 PM (2 hours ago) 1:56 PM
        to Aaron Leventhal, Nan Lin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
        Attention needed from Aaron Leventhal and Nan Lin

        Dave Tapuska voted

        Code-Review+1
        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Aaron Leventhal
        • Nan Lin
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
        Gerrit-Change-Number: 8025201
        Gerrit-PatchSet: 10
        Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
        Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
        Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Aaron Leventhal <aleve...@google.com>
        Gerrit-Attention: Nan Lin <lin...@chromium.org>
        Gerrit-Comment-Date: Mon, 06 Jul 2026 17:55:55 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Nan Lin (Gerrit)

        unread,
        1:57 PM (2 hours ago) 1:57 PM
        to Aaron Leventhal, Dave Tapuska, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium LUCI CQ, blink-re...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org
        Attention needed from Aaron Leventhal

        Nan Lin voted and added 1 comment

        Votes added by Nan Lin

        Code-Review+1

        1 comment

        Commit Message
        Line 7, Patchset 10 (Latest):[APC] Return WebElement unavailable reasons
        Nan Lin . unresolved

        Please update the cl description to use interaction disallowed reason.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Aaron Leventhal
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I295c3401dc1f265d5b66df67035dd8e6fd480952
          Gerrit-Change-Number: 8025201
          Gerrit-PatchSet: 10
          Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
          Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
          Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
          Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
          Gerrit-Attention: Aaron Leventhal <aleve...@google.com>
          Gerrit-Comment-Date: Mon, 06 Jul 2026 17:56:58 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages