Fix asymmetric bounds check in `ForEachGraphemeClusters` [chromium/src : main]
1 view
Skip to first unread message
Koji Ishii (Gerrit)
May 25, 2026, 11:16:45 PM (4 hours ago) May 25
to Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, mac-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
May 25, 2026, 11:23:14 PM (4 hours ago) May 25
to Koji Ishii, Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, mac-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Kent Tamura . resolved
This includes some unrelated *-expected.txt files, but it's acceptable.
Related details
Attention is currently required from:
- Koji Ishii
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Koji Ishii (Gerrit)
1:04 AM (2 hours ago) 1:04 AM
to Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, mac-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Koji Ishii voted and added 1 comment![]( "Open in Gerrit")
Votes added by Koji Ishii
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Kent Tamura . resolved
This includes some unrelated *-expected.txt files, but it's acceptable.
Koji Ishii
oh, right, thanks for catching. let's not ask you to re-+1, landing.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:08 AM (2 hours ago) 1:08 AM
to Koji Ishii, Kent Tamura, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, devtools-re...@chromium.org, mac-r...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix asymmetric bounds check in `ForEachGraphemeClusters`
This patch fixes `ForEachGraphemeClusters` to check both lower
and upper boundaries. Before the change, it was checking only
the left side boundary, and thus it could iterate beyond
given `to` in LTR, so long as the `ShapeResult` has such
cluster indexes.
With the fix, the iteration is limited within the given `from`
and `to`.
The `emphasis.html` is rebasedlined, as it was rendering
emphasis marks twice; once normally and another by excess
rendering when painting the selection.
Fixed: 498085466
Change-Id: Ic31c3544e035145e32552595389bd269775ec91c
Auto-Submit: Koji Ishii <ko...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Reviewed-by: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1635934}
Files:
- M third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
- M third_party/blink/renderer/platform/fonts/shaping/shape_result_test.cc
- M third_party/blink/renderer/platform/fonts/shaping/shape_result_view.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/platform/linux/virtual/text-antialias/selection/emphasis-expected.png
- A third_party/blink/web_tests/platform/mac-mac12/inspector-protocol/emulation/device-emulation-device-posture-expected.txt
- M third_party/blink/web_tests/platform/mac-mac14-arm64/virtual/text-antialias/selection/emphasis-expected.png
- M third_party/blink/web_tests/platform/mac-mac14/virtual/text-antialias/selection/emphasis-expected.png
- M third_party/blink/web_tests/platform/mac/virtual/text-antialias/selection/emphasis-expected.png
- M third_party/blink/web_tests/platform/win/virtual/text-antialias/selection/emphasis-expected.png
- A third_party/blink/web_tests/platform/win11-arm64/external/wpt/fetch/fetch-later/new-window.https.window-expected.txt
- A third_party/blink/web_tests/platform/win11-arm64/external/wpt/visual-viewport/page-and-offset-in-iframe-expected.txt
Change size: M
Delta: 12 files changed, 103 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kent Tamura
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages