Revert "[soft navs] Refactor pending ICP entry buffering" [chromium/src : main]
0 views
Skip to first unread message
Scott Haseley (Gerrit)
Dec 18, 2025, 8:47:42 PM (2 days ago) Dec 18
to Johannes Henkel, Rubber Stamper, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Dec 18, 2025, 8:48:18 PM (2 days ago) Dec 18
to Scott Haseley, Johannes Henkel, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
Message from Rubber Stamper![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Johannes Henkel (Gerrit)
Dec 18, 2025, 8:51:59 PM (2 days ago) Dec 18
to Scott Haseley, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Attention needed from Michal Mocny and Scott Haseley
Johannes Henkel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Michal Mocny
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
Dec 18, 2025, 8:55:16 PM (2 days ago) Dec 18
to Johannes Henkel, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Attention needed from Michal Mocny
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Scott Haseley . resolved
Thanks! Hoping to get this into Canary tonight to show this wasn't a problem, then can reland.
Related details
Attention is currently required from:
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 18, 2025, 9:34:42 PM (2 days ago) Dec 18
to Scott Haseley, Johannes Henkel, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[soft navs] Refactor pending ICP entry buffering"
This reverts commit abe0507666c40f9ebd93498eaf2a76f4ddabadf5.
Reason for revert: The prerequisite for this patch was speculatively
reverted for crbug.com/469686890. It's very unlikely that reverting
that will fix the issue, but since this depends on the reverted patch,
this should be reverted to rule out this causing a problem.
Original change's description:
> [soft navs] Refactor pending ICP entry buffering
>
> Currently, SoftNavigationContext tracks the current largest text and
> image records, and uses those to emit the ICP performance entry and
> update metrics if and when the soft navigation entry is emitted. This CL
> changes this flow so that now we track the latest un-emitted
> InteractionContentfulPaint object and emit that directly. To do this,
> the LCP calculator continuously updates its state and calls the Delegate
> EmitPerformanceEntry method, but actual ICP emission is guarded there,
> where we either create and emit it synchronously or buffer it for later.
>
> This is being done because:
> 1. To unify ICP and LCP and to better control lifetime of
> PaintTimingRecords (in advance of strongifying some of its fields),
> we want to move the largest text and image tracking into the LCP
> calculator. We don't plan to expose these values, as the records
> themselves shouldn't be persisted beyond getting presentation
> feedback, but SNC needs to buffer the latest candidate indefinitely.
>
> 2. We plan to guarantee the Node and MediaObject are alive through this
> callback, which might not be the case now if the node is removed,
> and capturing the state here ensures we have what we need for
> emission.
>
> Bug: 454082771, 454082773
> Change-Id: I093d37960f774e5ca8946d8a0aa27cd9d592125f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120640
> Reviewed-by: Michal Mocny <mmo...@chromium.org>
> Commit-Queue: Scott Haseley <shas...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1559386}
Bug: 454082771, 454082773
Change-Id: I2067245e984a90b0046f9f41f6ddbd02a748e653
Reviewed-by: Johannes Henkel <joha...@chromium.org>
Commit-Queue: Scott Haseley <shas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1560971}
Files:
- M third_party/blink/renderer/core/timing/soft_navigation_context.cc
- M third_party/blink/renderer/core/timing/soft_navigation_context.h
- M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
- M third_party/blink/renderer/core/timing/soft_navigation_heuristics.h
- M third_party/blink/renderer/core/timing/window_performance.cc
- M third_party/blink/renderer/core/timing/window_performance.h
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/late-url-change.html
Change size: L
Delta: 7 files changed, 103 insertions(+), 151 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johannes Henkel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Dec 18, 2025, 11:09:47 PM (2 days ago) Dec 18
to Scott Haseley, Chromium LUCI CQ, Johannes Henkel, Michal Mocny, AyeAye, chromium...@chromium.org, blink-...@chromium.org, speed-metrics...@chromium.org, core-timi...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56874
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages