Add RestrictBackgroundFetchFromServiceWorkerEnabled enterprise policy [chromium/src : main]
1 view
Skip to first unread message
Yoshisato Yanagisawa (Gerrit)
May 24, 2026, 8:07:48 PM (2 days ago) May 24
to Mike Taylor, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Mike Taylor and Victor Tan
Yoshisato Yanagisawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Yoshisato Yanagisawa
| Commit-Queue | +1 |
1 comment
File components/policy/resources/templates/policy_definitions/Miscellaneous/RestrictBackgroundFetchFromServiceWorkerEnabled.yaml
Line 20, Patchset 3:
- mike...@chromium.orgMike Taylor . resolved
Yoshisato YanagisawaWe should find a better owner than me... 😊
Updated.
Related details
Attention is currently required from:
- Igor Ruvinov
- Mike Taylor
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
May 24, 2026, 8:45:23 PM (2 days ago) May 24
to Mike Taylor, Yoshisato Yanagisawa, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Mike Taylor, Victor Tan and Yoshisato Yanagisawa
Shunya Shishido voted and added 2 comments![]( "Open in Gerrit")
Votes added by Shunya Shishido
| Code-Review | +1 |
2 comments
Patchset-level comments
File components/policy/resources/templates/policy_definitions/Miscellaneous/RestrictBackgroundFetchFromServiceWorkerEnabled.yaml
Line 25, Patchset 11 (Latest):
- chrome.*:150-
- chrome_os:150-
- android:150-Shunya Shishido . unresolved
Let's replace it with 149.
Related details
Attention is currently required from:
- Igor Ruvinov
- Mike Taylor
- Victor Tan
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
May 24, 2026, 8:53:51 PM (2 days ago) May 24
to Mike Taylor, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Mike Taylor and Victor Tan
Yoshisato Yanagisawa added 1 comment![]( "Open in Gerrit")
File components/policy/resources/templates/policy_definitions/Miscellaneous/RestrictBackgroundFetchFromServiceWorkerEnabled.yaml
Line 25, Patchset 11:
- chrome.*:150-
- chrome_os:150-
- android:150-Shunya Shishido . resolved
Let's replace it with 149.
Yoshisato Yanagisawa
I am not sure if it is feasible but let's give it a shot.
Related details
Attention is currently required from:
- Igor Ruvinov
- Mike Taylor
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
May 24, 2026, 9:55:08 PM (2 days ago) May 24
to Mike Taylor, Kentaro Hara, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Kentaro Hara, Mike Taylor and Victor Tan
Yoshisato Yanagisawa added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Igor Ruvinov
- Kentaro Hara
- Mike Taylor
- Victor Tan
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
May 24, 2026, 10:00:46 PM (2 days ago) May 24
to Mike Taylor, Yoshisato Yanagisawa, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Mike Taylor, Victor Tan and Yoshisato Yanagisawa
Kentaro Hara voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kentaro Hara
| Code-Review | +1 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Kentaro Hara . resolved
LGTM. Setting an OO bit as an emergency fix as discussed offline.
Related details
Attention is currently required from:
- Igor Ruvinov
- Mike Taylor
- Victor Tan
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Yoshisato Yanagisawa (Gerrit)
May 24, 2026, 10:37:06 PM (2 days ago) May 24
to Mike Taylor, Kentaro Hara, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Igor Ruvinov, Mike Taylor and Victor Tan
Yoshisato Yanagisawa voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Igor Ruvinov
- Mike Taylor
- Victor Tan
Chromium LUCI CQ (Gerrit)
May 24, 2026, 10:41:39 PM (2 days ago) May 24
to Mike Taylor, Kentaro Hara, Yoshisato Yanagisawa, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add RestrictBackgroundFetchFromServiceWorkerEnabled enterprise policy
Introduces the RestrictBackgroundFetchFromServiceWorkerEnabled policy to
allow administrators to enable Background Fetch from Service Workers.
Background Fetch from Service Workers is restricted by default to
enhance security. This policy provides administrators with the ability
to explicitly allow this functionality within their organization.
Bug: 40062121
Change-Id: Idb708d3dcbc77fde071b4f3213e8df77a11d0d99
Reviewed-by: Kentaro Hara <har...@chromium.org>
Owners-Override: Kentaro Hara <har...@chromium.org>
Reviewed-by: Victor Tan <vict...@chromium.org>
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyana...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1635583}
Files:
- M chrome/browser/chrome_content_browser_client.cc
- M chrome/browser/policy/BUILD.gn
- M chrome/browser/policy/configuration_policy_handler_list_factory.cc
- A chrome/browser/policy/test/restrict_background_fetch_policy_browsertest.cc
- M chrome/test/data/background_fetch/background_fetch.js
- M chrome/test/data/background_fetch/sw.js
- M components/policy/core/common/policy_pref_names.h
- M components/policy/resources/templates/policies.yaml
- A components/policy/resources/templates/policy_definitions/Miscellaneous/RestrictBackgroundFetchFromServiceWorkerEnabled.yaml
- A components/policy/test/data/pref_mapping/RestrictBackgroundFetchFromServiceWorkerEnabled.json
- M third_party/blink/common/switches.cc
- M third_party/blink/public/common/switches.h
- M third_party/blink/renderer/modules/background_fetch/DEPS
- M third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
- M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
- M tools/metrics/histograms/metadata/enterprise/enums.xml
Change size: L
Delta: 16 files changed, 244 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Victor Tan, +1 by Kentaro Hara, +1 by Shunya Shishido
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
May 25, 2026, 5:04:19 AM (22 hours ago) May 25
to Chromium LUCI CQ, Mike Taylor, Kentaro Hara, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Yoshisato Yanagisawa added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Yoshisato Yanagisawa . resolved
@igorr...@chromium.org Please let us know if there is any issues from the enterprise policy perspective.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Igor Ruvinov (Gerrit)
May 25, 2026, 3:53:34 PM (11 hours ago) May 25
to Chromium LUCI CQ, Mike Taylor, Kentaro Hara, Yoshisato Yanagisawa, Shunya Shishido, Enterprise Policy Reviews, Victor Tan, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Mike Taylor
Igor Ruvinov added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Yoshisato Yanagisawa . resolved
@igorr...@chromium.org Please let us know if there is any issues from the enterprise policy perspective.
Igor Ruvinov
Looks good overall, just a couple of comments that can be addressed in a follow-up CL (no need to merge them back to 149).
File components/policy/resources/templates/policy_definitions/Miscellaneous/RestrictBackgroundFetchFromServiceWorkerEnabled.yaml
Line 4, Patchset 13 (Latest):
This policy controls whether background fetch requests from Service Workers are restricted. If a feature that downloads files in the background is affected, this policy may be relevant.
If this policy is set to Enabled, or left unset, the restriction is active, and background fetch requests from Service Worker contexts may be blocked.
If this policy is set to Disabled, the restriction is bypassed, allowing all Service Workers to make background fetch requests.Igor Ruvinov . unresolved
Nit: Please add empty lines between sections / paragraphs, otherwise the text will be grouped into one block.
```suggestion
This policy controls whether background fetch requests from Service Workers are restricted. If a feature that downloads files in the background is affected, this policy may be relevant.
If this policy is set to Enabled, or left unset, the restriction is active, and background fetch requests from Service Worker contexts may be blocked.
If this policy is set to Disabled, the restriction is bypassed, allowing all Service Workers to make background fetch requests.
```
Line 16, Patchset 13 (Latest):
- caption: 'Default: Background Fetch restriction depends on browser defaults and field trials.'Igor Ruvinov . unresolved
The default policy value refers to the stable value after the underlying feature is rolled out, so it should be independent of Finch trials. From the policy description it seems like the feature will behave as if enabled when the policy is unset, so I'd remove this `null` value and update the default to `true`
Related details
Attention is currently required from:
- Mike Taylor
Yoshisato Yanagisawa (Gerrit)
May 25, 2026, 9:55:23 PM (5 hours ago) May 25
to Chromium LUCI CQ, Mike Taylor, Kentaro Hara, Shunya Shishido, Enterprise Policy Reviews, Igor Ruvinov, Victor Tan, Chromium Metrics Reviews, chromium...@chromium.org, Peter Beverloo, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dibyapal+wa...@chromium.org, kinuko...@chromium.org, nator...@chromium.org, rayanka...@chromium.org
Attention needed from Mike Taylor
Yoshisato Yanagisawa added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Yoshisato Yanagisawa . resolved
Comments are addressed in https://chromium-review.googlesource.com/c/chromium/src/+/7867400. Please take a look.
Reply all
Reply to author
Forward
0 new messages