Saqlain (Gerrit)

unread,

Jun 14, 2025, 4:17:59 PMJun 14

to Chromium LUCI CQ, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Alvin Ji and Michael Wilson

Saqlain added 1 comment

Patchset-level comments

File-level comment, Patchset 1:

Saqlain . resolved

FYI: `audionodeoptions.js` file was not being used even in old test file. so I removed it

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Michael Wilson

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alvin Ji (Gerrit)

unread,

Jun 16, 2025, 5:20:25 PMJun 16

to Saqlain, Chromium LUCI CQ, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Michael Wilson and Saqlain

Alvin Ji added 2 comments

File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html

Line 71, Patchset 2 (Latest):

        for (const entry of tests) {
          for (const testItem of entry.tests) {
            const options = {};
            options[entry.attribute] = testItem.value;

Alvin Ji . unresolved

For better readability, perhaps:
```
        for (const attributeTest of attributeTests) {
          for (const testOption of attributeTest.testOptions) {
            const options = {};
            options[attributeTest.attribute] = testOption.value;
```

Line 94, Patchset 2 (Latest): }, "ConvolverNode: test AudioNodeOptions");

Alvin Ji . unresolved

nit: Perhaps be more descriptive "ConvolverNode constructor: AudioNodeOptions are correctly handled"

Open in Gerrit

Related details

Attention is currently required from:

Michael Wilson
Saqlain

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Wilson (Gerrit)

unread,

Jun 17, 2025, 6:41:36 PMJun 17

to Saqlain, Chromium LUCI CQ, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Saqlain

Michael Wilson added 3 comments

File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html

Line 25, Patchset 2 (Parent): testInvalidConstructor(should, 'ConvolverNode', context);

Michael Wilson . unresolved

Let's add the two other conditions from this too.

Line 27, Patchset 2 (Latest):

        assert_equals(node.channelCountMode, "clamped-max", `${prefix}.channelCountMode`);
        assert_equals(node.channelInterpretation, "speakers", `${prefix}.channelInterpretation`);

Michael Wilson . unresolved

Nit: we should wrap these (and other) lines at 80 columns.

Line 79, Patchset 2 (Latest):

              if (testItem.error === TypeError) {
                assert_throws_js(TypeError, () => {
                  new ConvolverNode(context, options);
                }, desc);
              } else {
                assert_throws_dom(testItem.error, () => {
                  new ConvolverNode(context, options);
                }, desc);
              }

Michael Wilson . unresolved

I think these can be combined similarly to your other CL, what do you think?

Open in Gerrit

Related details

Attention is currently required from:

Saqlain

Submit Requirements:

Code-Coverage

Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Saqlain (Gerrit)

unread,

Jun 18, 2025, 5:33:36 PMJun 18

to Chromium LUCI CQ, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Alvin Ji and Michael Wilson

Saqlain added 5 comments

File third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html

Line 25, Patchset 2 (Parent): testInvalidConstructor(should, 'ConvolverNode', context);

Michael Wilson . resolved

Let's add the two other conditions from this too.

Saqlain

Done

Line 27, Patchset 2: assert_equals(node.channelCountMode, "clamped-max", `${prefix}.channelCountMode`);


        assert_equals(node.channelInterpretation, "speakers", `${prefix}.channelInterpretation`);

Michael Wilson . resolved

Nit: we should wrap these (and other) lines at 80 columns.

Saqlain

Done

Line 71, Patchset 2: for (const entry of tests) {


          for (const testItem of entry.tests) {
            const options = {};
            options[entry.attribute] = testItem.value;

Alvin Ji . resolved

For better readability, perhaps:
```
        for (const attributeTest of attributeTests) {
          for (const testOption of attributeTest.testOptions) {
            const options = {};
            options[attributeTest.attribute] = testOption.value;
```

Saqlain

Done

Line 79, Patchset 2: if (testItem.error === TypeError) {


                assert_throws_js(TypeError, () => {
                  new ConvolverNode(context, options);
                }, desc);
              } else {
                assert_throws_dom(testItem.error, () => {
                  new ConvolverNode(context, options);
                }, desc);
              }

Michael Wilson . resolved

I think these can be combined similarly to your other CL, what do you think?

Saqlain

sure, I have combined it, in newer patch I have Defined createNode once so constructor call isolated in one place.

Line 94, Patchset 2: }, "ConvolverNode: test AudioNodeOptions");

Alvin Ji . resolved

nit: Perhaps be more descriptive "ConvolverNode constructor: AudioNodeOptions are correctly handled"

Saqlain

Done

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Michael Wilson

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Michael Wilson (Gerrit)

unread,

Jun 18, 2025, 6:15:12 PMJun 18

to Saqlain, Chromium LUCI CQ, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Alvin Ji and Saqlain

Michael Wilson voted and added 1 comment

Votes added by Michael Wilson

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Michael Wilson . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Saqlain

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alvin Ji (Gerrit)

unread,

Jun 20, 2025, 8:00:44 PMJun 20

to Saqlain, Chromium LUCI CQ, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Saqlain

Alvin Ji voted and added 1 comment

Votes added by Alvin Ji

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alvin Ji . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Saqlain

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Saqlain (Gerrit)

unread,

Jun 20, 2025, 10:15:11 PMJun 20

to Alvin Ji, Chromium LUCI CQ, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Saqlain voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jun 20, 2025, 10:44:53 PMJun 20

to Saqlain, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[webaudio] Migrate ctor-convolver.html from audit.js

This change migrates WebAudio tests from the custom `audit.js` framework
to the W3C-standard `testharness.js` specifically targeting dir
third_party/blink/web_tests/external/wpt/webaudio/the-audio-api
/the-convolvernode-interface/ctor-convolver.html, supporting Chromium's
ongoing effort to deprecate `audit.js` in favor of a more consistent
testing approach.

The following test files have been updated:
- ctor-convolver.html

Bug: 396477778

Change-Id: I43ff67966a2db727e44950f196a284e01b12e850

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6634364

Reviewed-by: Michael Wilson <mjwi...@chromium.org>

Reviewed-by: Alvin Ji <alv...@chromium.org>

Commit-Queue: Saqlain <2mesa...@gmail.com>

Cr-Commit-Position: refs/heads/main@{#1476858}

Files:

M third_party/blink/web_tests/external/wpt/webaudio/the-audio-api/the-convolvernode-interface/ctor-convolver.html

Change size: L

Delta: 1 file changed, 113 insertions(+), 152 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alvin Ji, +1 by Michael Wilson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Jun 20, 2025, 11:35:49 PMJun 20

to Saqlain, Chromium LUCI CQ, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/53310

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Patricia Rios guerra (Gerrit)

unread,

Jun 24, 2025, 6:06:59 AMJun 24

to Saqlain, Chromium LUCI CQ, Blink W3C Test Autoroller, Alvin Ji, Punith Nayak, chromium...@chromium.org, Hongchan Choi, blink-revie...@chromium.org, blink-...@chromium.org

Patricia Rios guerra added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Patricia Rios guerra . resolved

Open

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[webaudio] Migrate ctor-convolver.html from audit.js [chromium/src : main]

Saqlain (Gerrit)

Saqlain added 1 comment

Related details

Alvin Ji (Gerrit)

Alvin Ji added 2 comments

Related details

Michael Wilson (Gerrit)

Michael Wilson added 3 comments

Related details

Saqlain (Gerrit)

Saqlain added 5 comments

Related details

Michael Wilson (Gerrit)

Michael Wilson voted and added 1 comment

Votes added by Michael Wilson

1 comment

Related details

Alvin Ji (Gerrit)

Alvin Ji voted and added 1 comment

Votes added by Alvin Ji

1 comment

Related details

Saqlain (Gerrit)

Saqlain voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Patricia Rios guerra (Gerrit)

Patricia Rios guerra added 1 comment

Related details