Nektarios Paisios (Gerrit)

unread,

Apr 16, 2024, 6:18:01 PMApr 16

to Kyungjun Lee, Kevin Babbitt, chromium...@chromium.org, (Julie)Jeongeun Kim, aleventhal...@chromium.org, hirokisa...@chromium.org, ipc-securi...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, josiah...@chromium.org, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, dtseng...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org

Attention needed from Kyungjun Lee

Nektarios Paisios has uploaded the change for review

Nektarios Paisios would like Kyungjun Lee to review this change.

Commit message

Implements functionality that enables a11y actions to be performed on
the first object with a given role

Until now, if you wanted to perform an accessibility action
you needed to know the ID of the node on which you want
the action performed.
This patch enables functionality that allows the action to
be performed on the first object in the AX tree
(using pre-order traversal) with the given role.
This will enable actions to be performed on trees that are
present in Blink but not on the browser side.

This will enable the accessibility tree in the ChromeOS Media App
(aka Backlight) to be stitch into the first canvas found in the app's
contents.

AX-Relnotes: n/a.
R=kyung...@google.com
Bug: b/303133098
Change-Id: I81b431484c10de1b835381650d0bed68f82f2f05

Change diff

Change information

Files:

M content/renderer/accessibility/ax_action_target_factory.cc
M content/renderer/accessibility/ax_action_target_factory.h
M content/renderer/accessibility/render_accessibility_impl.cc
M third_party/blink/public/web/web_ax_object.h
M third_party/blink/renderer/core/accessibility/ax_object_cache.h
M third_party/blink/renderer/modules/accessibility/ax_object.cc
M third_party/blink/renderer/modules/accessibility/ax_object.h
M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
M third_party/blink/renderer/modules/exported/web_ax_object.cc
M ui/accessibility/ax_action_data.h
M ui/accessibility/mojom/ax_action_data.mojom
M ui/accessibility/mojom/ax_action_data_mojom_traits.cc
M ui/accessibility/mojom/ax_action_data_mojom_traits.h

Change size: M

Delta: 14 files changed, 67 insertions(+), 9 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Kyungjun Lee

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyungjun Lee (Gerrit)

unread,

Apr 17, 2024, 6:22:52 PMApr 17

to Nektarios Paisios, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Kyungjun Lee added 4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kyungjun Lee . resolved

Hi Nektarios, not sure if this CL is ready for review, but I went through it quickly and left my initial comments on it.

File content/renderer/accessibility/ax_action_target_factory.h

Line 31, Patchset 2 (Latest): static std::unique_ptr<ui::AXActionTarget> CreateFromNodeId(

Kyungjun Lee . unresolved

Should we possibly be renaming it to something like `CreateFromNodeIdOrRole()` for clarity? It seems that a relatively small number of lines are currently using this one as shown in [1].

[1] https://source.chromium.org/search?q=CreateFromNodeId%20-gen&sq=

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 5816, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ntraversing object\n" << object;

Kyungjun Lee . unresolved

nit: remove this logging

File third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Line 871, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ncalling into AXObject. " << role;

Kyungjun Lee . unresolved

nit: remove this logging

Open in Gerrit

Related details

Attention is currently required from:

Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nektarios Paisios (Gerrit)

unread,

Apr 18, 2024, 11:26:38 AMApr 18

to Chromium LUCI CQ, Kyungjun Lee, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Kyungjun Lee

Nektarios Paisios added 3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Nektarios Paisios . resolved

Yes it's ready for review

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 5816, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ntraversing object\n" << object;

Kyungjun Lee . resolved

nit: remove this logging

Nektarios Paisios

Done

File third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Line 871, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ncalling into AXObject. " << role;

Kyungjun Lee . resolved

nit: remove this logging

Nektarios Paisios

Done

Open in Gerrit

Related details

Attention is currently required from:

Kyungjun Lee

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nektarios Paisios (Gerrit)

unread,

Apr 18, 2024, 11:27:11 AMApr 18

to Chromium LUCI CQ, Kyungjun Lee, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Kyungjun Lee

Nektarios Paisios added 1 comment

File content/renderer/accessibility/ax_action_target_factory.h

Line 31, Patchset 2 (Latest): static std::unique_ptr<ui::AXActionTarget> CreateFromNodeId(

Kyungjun Lee . resolved

Should we possibly be renaming it to something like `CreateFromNodeIdOrRole()` for clarity? It seems that a relatively small number of lines are currently using this one as shown in [1].
[1] https://source.chromium.org/search?q=CreateFromNodeId%20-gen&sq=

Nektarios Paisios

Done

Open in Gerrit

Related details

Attention is currently required from:

Kyungjun Lee

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyungjun Lee (Gerrit)

unread,

Apr 18, 2024, 12:37:46 PMApr 18

to Nektarios Paisios, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Kyungjun Lee added 4 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Kyungjun Lee . resolved

Hi Nektarios, it seems that a new patchset hasn't been uploaded?

File content/renderer/accessibility/ax_action_target_factory.h

Line 31, Patchset 2 (Latest): static std::unique_ptr<ui::AXActionTarget> CreateFromNodeId(

Kyungjun Lee . unresolved

Should we possibly be renaming it to something like `CreateFromNodeIdOrRole()` for clarity? It seems that a relatively small number of lines are currently using this one as shown in [1].
[1] https://source.chromium.org/search?q=CreateFromNodeId%20-gen&sq=

Nektarios Paisios

Done

Kyungjun Lee

This one hasn't changed; maybe a new patch hasn't been uploaded yet?

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 5816, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ntraversing object\n" << object;

Kyungjun Lee . unresolved

nit: remove this logging

Nektarios Paisios

Done

Kyungjun Lee

ditto

File third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Line 871, Patchset 2 (Latest): LOG(ERROR) << "\nnektar\ncalling into AXObject. " << role;

Kyungjun Lee . unresolved

nit: remove this logging

Nektarios Paisios

Done

Kyungjun Lee

ditto

Open in Gerrit

Related details

Attention is currently required from:

Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Aaron Leventhal (Gerrit)

unread,

Apr 18, 2024, 12:55:56 PMApr 18

to Nektarios Paisios, Chromium LUCI CQ, Kyungjun Lee, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Aaron Leventhal added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Aaron Leventhal . resolved

Blink changes look ok.

Open in Gerrit

Related details

Attention is currently required from:

Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Apr 23, 2024, 2:30:08 PMApr 23

to Nektarios Paisios, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, Kyungjun Lee, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Joe Mason

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: joenot...@google.com

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): joenot...@google.com

Reviewer source(s):
joenot...@google.com is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Kyungjun Lee (Gerrit)

unread,

Apr 24, 2024, 12:04:35 PMApr 24

to Nektarios Paisios, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Joe Mason and Nektarios Paisios

Kyungjun Lee voted and added 4 comments

Votes added by Kyungjun Lee

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Kyungjun Lee . resolved

lgtm!

File content/renderer/accessibility/ax_action_target_factory.h

Line 31, Patchset 2: static std::unique_ptr<ui::AXActionTarget> CreateFromNodeId(

Kyungjun Lee . resolved

Should we possibly be renaming it to something like `CreateFromNodeIdOrRole()` for clarity? It seems that a relatively small number of lines are currently using this one as shown in [1].
[1] https://source.chromium.org/search?q=CreateFromNodeId%20-gen&sq=

Nektarios Paisios

Done

Kyungjun Lee

This one hasn't changed; maybe a new patch hasn't been uploaded yet?

Kyungjun Lee

Saw the latest patchset; resolved it.

File third_party/blink/renderer/modules/accessibility/ax_object.cc

Line 5816, Patchset 2: LOG(ERROR) << "\nnektar\ntraversing object\n" << object;

Kyungjun Lee . resolved

nit: remove this logging

Nektarios Paisios

Done

Kyungjun Lee

ditto

Kyungjun Lee

Done

File third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc

Line 871, Patchset 2: LOG(ERROR) << "\nnektar\ncalling into AXObject. " << role;

Kyungjun Lee . resolved

nit: remove this logging

Nektarios Paisios

Done

Kyungjun Lee

ditto

Kyungjun Lee

Done

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason
Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nektarios Paisios (Gerrit)

unread,

Apr 24, 2024, 12:11:35 PMApr 24

to Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Joe Mason

Nektarios Paisios added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Nektarios Paisios . resolved

@Joe Mason, is the current description enough, or do you need more informationh in order to review this patch?

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Apr 24, 2024, 5:33:39 PMApr 24

to Nektarios Paisios, Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Joe Mason added 1 comment

File ui/accessibility/mojom/ax_action_data.mojom

Line 35, Patchset 4 (Latest): [MinVersion=2] ax.mojom.Role target_role;

Joe Mason . unresolved

Nit: it would be better to use a union so that AXActionData always contains either an ID or a role (or neither). But since that would be cumbersome with versioning, how about returning `false` from StructTraits::Read in ax_action_data_mojom_traits.cc if both ID and role are set? That way mojo error handling will do the right thing if both are set.

Also please add a comment to the .mojom to document that they're mutually exclusive.

Open in Gerrit

Related details

Attention is currently required from:

Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nektarios Paisios (Gerrit)

unread,

Apr 24, 2024, 9:02:50 PMApr 24

to Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Joe Mason

Nektarios Paisios added 1 comment

File ui/accessibility/mojom/ax_action_data.mojom

Line 35, Patchset 4 (Latest): [MinVersion=2] ax.mojom.Role target_role;

Joe Mason . resolved

Nit: it would be better to use a union so that AXActionData always contains either an ID or a role (or neither). But since that would be cumbersome with versioning, how about returning `false` from StructTraits::Read in ax_action_data_mojom_traits.cc if both ID and role are set? That way mojo error handling will do the right thing if both are set.
Also please add a comment to the .mojom to document that they're mutually exclusive.

Nektarios Paisios

Done

Open in Gerrit

Related details

Attention is currently required from:

Joe Mason

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Apr 25, 2024, 10:51:40 AMApr 25

to Nektarios Paisios, Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Joe Mason voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Nektarios Paisios

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joe Mason (Gerrit)

unread,

Apr 25, 2024, 10:51:48 AMApr 25

to Nektarios Paisios, Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Nektarios Paisios

Joe Mason added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Joe Mason . resolved

Thanks!

satisfied_requirement

open

diffy

Nektarios Paisios (Gerrit)

unread,

Apr 25, 2024, 1:16:24 PMApr 25

to Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Nektarios Paisios voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 25, 2024, 1:24:28 PMApr 25

to Nektarios Paisios, Kyungjun Lee, Chromium IPC Reviews, Aaron Leventhal, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, aleventhal...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Implements functionality that enables a11y actions to be performed on
the first object with a given role

Until now, if you wanted to perform an accessibility action
you needed to know the ID of the node on which you want
the action performed.
This patch enables functionality that allows the action to
be performed on the first object in the AX tree
(using pre-order traversal) with the given role.
This will enable actions to be performed on trees that are
present in Blink but not on the browser side.

This will enable the accessibility tree in the ChromeOS Media App
(aka Backlight) to be stitch into the first canvas found in the app's
contents.

R=kyung...@google.com

AX-Relnotes: n/a.

Bug: b/303133098

Change-Id: I81b431484c10de1b835381650d0bed68f82f2f05

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5457961

Reviewed-by: Kyungjun Lee <kyung...@google.com>

Reviewed-by: Joe Mason <joenot...@google.com>

Commit-Queue: Nektarios Paisios <nek...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1292537}

Files:

M content/browser/accessibility/accessibility_action_browsertest.cc

M content/renderer/accessibility/ax_action_target_factory.cc
M content/renderer/accessibility/ax_action_target_factory.h
M content/renderer/accessibility/render_accessibility_impl.cc

M content/renderer/accessibility/render_accessibility_impl_browsertest.cc

M third_party/blink/public/web/web_ax_object.h
M third_party/blink/renderer/core/accessibility/ax_object_cache.h
M third_party/blink/renderer/modules/accessibility/ax_object.cc
M third_party/blink/renderer/modules/accessibility/ax_object.h
M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
M third_party/blink/renderer/modules/exported/web_ax_object.cc
M ui/accessibility/ax_action_data.h
M ui/accessibility/mojom/ax_action_data.mojom
M ui/accessibility/mojom/ax_action_data_mojom_traits.cc
M ui/accessibility/mojom/ax_action_data_mojom_traits.h

Change size: M

Delta: 16 files changed, 151 insertions(+), 35 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kyungjun Lee, +1 by Joe Mason

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Implements functionality that enables a11y actions to be performed on the first object with a given role [chromium/src : main]

Nektarios Paisios (Gerrit)

Nektarios Paisios has uploaded the change for review

Commit message

Change diff

Change information

Related details

Kyungjun Lee (Gerrit)

Kyungjun Lee added 4 comments

Related details

Nektarios Paisios (Gerrit)

Nektarios Paisios added 3 comments

Related details

Nektarios Paisios (Gerrit)

Nektarios Paisios added 1 comment

Related details

Kyungjun Lee (Gerrit)

Kyungjun Lee added 4 comments

Related details

Aaron Leventhal (Gerrit)

Aaron Leventhal added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Kyungjun Lee (Gerrit)

Kyungjun Lee voted and added 4 comments

Votes added by Kyungjun Lee

4 comments

Related details

Nektarios Paisios (Gerrit)

Nektarios Paisios added 1 comment

Related details

Joe Mason (Gerrit)

Joe Mason added 1 comment

Related details

Nektarios Paisios (Gerrit)

Nektarios Paisios added 1 comment

Related details

Joe Mason (Gerrit)

Joe Mason voted Code-Review+1

Related details

Joe Mason (Gerrit)

Joe Mason added 1 comment

Nektarios Paisios (Gerrit)

Nektarios Paisios voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information