Enable feature KeyboardFocusableScrollers to stable [chromium/src : main]

Di Zhang (Gerrit)

unread,

Oct 3, 2023, 3:58:35 PM10/3/23

to blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention is currently required from: Di Zhang.

Di Zhang uploaded patch set #2 to this change.

Enable feature KeyboardFocusableScrollers to stable

Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/jzMA5vUqNDs

All regressions and blocking concerns were fixed as part of M119. We are
now doing a slow rollout of the feature through Finch. Once M120 reach
stable, the feature should be fully enabled.

Change-Id: I601d567d9fabfa38e83ed327713eeaa9fbb1e904
Bug: 1040141
---
M third_party/blink/renderer/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Di Zhang (Gerrit)

unread,

Oct 3, 2023, 3:58:48 PM10/3/23

to Mason Freed, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, Aaron Leventhal

Attention is currently required from: Mason Freed.

Di Zhang would like Mason Freed to review this change.

View Change

Enable feature KeyboardFocusableScrollers to stable

Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/jzMA5vUqNDs

All regressions and blocking concerns were fixed as part of M119. We are
now doing a slow rollout of the feature through Finch. Once M120 reach
stable, the feature should be fully enabled.

Change-Id: I601d567d9fabfa38e83ed327713eeaa9fbb1e904
Bug: 1040141
---
M third_party/blink/renderer/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
index 3cb3519..cb91df6 100644
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -2154,7 +2154,7 @@
     },
     {
       name: "KeyboardFocusableScrollers",
-      status: "experimental",
+      status: "stable",
     },
     {
       name: "LangAttributeAwareFormControlUI",

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Di Zhang (Gerrit)

unread,

Oct 3, 2023, 3:58:55 PM10/3/23

to blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, Mason Freed, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Mason Freed.

Patch set 2:Commit-Queue +1

View Change

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Mason Freed (Gerrit)

unread,

Oct 4, 2023, 2:24:46 PM10/4/23

to Di Zhang, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Di Zhang.

Patch set 2:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #2:
  LGTM and good luck! 🎉

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Di Zhang (Gerrit)

unread,

Oct 4, 2023, 6:36:34 PM10/4/23

to blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, Mason Freed, Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org

Patch set 2:Commit-Queue +2

View Change

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 4, 2023, 7:57:32 PM10/4/23

to Di Zhang, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, Mason Freed, Aaron Leventhal, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Mason Freed: Looks good to me
  Di Zhang: Commit

Enable feature KeyboardFocusableScrollers to stable

Intent to ship:
https://groups.google.com/a/chromium.org/g/blink-dev/c/jzMA5vUqNDs

All regressions and blocking concerns were fixed as part of M119. We are
now doing a slow rollout of the feature through Finch. Once M120 reach
stable, the feature should be fully enabled.

Change-Id: I601d567d9fabfa38e83ed327713eeaa9fbb1e904
Bug: 1040141

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4864603
Commit-Queue: Di Zhang <dizh...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1205564}


---
M third_party/blink/renderer/platform/runtime_enabled_features.json5
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5
index 2cfcda1..1f394af 100644
--- a/third_party/blink/renderer/platform/runtime_enabled_features.json5
+++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -2190,7 +2190,7 @@


     },
     {
       name: "KeyboardFocusableScrollers",
-      status: "experimental",
+      status: "stable",
     },
     {
       name: "LangAttributeAwareFormControlUI",

To view, visit change 4864603. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward