[text-wrap-pretty] Add `NGLineWidths` [chromium/src : main]

Koji Ishii (Gerrit)

unread,

Jun 9, 2023, 11:35:10 AM6/9/23

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Patch set 4:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #3:
  Ian, PTAL, esp. exclusions logic, I don't have strong confidence on that part.

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Jun 9, 2023, 11:36:14 AM6/9/23

to Ian Kilpatrick, atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org

Attention is currently required from: Ian Kilpatrick.

Koji Ishii would like Ian Kilpatrick to review this change.

View Change

[text-wrap-pretty] Add `NGLineWidths`

This patch adds a class that computes the line width of each
line for an `NGInlineNode`. This class is a preparation to
support simple floating objects for `text-wrap: pretty`.

Currently, this class supports:
* Up to single exclusion.
* Inline content is simple; it must be rendered using single
  font, without non-initial `vertical-align`.

This patch has no behavior changes as the changes are called
only from unit tests. It will be used in following patches.

Bug: 1432798
Change-Id: I7f7d526d9659fa3cdffad210ccebd4f454e50b6f
---
M third_party/blink/renderer/core/layout/build.gni
M third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths.cc
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths.h
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths_test.cc
M third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
M third_party/blink/renderer/platform/fonts/shaping/shape_result.h
7 files changed, 326 insertions(+), 0 deletions(-)

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Jun 9, 2023, 11:36:19 AM6/9/23

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Attention is currently required from: Ian Kilpatrick.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Ian, can you PTAL, esp. exclusions logic? I don't have strong confidence on that part.

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Ian Kilpatrick (Gerrit)

unread,

Jun 12, 2023, 11:15:59 PM6/12/23

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Attention is currently required from: Koji Ishii.

Patch set 10:Code-Review +1

View Change

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Ian Kilpatrick (Gerrit)

unread,

Jun 12, 2023, 11:16:12 PM6/12/23

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Attention is currently required from: Koji Ishii.

View Change

1 comment:

Patchset:
- Patch Set #10:
  sorry for the slow review.

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Koji Ishii (Gerrit)

unread,

Jun 13, 2023, 12:49:37 AM6/13/23

to atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Patch set 10:Commit-Queue +2

View Change

1 comment:

Patchset:
- Patch Set #10:
  np, thanks for the review!

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 13, 2023, 12:55:06 AM6/13/23

to Koji Ishii, atotic+...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, dgrog...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, glebl+...@chromium.org, kinuko...@chromium.org, lchoi+...@chromium.org, pdr+graphi...@chromium.org, xiaochen...@chromium.org, zol...@webkit.org, Ian Kilpatrick, chromium...@chromium.org, Dirk Schulze, Stephen Chenney

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Ian Kilpatrick: Looks good to me
  Koji Ishii: Commit

[text-wrap-pretty] Add `NGLineWidths`

This patch adds a class that computes the line width of each
line for an `NGInlineNode`. This class is a preparation to
support simple floating objects for `text-wrap: pretty`.

Currently, this class supports:
* Up to single exclusion.
* Inline content is simple; it must be rendered using single
  font, without non-initial `vertical-align`.

This patch has no behavior changes as the changes are called
only from unit tests. It will be used in following patches.

Bug: 1432798
Change-Id: I7f7d526d9659fa3cdffad210ccebd4f454e50b6f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4603613
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1156703}


---
M third_party/blink/renderer/core/layout/build.gni
M third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.h
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths.cc
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths.h
A third_party/blink/renderer/core/layout/ng/inline/ng_line_widths_test.cc
M third_party/blink/renderer/platform/fonts/shaping/shape_result.cc
M third_party/blink/renderer/platform/fonts/shaping/shape_result.h

7 files changed, 333 insertions(+), 0 deletions(-)

To view, visit change 4603613. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward