webauthn: add a basic implementation of conditional create requests [chromium/src : main]
0 views
Skip to first unread message
Martin Kreichgauer (Gerrit)
Nov 11, 2024, 7:30:27 PMNov 11
to Martin Kreichgauer, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Adam Langley
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Adam Langley
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Langley (Gerrit)
Nov 12, 2024, 2:23:09 PMNov 12
to Martin Kreichgauer, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer
Adam Langley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Langley
| Code-Review | +1 |
1 comment
File chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
Line 1101, Patchset 4 (Latest):
UIPresentation::kPasskeyUpgrade) {Adam Langley . unresolved
Does this mean that other discoveries are active for conditional create? What if I tap a security key at just the right time?
Related details
Attention is currently required from:
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Nov 12, 2024, 5:03:17 PMNov 12
to Martin Kreichgauer, Ken Buchanan, Alex Moshchuk, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Alex Moshchuk and Ken Buchanan
Martin Kreichgauer added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Martin Kreichgauer . resolved
alexmos: Could you PTAL at //content/public changes?
kenrb: Could you LGTM for mojo and metrics?
File chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
Does this mean that other discoveries are active for conditional create? What if I tap a security key at just the right time?
Martin Kreichgauer
Yes. One of the many things that don't quite work yet as they should. :) Added a TODO just to call this out.
Related details
Attention is currently required from:
- Alex Moshchuk
- Ken Buchanan
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
Nov 12, 2024, 5:46:53 PMNov 12
to Martin Kreichgauer, Alex Moshchuk, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Alex Moshchuk and Martin Kreichgauer
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Ken Buchanan . resolved
lgtm
You should probably have the Android implementation return an error if the flag is turned on and a conditional create is attempted, possibly in a separate CL.
Related details
Attention is currently required from:
- Alex Moshchuk
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Nov 12, 2024, 6:14:28 PMNov 12
to Martin Kreichgauer, Kent Tamura, Ken Buchanan, Alex Moshchuk, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Alex Moshchuk and Kent Tamura
Martin Kreichgauer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Martin Kreichgauer . resolved
tkent@, could you please approve for runtime_enabled_features? Thank you!
Related details
Attention is currently required from:
- Alex Moshchuk
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Nov 12, 2024, 6:18:05 PMNov 12
to Martin Kreichgauer, Kent Tamura, Ken Buchanan, Alex Moshchuk, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Alex Moshchuk and Martin Kreichgauer
Kent Tamura voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex Moshchuk
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Moshchuk (Gerrit)
Nov 12, 2024, 10:28:03 PMNov 12
to Martin Kreichgauer, Kent Tamura, Ken Buchanan, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer
Alex Moshchuk voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Moshchuk
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Martin Kreichgauer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Martin Kreichgauer (Gerrit)
Nov 13, 2024, 1:29:10 PMNov 13
to Martin Kreichgauer, Alex Moshchuk, Kent Tamura, Ken Buchanan, Adam Langley, Chromium LUCI CQ, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Martin Kreichgauer voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 13, 2024, 1:34:20 PMNov 13
to Martin Kreichgauer, Alex Moshchuk, Kent Tamura, Ken Buchanan, Adam Langley, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
webauthn: add a basic implementation of conditional create requests
For WebAuthn create() requests with mediation='conditional', the browser
can create a credential and resolve the request promise without any user
interaction, if the user has previously agreed to create credentials and
the browser has recently mediated an authentication.
In Chrome's implementation, we create a credential in GPM if the
following conditions are true:
- The user has a matching password in GPM for the same username that can
be filled on the site making the WebAuthn request.
- The password has recently been used.
To handle conditional create requests, this change adds a new request
controller class that inherits from DocumentUserData. The request
controller is responsible for determining whether a matching password
exists, driving interaction with the enclave, and showing post-request
confirmation UI (not yet implemented).
The GPMEnclaveController, which usually drives enclave interactions for
WebAuthn requests, is not instantiated for conditional create requests,
since it is tightly coupled with the modal UI.
The implementation is gated on the default-disabled
`kWebAuthnGpmPasskeyUpgrade` feature flag.
Blink Intent To Prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/XFJmqtQpMds
Change-Id: I723ef3115cd00e39df721443a64df46fc0f38aea
Bug: 377758786
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Adam Langley <a...@chromium.org>
Reviewed-by: Ken Buchanan <ke...@chromium.org>
Commit-Queue: Martin Kreichgauer <mart...@google.com>
Reviewed-by: Alex Moshchuk <ale...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1382464}
Files:
- M chrome/browser/ui/BUILD.gn
- M chrome/browser/ui/views/webauthn/sheet_view_factory.cc
- A chrome/browser/ui/webauthn/passkey_upgrade_request_controller.cc
- A chrome/browser/ui/webauthn/passkey_upgrade_request_controller.h
- M chrome/browser/webauthn/authenticator_request_dialog_controller.cc
- M chrome/browser/webauthn/authenticator_request_dialog_controller.h
- M chrome/browser/webauthn/authenticator_request_dialog_model.cc
- M chrome/browser/webauthn/authenticator_request_dialog_model.h
- M chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
- M chrome/browser/webauthn/enclave_authenticator_browsertest.cc
- M components/webauthn/json/value_conversions_unittest.cc
- M content/browser/webauth/authenticator_common_impl.cc
- M content/browser/webauth/authenticator_request_outcome_enums.h
- M content/child/runtime_features.cc
- M content/public/browser/authenticator_request_client_delegate.h
- M device/fido/features.cc
- M device/fido/features.h
- M third_party/blink/public/mojom/webauthn/authenticator.mojom
- M third_party/blink/renderer/modules/credentialmanagement/authentication_credentials_container.cc
- M third_party/blink/renderer/modules/credentialmanagement/credential_creation_options.idl
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M tools/metrics/histograms/metadata/webauthn/enums.xml
Change size: L
Delta: 22 files changed, 501 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ken Buchanan, +1 by Kent Tamura, +1 by Adam Langley, +1 by Alex Moshchuk
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Nov 13, 2024, 1:57:01 PMNov 13
to Martin Kreichgauer, Chromium LUCI CQ, Alex Moshchuk, Kent Tamura, Ken Buchanan, Adam Langley, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Khalid Peer added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Khalid Peer . resolved
It looks like this CL has resulted in a tree-blocking failure: https://cr-buildbucket.appspot.com/build/8731360337266560177
I'll go ahead and submit a revert in order to remedy this ASAP.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Khalid Peer (Gerrit)
Nov 13, 2024, 1:58:25 PMNov 13
to Martin Kreichgauer, Chromium LUCI CQ, Alex Moshchuk, Kent Tamura, Ken Buchanan, Adam Langley, Christian Biesinger, Chromium Metrics Reviews, chromium...@chromium.org, Kaan Icer, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Khalid Peer has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages