DevTools DirectSockets Multicast Capabilities [chromium/src : main]

0 views
Skip to first unread message

Vlad Krot (Gerrit)

unread,
Nov 12, 2025, 8:05:46 AM11/12/25
to Bhaskar Sharma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Simon Hangl, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org
Attention needed from Bhaskar Sharma

Vlad Krot added 4 comments

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc
Line 168, Patchset 9 (Latest): String::Number(inspector_id_),
Vlad Krot . unresolved

String::Number(inspector_id_) this conversion is not needed. Just inspector_id_.
Here and elsewhere.

File third_party/blink/renderer/modules/direct_sockets/multicast_controller_unittest.cc
Line 95, Patchset 9 (Latest): scope.GetExecutionContext(), udp_socket, /*inspector_id=*/12345);
Vlad Krot . unresolved

Why not just 0? To prevent people asking about meaning of this number.

File third_party/blink/web_tests/VirtualTestSuites
Line 1800, Patchset 9 (Latest): "--enable-features=IsolatedWebApps,IsolatedWebAppDevMode,MulticastInDirectSockets,DirectSocketsInServiceWorkers,DirectSocketsInSharedWorkers"
Vlad Krot . unresolved

Not needed. Multicast is enabled by default.

File third_party/blink/web_tests/http/tests/inspector-protocol/network/direct-sockets/resources/udp-socket-multicast.php
Line 4, Patchset 9 (Latest):header("Permissions-Policy: direct-sockets=(self)");
Vlad Krot . unresolved

More permissions policies are needed: direct-sockets-private, direct-sockets-multicast.

Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I809e98210daa15942af4acbfe7469233c8bbe6a0
Gerrit-Change-Number: 7130659
Gerrit-PatchSet: 9
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Vlad Krot <vk...@google.com>
Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 13:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Krot (Gerrit)

unread,
Nov 12, 2025, 8:06:22 AM11/12/25
to Bhaskar Sharma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Simon Hangl, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org
Attention needed from Bhaskar Sharma

Vlad Krot added 1 comment

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
Line 80, Patchset 9 (Latest): const uint64_t inspector_id_;
Vlad Krot . unresolved

Copy please comment from udp socket what is this inspector_id_

Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I809e98210daa15942af4acbfe7469233c8bbe6a0
Gerrit-Change-Number: 7130659
Gerrit-PatchSet: 9
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 13:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Rayskiy (Gerrit)

unread,
Nov 12, 2025, 7:54:55 PM11/12/25
to Bhaskar Sharma, Vlad Krot, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Simon Hangl, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org
Attention needed from Bhaskar Sharma

Andrew Rayskiy added 1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Andrew Rayskiy . resolved

Please add a bug to the CL!

Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I809e98210daa15942af4acbfe7469233c8bbe6a0
Gerrit-Change-Number: 7130659
Gerrit-PatchSet: 10
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Comment-Date: Thu, 13 Nov 2025 00:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vlad Krot (Gerrit)

unread,
Nov 13, 2025, 3:39:26 AM11/13/25
to Bhaskar Sharma, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Simon Hangl, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, rmcelra...@chromium.org
Attention needed from Bhaskar Sharma

Vlad Krot added 1 comment

File third_party/blink/renderer/core/inspector/inspector_network_agent.cc
Line 2330, Patchset 10 (Latest): String::Number(inspector_id), ipAddress);
Vlad Krot . unresolved

Why inspector_id is passed not like in other functions?

IdentifiersFactory::SubresourceRequestId(identifier)

Gerrit-Comment-Date: Thu, 13 Nov 2025 08:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages