[webaudio-testharness] Migrate oscillator-basic.html [chromium/src : main]

0 views

Skip to first unread message

Hongchan Choi (Gerrit)

unread,

Sep 22, 2025, 2:43:50 PM (2 days ago) Sep 22

to Saqlain, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Michael Wilson and Saqlain

Hongchan Choi voted and added 3 comments

Votes added by Hongchan Choi

Code-Review

3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Hongchan Choi . resolved

LGTM with nits

That was a clean migration!

File third_party/blink/web_tests/webaudio/Oscillator/oscillator-basic.html

Line 1, Patchset 3 (Latest):

<!--
Create an oscillator of each type and verify that the type is set correctly.
-->

Hongchan Choi . unresolved

Move this comment to L17 as an overview comment for this test.

Line 35, Patchset 3 (Latest): "osc.type = '" + oscTypes[k] + "'");

Hongchan Choi . unresolved

```suggestion
              `osc.type = "${oscTypes[k]}"`);
```

Open in Gerrit

Related details

Attention is currently required from:

Michael Wilson
Saqlain

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Saqlain (Gerrit)

unread,

Sep 23, 2025, 6:38:49 PM (15 hours ago) Sep 23

to Hongchan Choi, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Hongchan Choi and Michael Wilson

Saqlain added 2 comments

File third_party/blink/web_tests/webaudio/Oscillator/oscillator-basic.html

Line 1, Patchset 3:<!--


Create an oscillator of each type and verify that the type is set correctly.
-->

Hongchan Choi . resolved

Move this comment to L17 as an overview comment for this test.

Saqlain

Done

Line 35, Patchset 3: "osc.type = '" + oscTypes[k] + "'");

Hongchan Choi . resolved

```suggestion
              `osc.type = "${oscTypes[k]}"`);
```

Saqlain

Fix applied.

Open in Gerrit

Related details

Attention is currently required from:

Hongchan Choi
Michael Wilson

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages