[Memory Coordinator] Add traits to Resource::Resource [chromium/src : main]
0 views
Skip to first unread message
Andres Ricardo Perez Rojas (Gerrit)
Jun 30, 2026, 3:22:23 PM (6 days ago) Jun 30
to Yoshisato Yanagisawa, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Yoshisato Yanagisawa
Andres Ricardo Perez Rojas added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Jul 3, 2026, 3:31:01 AM (4 days ago) Jul 3
to Andres Ricardo Perez Rojas, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Andres Ricardo Perez Rojas
Yoshisato Yanagisawa added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Yoshisato Yanagisawa . unresolved
Will you double check the data type and its value? I feel there is an inconsistency.
File third_party/blink/renderer/platform/loader/fetch/resource.cc
Line 177, Patchset 2 (Latest):
base::MemoryConsumerTraits::ReleaseMemoryCost::kFreesPagesWithoutTraversal,Yoshisato Yanagisawa . unresolved
This may not match with the explanation?
Please make sure base::MemoryConsumerTraits::RecreateMemoryCost::kNA (default) is the valid data. I assume so because it is not easy to recreate.
Line 182, Patchset 2 (Latest):
// Holds references managed by Blink Oilpan GC.Yoshisato Yanagisawa . unresolved
Do you mean V8? Olpan is this GC system?
Related details
Attention is currently required from:
- Andres Ricardo Perez Rojas
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andres Ricardo Perez Rojas (Gerrit)
Jul 3, 2026, 12:43:14 PM (3 days ago) Jul 3
to Code Review Nudger, Yoshisato Yanagisawa, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Yoshisato Yanagisawa
Andres Ricardo Perez Rojas added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Andres Ricardo Perez Rojas . resolved
PTAnL!
File third_party/blink/renderer/platform/loader/fetch/resource.cc
Line 177, Patchset 2:
base::MemoryConsumerTraits::ReleaseMemoryCost::kFreesPagesWithoutTraversal,Yoshisato Yanagisawa . resolved
This may not match with the explanation?
Please make sure base::MemoryConsumerTraits::RecreateMemoryCost::kNA (default) is the valid data. I assume so because it is not easy to recreate.
Andres Ricardo Perez Rojas
You are right, sorry for the oversight. I have added `RecreateMemoryCost::kExpensive`. PTAL!
Line 182, Patchset 2:
// Holds references managed by Blink Oilpan GC.Yoshisato Yanagisawa . resolved
Do you mean V8? Olpan is this GC system?
Andres Ricardo Perez Rojas
The trait applies to Oilpan GC references as well. I'll look into updating the description on `traits.h` as a follow up. Thank you!
Related details
Attention is currently required from:
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
2:16 AM (14 hours ago) 2:16 AM
to Andres Ricardo Perez Rojas, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Andres Ricardo Perez Rojas
Yoshisato Yanagisawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andres Ricardo Perez Rojas
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andres Ricardo Perez Rojas (Gerrit)
10:04 AM (6 hours ago) 10:04 AM
to Yoshisato Yanagisawa, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Andres Ricardo Perez Rojas voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andres Ricardo Perez Rojas
| Commit-Queue | +2 |
Will you double check the data type and its value? I feel there is an inconsistency.
Andres Ricardo Perez Rojas
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:20 AM (5 hours ago) 11:20 AM
to Andres Ricardo Perez Rojas, Yoshisato Yanagisawa, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Memory Coordinator] Add traits to Resource::Resource
Updates Resource::Resource to explicitly define its memory coordination
semantics using MemoryConsumerTraits. This provides the global Memory
Coordinator with accurate information regarding the scale, eviction
cost, and statefulness of the cache to optimize system-wide memory
reclamation decisions.
Bug: 489671163
Change-Id: Ib7be5e20195d07302634c9e4da75b108d655734c
Commit-Queue: Andres Ricardo Perez Rojas <andres...@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1657205}
Files:
- M third_party/blink/renderer/platform/loader/fetch/resource.cc
Change size: S
Delta: 1 file changed, 18 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yoshisato Yanagisawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages