Add workers support to Multicast [chromium/src : main]
0 views
Skip to first unread message
Vlad Krot (Gerrit)
Sep 15, 2025, 11:18:46 AM9/15/25
to Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, Simon Hangl, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy
Vlad Krot voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Andrew Rayskiy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Rayskiy (Gerrit)
Sep 15, 2025, 11:23:23 AM9/15/25
to Vlad Krot, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Simon Hangl and Vlad Krot
Andrew Rayskiy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrew Rayskiy
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
Line 64, Patchset 2 (Latest):
if (execution_context->IsWindow() ||Andrew Rayskiy . unresolved
There's some visible code duplication here?
Related details
Attention is currently required from:
- Simon Hangl
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Krot (Gerrit)
Sep 15, 2025, 11:36:07 AM9/15/25
to Andrew Rayskiy, Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy and Simon Hangl
Vlad Krot added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
Line 64, Patchset 2 (Latest):
if (execution_context->IsWindow() ||Andrew Rayskiy . unresolved
There's some visible code duplication here?
Vlad Krot
Yes, I also thought about it, but did not find how to avoid it.
One function checks permissions policy and flag and throws detailed exception about it, the other one does not throw.
Related details
Attention is currently required from:
- Andrew Rayskiy
- Simon Hangl
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Hangl (Gerrit)
Sep 15, 2025, 11:43:01 AM9/15/25
to Vlad Krot, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy and Vlad Krot
Simon Hangl voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Rayskiy
- Vlad Krot
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Krot (Gerrit)
Sep 16, 2025, 4:22:58 AM9/16/25
to Simon Hangl, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy
Vlad Krot added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
Line 64, Patchset 2 (Latest):
if (execution_context->IsWindow() ||Andrew Rayskiy . resolved
Vlad KrotThere's some visible code duplication here?
Yes, I also thought about it, but did not find how to avoid it.
One function checks permissions policy and flag and throws detailed exception about it, the other one does not throw.
Vlad Krot
Acknowledged
Related details
Attention is currently required from:
- Andrew Rayskiy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vlad Krot (Gerrit)
Sep 16, 2025, 4:23:03 AM9/16/25
to Simon Hangl, Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy
Vlad Krot voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Andrew Rayskiy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 16, 2025, 4:28:04 AM9/16/25
to Vlad Krot, Simon Hangl, Andrew Rayskiy, chromium...@chromium.org, pwa-com...@google.com, blink-...@chromium.org, jmedle...@chromium.org, rmcelra...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add workers support to Multicast
Exposed MulticastController in Service/Shared workers. For now, there's
no way to check permission policy in these workers, thus multicast can
be used without the permissions policy 'direct-sockets-multicast'. Todo
is left to fix it in the appropriate places.
Explainer
https://github.com/explainers-by-googlers/multicast-in-direct-sockets.
Chrome Entry https://chromestatus.com/feature/5073740211814400 Intent to
prototype
https://groups.google.com/a/chromium.org/g/blink-dev/c/ADV4FZtN4nE
Bug: 398934282
Change-Id: I2811745f9dbdd4dbba2c567792ff5e51cb5b03a9
Reviewed-by: Andrew Rayskiy <green...@google.com>
Commit-Queue: Vlad Krot <vk...@google.com>
Reviewed-by: Simon Hangl <sim...@google.com>
Cr-Commit-Position: refs/heads/main@{#1515906}
Files:
- M chrome/browser/direct_sockets/direct_sockets_apitest.cc
- M content/browser/direct_sockets/direct_sockets_service_impl.cc
- M third_party/blink/renderer/modules/direct_sockets/multicast_controller.idl
- M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
Change size: M
Delta: 4 files changed, 128 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Simon Hangl, +1 by Andrew Rayskiy
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages